From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/4] pxa: add namespace on ssp
Date: Thu, 1 Apr 2010 09:54:20 +0100 [thread overview]
Message-ID: <20100401085419.GC32025@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <g2w771cded01004010045n56803dfbge90d3a70a731977d@mail.gmail.com>
On Thu, Apr 01, 2010 at 03:45:03PM +0800, Haojian Zhuang wrote:
> On Thu, Apr 1, 2010 at 3:33 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
> > This is not necessary, provided that those functions are static already.
> > Unless this driver is going to support a different SSP, in which case a
> > separate driver is needed then.
> > What's the real motivation behind this?
> It's the request from Mark. Both ssp_ and pxa_ssp_ prefix exist in
> pxa-ssp.c. From the view of naming space, it's not align.
Just to be clear, the main issue was that subsequent patches in the
series made the symbols exported at which point they end up in the
global namespace and the potential confusion is an issue.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] pxa: add namespace on ssp
Date: Thu, 1 Apr 2010 09:54:20 +0100 [thread overview]
Message-ID: <20100401085419.GC32025@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <g2w771cded01004010045n56803dfbge90d3a70a731977d@mail.gmail.com>
On Thu, Apr 01, 2010 at 03:45:03PM +0800, Haojian Zhuang wrote:
> On Thu, Apr 1, 2010 at 3:33 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
> > This is not necessary, provided that those functions are static already.
> > Unless this driver is going to support a different SSP, in which case a
> > separate driver is needed then.
> > What's the real motivation behind this?
> It's the request from Mark. Both ssp_ and pxa_ssp_ prefix exist in
> pxa-ssp.c. From the view of naming space, it's not align.
Just to be clear, the main issue was that subsequent patches in the
series made the symbols exported at which point they end up in the
global namespace and the potential confusion is an issue.
next prev parent reply other threads:[~2010-04-01 8:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 12:46 [PATCH 1/4] pxa: add namespace on ssp Haojian Zhuang
2010-03-31 12:46 ` Haojian Zhuang
2010-04-01 7:33 ` Eric Miao
2010-04-01 7:33 ` Eric Miao
2010-04-01 7:45 ` Haojian Zhuang
2010-04-01 7:45 ` Haojian Zhuang
2010-04-01 8:54 ` Mark Brown [this message]
2010-04-01 8:54 ` Mark Brown
2010-04-09 11:16 ` Mark Brown
2010-04-09 11:16 ` [alsa-devel] " Mark Brown
2010-04-16 3:54 ` Haojian Zhuang
2010-04-16 3:54 ` [alsa-devel] " Haojian Zhuang
2010-04-17 1:54 ` Mark Brown
2010-04-17 1:54 ` [alsa-devel] " Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-04-17 5:34 Haojian Zhuang
2010-04-17 5:34 ` Haojian Zhuang
2010-04-19 11:35 ` Liam Girdwood
2010-04-19 11:35 ` Liam Girdwood
2010-04-21 22:17 ` Eric Miao
2010-04-21 22:17 ` Eric Miao
2010-04-21 23:37 ` Mark Brown
2010-04-21 23:37 ` Mark Brown
2010-04-22 0:08 ` Mark Brown
2010-04-22 0:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401085419.GC32025@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.