From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/4] pxa: add namespace on ssp
Date: Thu, 22 Apr 2010 09:08:18 +0900 [thread overview]
Message-ID: <20100422000817.GB22879@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <q2yf17812d71004211517kf54116acxe788927a53048e26@mail.gmail.com>
On Thu, Apr 22, 2010 at 06:17:29AM +0800, Eric Miao wrote:
> On Sat, Apr 17, 2010 at 1:34 PM, Haojian Zhuang
> > In order to prevent code ambiguous, add namespace on functions in ssp driver.
> Sorry I'm still not convinced that this is a necessary change, could
> you point me to some place where there are naming conflicts?
Oh, sorry - misread the patch that was being replied to. The issue is
more around consistency and the fact that ssp_ is pretty short as it is
about specific conflicts that exist. If the rest of the driver had been
using ssp_ already I wouldn't have said anything but since currently
exported symbols all use pxa2xx_ it seemed better to make newly exported
ones match.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] pxa: add namespace on ssp
Date: Thu, 22 Apr 2010 09:08:18 +0900 [thread overview]
Message-ID: <20100422000817.GB22879@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <q2yf17812d71004211517kf54116acxe788927a53048e26@mail.gmail.com>
On Thu, Apr 22, 2010 at 06:17:29AM +0800, Eric Miao wrote:
> On Sat, Apr 17, 2010 at 1:34 PM, Haojian Zhuang
> > In order to prevent code ambiguous, add namespace on functions in ssp driver.
> Sorry I'm still not convinced that this is a necessary change, could
> you point me to some place where there are naming conflicts?
Oh, sorry - misread the patch that was being replied to. The issue is
more around consistency and the fact that ssp_ is pretty short as it is
about specific conflicts that exist. If the rest of the driver had been
using ssp_ already I wouldn't have said anything but since currently
exported symbols all use pxa2xx_ it seemed better to make newly exported
ones match.
next prev parent reply other threads:[~2010-04-22 0:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 5:34 [PATCH 1/4] pxa: add namespace on ssp Haojian Zhuang
2010-04-17 5:34 ` Haojian Zhuang
2010-04-19 11:35 ` Liam Girdwood
2010-04-19 11:35 ` Liam Girdwood
2010-04-21 22:17 ` Eric Miao
2010-04-21 22:17 ` Eric Miao
2010-04-21 23:37 ` Mark Brown
2010-04-21 23:37 ` Mark Brown
2010-04-22 0:08 ` Mark Brown [this message]
2010-04-22 0:08 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-03-31 12:46 Haojian Zhuang
2010-03-31 12:46 ` Haojian Zhuang
2010-04-01 7:33 ` Eric Miao
2010-04-01 7:33 ` Eric Miao
2010-04-01 7:45 ` Haojian Zhuang
2010-04-01 7:45 ` Haojian Zhuang
2010-04-01 8:54 ` Mark Brown
2010-04-01 8:54 ` Mark Brown
2010-04-09 11:16 ` Mark Brown
2010-04-16 3:54 ` Haojian Zhuang
2010-04-17 1:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422000817.GB22879@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.