From: Joerg Roedel <joro@8bytes.org>
To: Dan Carpenter <error27@gmail.com>,
Joerg Roedel <joerg.roedel@amd.com>, Ingo Molnar <mingo@elte.hu>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Shaun Ruffell <sruffell@digium.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] dma-debug: off by one issue
Date: Mon, 05 Apr 2010 14:09:09 +0000 [thread overview]
Message-ID: <20100405140909.GB29758@8bytes.org> (raw)
In-Reply-To: <20100405140215.GA29758@8bytes.org>
On Mon, Apr 05, 2010 at 04:02:15PM +0200, Joerg Roedel wrote:
> On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote:
> > On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:
>
> > > The character is already reserved by the user-to-kernel copy earlier in
> > > the function.
> >
> > Yes, but the original code requires more code reading to audit. Let's
> > change the commit message to say that it's a clean up patch.
>
> In this case its better to remove the
>
> current_driver_name[i] = 0;
>
> line just after the loop.
Ah no, thats nonsense. Mind to resend the patch with a new
commit-message? I'll queue it then tomorrow.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Dan Carpenter <error27@gmail.com>,
Joerg Roedel <joerg.roedel@amd.com>, Ingo Molnar <mingo@elte.hu>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Shaun Ruffell <sruffell@digium.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] dma-debug: off by one issue
Date: Mon, 5 Apr 2010 16:09:09 +0200 [thread overview]
Message-ID: <20100405140909.GB29758@8bytes.org> (raw)
In-Reply-To: <20100405140215.GA29758@8bytes.org>
On Mon, Apr 05, 2010 at 04:02:15PM +0200, Joerg Roedel wrote:
> On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote:
> > On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:
>
> > > The character is already reserved by the user-to-kernel copy earlier in
> > > the function.
> >
> > Yes, but the original code requires more code reading to audit. Let's
> > change the commit message to say that it's a clean up patch.
>
> In this case its better to remove the
>
> current_driver_name[i] = 0;
>
> line just after the loop.
Ah no, thats nonsense. Mind to resend the patch with a new
commit-message? I'll queue it then tomorrow.
Joerg
next prev parent reply other threads:[~2010-04-05 14:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 11:28 [patch] dma-debug: off by one issue Dan Carpenter
2010-04-02 11:28 ` Dan Carpenter
2010-04-03 20:47 ` Joerg Roedel
2010-04-03 20:47 ` Joerg Roedel
2010-04-05 12:53 ` Dan Carpenter
2010-04-05 12:53 ` Dan Carpenter
2010-04-05 14:02 ` Joerg Roedel
2010-04-05 14:02 ` Joerg Roedel
2010-04-05 14:09 ` Joerg Roedel [this message]
2010-04-05 14:09 ` Joerg Roedel
2010-04-06 16:45 ` [patch v2] dma-debug: cleanup for loop Dan Carpenter
2010-04-06 16:45 ` Dan Carpenter
2010-04-07 10:05 ` Joerg Roedel
2010-04-07 10:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100405140909.GB29758@8bytes.org \
--to=joro@8bytes.org \
--cc=error27@gmail.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=joerg.roedel@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sruffell@digium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.