* [patch] dma-debug: off by one issue
@ 2010-04-02 11:28 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2010-04-02 11:28 UTC (permalink / raw)
To: Joerg Roedel
Cc: Ingo Molnar, FUJITA Tomonori, Shaun Ruffell, linux-kernel,
kernel-janitors
We need to reserve the last character for the NULL terminator.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index ba8b670..01e6427 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
* Now parse out the first token and use it as the name for the
* driver to filter for.
*/
- for (i = 0; i < NAME_MAX_LEN; ++i) {
+ for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
current_driver_name[i] = buf[i];
if (isspace(buf[i]) || buf[i] = ' ' || buf[i] = 0)
break;
^ permalink raw reply related [flat|nested] 14+ messages in thread* [patch] dma-debug: off by one issue
@ 2010-04-02 11:28 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2010-04-02 11:28 UTC (permalink / raw)
To: Joerg Roedel
Cc: Ingo Molnar, FUJITA Tomonori, Shaun Ruffell, linux-kernel,
kernel-janitors
We need to reserve the last character for the NULL terminator.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index ba8b670..01e6427 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
* Now parse out the first token and use it as the name for the
* driver to filter for.
*/
- for (i = 0; i < NAME_MAX_LEN; ++i) {
+ for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
current_driver_name[i] = buf[i];
if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0)
break;
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [patch] dma-debug: off by one issue
2010-04-02 11:28 ` Dan Carpenter
@ 2010-04-03 20:47 ` Joerg Roedel
-1 siblings, 0 replies; 14+ messages in thread
From: Joerg Roedel @ 2010-04-03 20:47 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel, Ingo Molnar, FUJITA Tomonori,
Shaun Ruffell, linux-kernel, kernel-janitors
On Fri, Apr 02, 2010 at 02:28:43PM +0300, Dan Carpenter wrote:
> We need to reserve the last character for the NULL terminator.
The character is already reserved by the user-to-kernel copy earlier in
the function.
Joerg
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index ba8b670..01e6427 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
> * Now parse out the first token and use it as the name for the
> * driver to filter for.
> */
> - for (i = 0; i < NAME_MAX_LEN; ++i) {
> + for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
> current_driver_name[i] = buf[i];
> if (isspace(buf[i]) || buf[i] = ' ' || buf[i] = 0)
> break;
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [patch] dma-debug: off by one issue
@ 2010-04-03 20:47 ` Joerg Roedel
0 siblings, 0 replies; 14+ messages in thread
From: Joerg Roedel @ 2010-04-03 20:47 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel, Ingo Molnar, FUJITA Tomonori,
Shaun Ruffell, linux-kernel, kernel-janitors
On Fri, Apr 02, 2010 at 02:28:43PM +0300, Dan Carpenter wrote:
> We need to reserve the last character for the NULL terminator.
The character is already reserved by the user-to-kernel copy earlier in
the function.
Joerg
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index ba8b670..01e6427 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
> * Now parse out the first token and use it as the name for the
> * driver to filter for.
> */
> - for (i = 0; i < NAME_MAX_LEN; ++i) {
> + for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
> current_driver_name[i] = buf[i];
> if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0)
> break;
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [patch] dma-debug: off by one issue
2010-04-03 20:47 ` Joerg Roedel
@ 2010-04-05 12:53 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2010-04-05 12:53 UTC (permalink / raw)
To: Joerg Roedel
Cc: Joerg Roedel, Ingo Molnar, FUJITA Tomonori, Shaun Ruffell,
linux-kernel, kernel-janitors
On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:
> On Fri, Apr 02, 2010 at 02:28:43PM +0300, Dan Carpenter wrote:
> > We need to reserve the last character for the NULL terminator.
>
> The character is already reserved by the user-to-kernel copy earlier in
> the function.
>
> Joerg
>
Yes, but the original code requires more code reading to audit. Let's
change the commit message to say that it's a clean up patch.
regards,
dan carpenter
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> > index ba8b670..01e6427 100644
> > --- a/lib/dma-debug.c
> > +++ b/lib/dma-debug.c
> > @@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
> > * Now parse out the first token and use it as the name for the
> > * driver to filter for.
> > */
> > - for (i = 0; i < NAME_MAX_LEN; ++i) {
> > + for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
> > current_driver_name[i] = buf[i];
> > if (isspace(buf[i]) || buf[i] = ' ' || buf[i] = 0)
> > break;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [patch] dma-debug: off by one issue
@ 2010-04-05 12:53 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2010-04-05 12:53 UTC (permalink / raw)
To: Joerg Roedel
Cc: Joerg Roedel, Ingo Molnar, FUJITA Tomonori, Shaun Ruffell,
linux-kernel, kernel-janitors
On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:
> On Fri, Apr 02, 2010 at 02:28:43PM +0300, Dan Carpenter wrote:
> > We need to reserve the last character for the NULL terminator.
>
> The character is already reserved by the user-to-kernel copy earlier in
> the function.
>
> Joerg
>
Yes, but the original code requires more code reading to audit. Let's
change the commit message to say that it's a clean up patch.
regards,
dan carpenter
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> > index ba8b670..01e6427 100644
> > --- a/lib/dma-debug.c
> > +++ b/lib/dma-debug.c
> > @@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
> > * Now parse out the first token and use it as the name for the
> > * driver to filter for.
> > */
> > - for (i = 0; i < NAME_MAX_LEN; ++i) {
> > + for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
> > current_driver_name[i] = buf[i];
> > if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0)
> > break;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [patch] dma-debug: off by one issue
2010-04-05 12:53 ` Dan Carpenter
@ 2010-04-05 14:02 ` Joerg Roedel
-1 siblings, 0 replies; 14+ messages in thread
From: Joerg Roedel @ 2010-04-05 14:02 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel, Ingo Molnar, FUJITA Tomonori,
Shaun Ruffell, linux-kernel, kernel-janitors
On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote:
> On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:
> > The character is already reserved by the user-to-kernel copy earlier in
> > the function.
>
> Yes, but the original code requires more code reading to audit. Let's
> change the commit message to say that it's a clean up patch.
In this case its better to remove the
current_driver_name[i] = 0;
line just after the loop.
Joerg
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch] dma-debug: off by one issue
@ 2010-04-05 14:02 ` Joerg Roedel
0 siblings, 0 replies; 14+ messages in thread
From: Joerg Roedel @ 2010-04-05 14:02 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel, Ingo Molnar, FUJITA Tomonori,
Shaun Ruffell, linux-kernel, kernel-janitors
On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote:
> On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:
> > The character is already reserved by the user-to-kernel copy earlier in
> > the function.
>
> Yes, but the original code requires more code reading to audit. Let's
> change the commit message to say that it's a clean up patch.
In this case its better to remove the
current_driver_name[i] = 0;
line just after the loop.
Joerg
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch] dma-debug: off by one issue
2010-04-05 14:02 ` Joerg Roedel
@ 2010-04-05 14:09 ` Joerg Roedel
-1 siblings, 0 replies; 14+ messages in thread
From: Joerg Roedel @ 2010-04-05 14:09 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel, Ingo Molnar, FUJITA Tomonori,
Shaun Ruffell, linux-kernel, kernel-janitors
On Mon, Apr 05, 2010 at 04:02:15PM +0200, Joerg Roedel wrote:
> On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote:
> > On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:
>
> > > The character is already reserved by the user-to-kernel copy earlier in
> > > the function.
> >
> > Yes, but the original code requires more code reading to audit. Let's
> > change the commit message to say that it's a clean up patch.
>
> In this case its better to remove the
>
> current_driver_name[i] = 0;
>
> line just after the loop.
Ah no, thats nonsense. Mind to resend the patch with a new
commit-message? I'll queue it then tomorrow.
Joerg
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch] dma-debug: off by one issue
@ 2010-04-05 14:09 ` Joerg Roedel
0 siblings, 0 replies; 14+ messages in thread
From: Joerg Roedel @ 2010-04-05 14:09 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel, Ingo Molnar, FUJITA Tomonori,
Shaun Ruffell, linux-kernel, kernel-janitors
On Mon, Apr 05, 2010 at 04:02:15PM +0200, Joerg Roedel wrote:
> On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote:
> > On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:
>
> > > The character is already reserved by the user-to-kernel copy earlier in
> > > the function.
> >
> > Yes, but the original code requires more code reading to audit. Let's
> > change the commit message to say that it's a clean up patch.
>
> In this case its better to remove the
>
> current_driver_name[i] = 0;
>
> line just after the loop.
Ah no, thats nonsense. Mind to resend the patch with a new
commit-message? I'll queue it then tomorrow.
Joerg
^ permalink raw reply [flat|nested] 14+ messages in thread
* [patch v2] dma-debug: cleanup for loop
2010-04-05 14:09 ` Joerg Roedel
@ 2010-04-06 16:45 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2010-04-06 16:45 UTC (permalink / raw)
To: Joerg Roedel
Cc: Joerg Roedel, Ingo Molnar, FUJITA Tomonori, Shaun Ruffell,
linux-kernel, kernel-janitors
Earlier in this function we set the last byte of "buf" to NULL so we
always hit the break statement and "i" is never equal to NAME_MAX_LEN.
This patch doesn't change how the driver works but it silences a Smatch
warning and it makes it clearer that we don't write past the end of the
array.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index ba8b670..01e6427 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
* Now parse out the first token and use it as the name for the
* driver to filter for.
*/
- for (i = 0; i < NAME_MAX_LEN; ++i) {
+ for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
current_driver_name[i] = buf[i];
if (isspace(buf[i]) || buf[i] = ' ' || buf[i] = 0)
break;
^ permalink raw reply related [flat|nested] 14+ messages in thread* [patch v2] dma-debug: cleanup for loop
@ 2010-04-06 16:45 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2010-04-06 16:45 UTC (permalink / raw)
To: Joerg Roedel
Cc: Joerg Roedel, Ingo Molnar, FUJITA Tomonori, Shaun Ruffell,
linux-kernel, kernel-janitors
Earlier in this function we set the last byte of "buf" to NULL so we
always hit the break statement and "i" is never equal to NAME_MAX_LEN.
This patch doesn't change how the driver works but it silences a Smatch
warning and it makes it clearer that we don't write past the end of the
array.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index ba8b670..01e6427 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
* Now parse out the first token and use it as the name for the
* driver to filter for.
*/
- for (i = 0; i < NAME_MAX_LEN; ++i) {
+ for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
current_driver_name[i] = buf[i];
if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0)
break;
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [patch v2] dma-debug: cleanup for loop
2010-04-06 16:45 ` Dan Carpenter
@ 2010-04-07 10:05 ` Joerg Roedel
-1 siblings, 0 replies; 14+ messages in thread
From: Joerg Roedel @ 2010-04-07 10:05 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel, Ingo Molnar, FUJITA Tomonori,
Shaun Ruffell, linux-kernel, kernel-janitors
On Tue, Apr 06, 2010 at 07:45:12PM +0300, Dan Carpenter wrote:
> Earlier in this function we set the last byte of "buf" to NULL so we
> always hit the break statement and "i" is never equal to NAME_MAX_LEN.
> This patch doesn't change how the driver works but it silences a Smatch
> warning and it makes it clearer that we don't write past the end of the
> array.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index ba8b670..01e6427 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
> * Now parse out the first token and use it as the name for the
> * driver to filter for.
> */
> - for (i = 0; i < NAME_MAX_LEN; ++i) {
> + for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
> current_driver_name[i] = buf[i];
> if (isspace(buf[i]) || buf[i] = ' ' || buf[i] = 0)
> break;
Applied, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [patch v2] dma-debug: cleanup for loop
@ 2010-04-07 10:05 ` Joerg Roedel
0 siblings, 0 replies; 14+ messages in thread
From: Joerg Roedel @ 2010-04-07 10:05 UTC (permalink / raw)
To: Dan Carpenter, Joerg Roedel, Ingo Molnar, FUJITA Tomonori,
Shaun Ruffell, linux-kernel, kernel-janitors
On Tue, Apr 06, 2010 at 07:45:12PM +0300, Dan Carpenter wrote:
> Earlier in this function we set the last byte of "buf" to NULL so we
> always hit the break statement and "i" is never equal to NAME_MAX_LEN.
> This patch doesn't change how the driver works but it silences a Smatch
> warning and it makes it clearer that we don't write past the end of the
> array.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index ba8b670..01e6427 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
> * Now parse out the first token and use it as the name for the
> * driver to filter for.
> */
> - for (i = 0; i < NAME_MAX_LEN; ++i) {
> + for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
> current_driver_name[i] = buf[i];
> if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0)
> break;
Applied, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2010-04-07 10:05 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-02 11:28 [patch] dma-debug: off by one issue Dan Carpenter
2010-04-02 11:28 ` Dan Carpenter
2010-04-03 20:47 ` Joerg Roedel
2010-04-03 20:47 ` Joerg Roedel
2010-04-05 12:53 ` Dan Carpenter
2010-04-05 12:53 ` Dan Carpenter
2010-04-05 14:02 ` Joerg Roedel
2010-04-05 14:02 ` Joerg Roedel
2010-04-05 14:09 ` Joerg Roedel
2010-04-05 14:09 ` Joerg Roedel
2010-04-06 16:45 ` [patch v2] dma-debug: cleanup for loop Dan Carpenter
2010-04-06 16:45 ` Dan Carpenter
2010-04-07 10:05 ` Joerg Roedel
2010-04-07 10:05 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.