All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Li, Shaohua" <shaohua.li@intel.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]vmscan: handle underflow for get_scan_ratio
Date: Tue, 6 Apr 2010 09:22:07 +0800	[thread overview]
Message-ID: <20100406012206.GD5295@localhost> (raw)
In-Reply-To: <20100402180812.646D.A69D9226@jp.fujitsu.com>

> ===================================================================
> >From 52358cbccdfe94e0381974cd6e937bcc6b1c608b Mon Sep 17 00:00:00 2001
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Date: Fri, 2 Apr 2010 17:13:48 +0900
> Subject: [PATCH] Revert "vmscan: get_scan_ratio() cleanup"
> 
> Shaohua Li reported his tmpfs streaming I/O test can lead to make oom.
> The test uses a 6G tmpfs in a system with 3G memory. In the tmpfs,
> there are 6 copies of kernel source and the test does kbuild for each
> copy. His investigation shows the test has a lot of rotated anon
> pages and quite few file pages, so get_scan_ratio calculates percent[0]
> (i.e. scanning percent for anon)  to be zero. Actually the percent[0]
> shoule be a big value, but our calculation round it to zero.

  should      small :)

Acked-by: Wu Fengguang <fengguang.wu@intel.com>

Thanks,
Fengguang

WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Li, Shaohua" <shaohua.li@intel.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]vmscan: handle underflow for get_scan_ratio
Date: Tue, 6 Apr 2010 09:22:07 +0800	[thread overview]
Message-ID: <20100406012206.GD5295@localhost> (raw)
In-Reply-To: <20100402180812.646D.A69D9226@jp.fujitsu.com>

> ===================================================================
> >From 52358cbccdfe94e0381974cd6e937bcc6b1c608b Mon Sep 17 00:00:00 2001
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Date: Fri, 2 Apr 2010 17:13:48 +0900
> Subject: [PATCH] Revert "vmscan: get_scan_ratio() cleanup"
> 
> Shaohua Li reported his tmpfs streaming I/O test can lead to make oom.
> The test uses a 6G tmpfs in a system with 3G memory. In the tmpfs,
> there are 6 copies of kernel source and the test does kbuild for each
> copy. His investigation shows the test has a lot of rotated anon
> pages and quite few file pages, so get_scan_ratio calculates percent[0]
> (i.e. scanning percent for anon)  to be zero. Actually the percent[0]
> shoule be a big value, but our calculation round it to zero.

  should      small :)

Acked-by: Wu Fengguang <fengguang.wu@intel.com>

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-04-06  1:22 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30  5:53 [PATCH]vmscan: handle underflow for get_scan_ratio Shaohua Li
2010-03-30  5:53 ` Shaohua Li
2010-03-30  6:08 ` KOSAKI Motohiro
2010-03-30  6:08   ` KOSAKI Motohiro
2010-03-30  6:32   ` Shaohua Li
2010-03-30  6:40     ` KOSAKI Motohiro
2010-03-30  6:40       ` KOSAKI Motohiro
2010-03-30  6:53       ` Shaohua Li
2010-03-30  6:53         ` Shaohua Li
2010-03-30  7:31         ` KOSAKI Motohiro
2010-03-30  7:31           ` KOSAKI Motohiro
2010-03-30  8:13           ` Shaohua Li
2010-03-30  8:13             ` Shaohua Li
2010-03-31  4:53   ` Shaohua Li
2010-03-31  4:53     ` Shaohua Li
2010-03-31  5:38     ` KOSAKI Motohiro
2010-03-31  5:38       ` KOSAKI Motohiro
2010-03-31  5:51       ` Wu Fengguang
2010-03-31  5:51         ` Wu Fengguang
2010-03-31  6:00         ` KOSAKI Motohiro
2010-03-31  6:00           ` KOSAKI Motohiro
2010-03-31  6:03           ` Wu Fengguang
2010-03-31  6:03             ` Wu Fengguang
2010-04-01 22:16           ` Andrew Morton
2010-04-01 22:16             ` Andrew Morton
2010-04-02  9:13             ` KOSAKI Motohiro
2010-04-02  9:13               ` KOSAKI Motohiro
2010-04-06  1:22               ` Wu Fengguang [this message]
2010-04-06  1:22                 ` Wu Fengguang
2010-04-06  3:36               ` Rik van Riel
2010-04-06  3:36                 ` Rik van Riel
2010-03-31  5:53       ` KOSAKI Motohiro
2010-03-31  5:53         ` KOSAKI Motohiro
2010-04-02  6:50         ` Shaohua Li
2010-04-02  6:50           ` Shaohua Li
2010-04-02  9:14           ` KOSAKI Motohiro
2010-04-02  9:14             ` KOSAKI Motohiro
2010-04-02  9:24             ` Shaohua Li
2010-04-02  9:24               ` Shaohua Li
2010-04-04 14:19               ` KOSAKI Motohiro
2010-04-04 14:19                 ` KOSAKI Motohiro
2010-04-06  1:25                 ` Shaohua Li
2010-04-06  1:25                   ` Shaohua Li
2010-04-06  1:36                   ` KOSAKI Motohiro
2010-04-06  1:36                     ` KOSAKI Motohiro
2010-04-06  1:50                   ` Wu Fengguang
2010-04-06  1:50                     ` Wu Fengguang
2010-04-06  2:06                     ` KOSAKI Motohiro
2010-04-06  2:06                       ` KOSAKI Motohiro
2010-04-06  2:30                       ` Wu Fengguang
2010-04-06  2:30                         ` Wu Fengguang
2010-04-06  2:58                         ` KOSAKI Motohiro
2010-04-06  2:58                           ` KOSAKI Motohiro
2010-04-06  3:31                           ` Wu Fengguang
2010-04-06  3:31                             ` Wu Fengguang
2010-04-06  3:40                             ` Rik van Riel
2010-04-06  3:40                               ` Rik van Riel
2010-04-06  4:49                               ` Wu Fengguang
2010-04-06  4:49                                 ` Wu Fengguang
2010-04-06  5:09                                 ` Shaohua Li
2010-04-06  5:09                                   ` Shaohua Li
2010-04-04  0:48           ` Wu Fengguang
2010-04-04  0:48             ` Wu Fengguang
2010-04-06  1:27             ` Shaohua Li
2010-04-06  1:27               ` Shaohua Li
2010-04-06  5:03           ` Wu Fengguang
2010-04-06  5:03             ` Wu Fengguang
2010-04-06  5:36             ` Shaohua Li
2010-04-06  5:36               ` Shaohua Li
2010-04-09  6:51             ` Shaohua Li
2010-04-09  6:51               ` Shaohua Li
2010-04-09 21:20               ` Andrew Morton
2010-04-09 21:20                 ` Andrew Morton
2010-04-09 21:25                 ` Rik van Riel
2010-04-09 21:25                   ` Rik van Riel
2010-04-13  1:30                   ` KOSAKI Motohiro
2010-04-13  1:30                     ` KOSAKI Motohiro
2010-04-13  2:42                     ` Rik van Riel
2010-04-13  2:42                       ` Rik van Riel
2010-04-13  7:55                       ` KOSAKI Motohiro
2010-04-13  7:55                         ` KOSAKI Motohiro
2010-04-13  8:55                         ` KOSAKI Motohiro
2010-04-13  8:55                           ` KOSAKI Motohiro
2010-04-14  1:27                           ` Shaohua Li
2010-04-14  1:27                             ` Shaohua Li
2010-04-15  3:25                             ` KOSAKI Motohiro
2010-04-15  3:25                               ` KOSAKI Motohiro
2010-04-12  1:57                 ` Shaohua Li
2010-04-12  1:57                   ` Shaohua Li
2010-03-31  5:41     ` Wu Fengguang
2010-03-31  5:41       ` Wu Fengguang
2010-03-30 10:17 ` Minchan Kim
2010-03-30 10:17   ` Minchan Kim
2010-03-30 10:25   ` KOSAKI Motohiro
2010-03-30 10:25     ` KOSAKI Motohiro
2010-03-30 11:56 ` Balbir Singh
2010-03-30 11:56   ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100406012206.GD5295@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.