From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
"Li, Shaohua" <shaohua.li@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]vmscan: handle underflow for get_scan_ratio
Date: Mon, 05 Apr 2010 23:36:56 -0400 [thread overview]
Message-ID: <4BBAAC58.80108@redhat.com> (raw)
In-Reply-To: <20100402180812.646D.A69D9226@jp.fujitsu.com>
On 04/02/2010 05:13 AM, KOSAKI Motohiro wrote:
>>> Yeah, I don't want ignore .33-stable too. if I can't find the root cause
>>> in 2-3 days, I'll revert guilty patch anyway.
>>>
>>
>> It's a good idea to avoid fixing a bug one-way-in-stable,
>> other-way-in-mainline. Because then we have new code in both trees
>> which is different. And the -stable guys sensibly like to see code get
>> a bit of a shakedown in mainline before backporting it.
>>
>> So it would be better to merge the "simple" patch into mainline, tagged
>> for -stable backporting. Then we can later implement the larger fix in
>> mainline, perhaps starting by reverting the "simple" fix.
>
> .....ok. I don't have to prevent your code maintainship. although I still
> think we need to fix the issue completely.
Agreed on the revert.
Acked-by: Rik van Riel <riel@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
"Li, Shaohua" <shaohua.li@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]vmscan: handle underflow for get_scan_ratio
Date: Mon, 05 Apr 2010 23:36:56 -0400 [thread overview]
Message-ID: <4BBAAC58.80108@redhat.com> (raw)
In-Reply-To: <20100402180812.646D.A69D9226@jp.fujitsu.com>
On 04/02/2010 05:13 AM, KOSAKI Motohiro wrote:
>>> Yeah, I don't want ignore .33-stable too. if I can't find the root cause
>>> in 2-3 days, I'll revert guilty patch anyway.
>>>
>>
>> It's a good idea to avoid fixing a bug one-way-in-stable,
>> other-way-in-mainline. Because then we have new code in both trees
>> which is different. And the -stable guys sensibly like to see code get
>> a bit of a shakedown in mainline before backporting it.
>>
>> So it would be better to merge the "simple" patch into mainline, tagged
>> for -stable backporting. Then we can later implement the larger fix in
>> mainline, perhaps starting by reverting the "simple" fix.
>
> .....ok. I don't have to prevent your code maintainship. although I still
> think we need to fix the issue completely.
Agreed on the revert.
Acked-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-06 3:37 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 5:53 [PATCH]vmscan: handle underflow for get_scan_ratio Shaohua Li
2010-03-30 5:53 ` Shaohua Li
2010-03-30 6:08 ` KOSAKI Motohiro
2010-03-30 6:08 ` KOSAKI Motohiro
2010-03-30 6:32 ` Shaohua Li
2010-03-30 6:40 ` KOSAKI Motohiro
2010-03-30 6:40 ` KOSAKI Motohiro
2010-03-30 6:53 ` Shaohua Li
2010-03-30 6:53 ` Shaohua Li
2010-03-30 7:31 ` KOSAKI Motohiro
2010-03-30 7:31 ` KOSAKI Motohiro
2010-03-30 8:13 ` Shaohua Li
2010-03-30 8:13 ` Shaohua Li
2010-03-31 4:53 ` Shaohua Li
2010-03-31 4:53 ` Shaohua Li
2010-03-31 5:38 ` KOSAKI Motohiro
2010-03-31 5:38 ` KOSAKI Motohiro
2010-03-31 5:51 ` Wu Fengguang
2010-03-31 5:51 ` Wu Fengguang
2010-03-31 6:00 ` KOSAKI Motohiro
2010-03-31 6:00 ` KOSAKI Motohiro
2010-03-31 6:03 ` Wu Fengguang
2010-03-31 6:03 ` Wu Fengguang
2010-04-01 22:16 ` Andrew Morton
2010-04-01 22:16 ` Andrew Morton
2010-04-02 9:13 ` KOSAKI Motohiro
2010-04-02 9:13 ` KOSAKI Motohiro
2010-04-06 1:22 ` Wu Fengguang
2010-04-06 1:22 ` Wu Fengguang
2010-04-06 3:36 ` Rik van Riel [this message]
2010-04-06 3:36 ` Rik van Riel
2010-03-31 5:53 ` KOSAKI Motohiro
2010-03-31 5:53 ` KOSAKI Motohiro
2010-04-02 6:50 ` Shaohua Li
2010-04-02 6:50 ` Shaohua Li
2010-04-02 9:14 ` KOSAKI Motohiro
2010-04-02 9:14 ` KOSAKI Motohiro
2010-04-02 9:24 ` Shaohua Li
2010-04-02 9:24 ` Shaohua Li
2010-04-04 14:19 ` KOSAKI Motohiro
2010-04-04 14:19 ` KOSAKI Motohiro
2010-04-06 1:25 ` Shaohua Li
2010-04-06 1:25 ` Shaohua Li
2010-04-06 1:36 ` KOSAKI Motohiro
2010-04-06 1:36 ` KOSAKI Motohiro
2010-04-06 1:50 ` Wu Fengguang
2010-04-06 1:50 ` Wu Fengguang
2010-04-06 2:06 ` KOSAKI Motohiro
2010-04-06 2:06 ` KOSAKI Motohiro
2010-04-06 2:30 ` Wu Fengguang
2010-04-06 2:30 ` Wu Fengguang
2010-04-06 2:58 ` KOSAKI Motohiro
2010-04-06 2:58 ` KOSAKI Motohiro
2010-04-06 3:31 ` Wu Fengguang
2010-04-06 3:31 ` Wu Fengguang
2010-04-06 3:40 ` Rik van Riel
2010-04-06 3:40 ` Rik van Riel
2010-04-06 4:49 ` Wu Fengguang
2010-04-06 4:49 ` Wu Fengguang
2010-04-06 5:09 ` Shaohua Li
2010-04-06 5:09 ` Shaohua Li
2010-04-04 0:48 ` Wu Fengguang
2010-04-04 0:48 ` Wu Fengguang
2010-04-06 1:27 ` Shaohua Li
2010-04-06 1:27 ` Shaohua Li
2010-04-06 5:03 ` Wu Fengguang
2010-04-06 5:03 ` Wu Fengguang
2010-04-06 5:36 ` Shaohua Li
2010-04-06 5:36 ` Shaohua Li
2010-04-09 6:51 ` Shaohua Li
2010-04-09 6:51 ` Shaohua Li
2010-04-09 21:20 ` Andrew Morton
2010-04-09 21:20 ` Andrew Morton
2010-04-09 21:25 ` Rik van Riel
2010-04-09 21:25 ` Rik van Riel
2010-04-13 1:30 ` KOSAKI Motohiro
2010-04-13 1:30 ` KOSAKI Motohiro
2010-04-13 2:42 ` Rik van Riel
2010-04-13 2:42 ` Rik van Riel
2010-04-13 7:55 ` KOSAKI Motohiro
2010-04-13 7:55 ` KOSAKI Motohiro
2010-04-13 8:55 ` KOSAKI Motohiro
2010-04-13 8:55 ` KOSAKI Motohiro
2010-04-14 1:27 ` Shaohua Li
2010-04-14 1:27 ` Shaohua Li
2010-04-15 3:25 ` KOSAKI Motohiro
2010-04-15 3:25 ` KOSAKI Motohiro
2010-04-12 1:57 ` Shaohua Li
2010-04-12 1:57 ` Shaohua Li
2010-03-31 5:41 ` Wu Fengguang
2010-03-31 5:41 ` Wu Fengguang
2010-03-30 10:17 ` Minchan Kim
2010-03-30 10:17 ` Minchan Kim
2010-03-30 10:25 ` KOSAKI Motohiro
2010-03-30 10:25 ` KOSAKI Motohiro
2010-03-30 11:56 ` Balbir Singh
2010-03-30 11:56 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBAAC58.80108@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.