From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows
Date: Mon, 12 Apr 2010 17:39:51 +0000 [thread overview]
Message-ID: <20100412173951.GA5614@amt.cnet> (raw)
In-Reply-To: <20100412193535.6c502695.yoshikawa.takuya@oss.ntt.co.jp>
On Mon, Apr 12, 2010 at 07:35:35PM +0900, Takuya Yoshikawa wrote:
> This patch fixes a bug found by Avi during the review process
> of my dirty bitmap related work.
>
> To ppc and ia64 people:
> The fix is really simple but touches all architectures using
> dirty bitmaps. So please check this will not suffer your part.
>
> =>
> Int is not long enough to store the size of a dirty bitmap.
>
> This patch fixes this problem with the introduction of a wrapper
> function to calculate the sizes of dirty bitmaps.
>
> Note: in mark_page_dirty(), we have to consider the fact that
> __set_bit() takes the offset as int, not long.
>
> Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: avi@redhat.com, kvm@vger.kernel.org, kvm-ia64@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows
Date: Mon, 12 Apr 2010 17:39:51 +0000 [thread overview]
Message-ID: <20100412173951.GA5614@amt.cnet> (raw)
In-Reply-To: <20100412193535.6c502695.yoshikawa.takuya@oss.ntt.co.jp>
On Mon, Apr 12, 2010 at 07:35:35PM +0900, Takuya Yoshikawa wrote:
> This patch fixes a bug found by Avi during the review process
> of my dirty bitmap related work.
>
> To ppc and ia64 people:
> The fix is really simple but touches all architectures using
> dirty bitmaps. So please check this will not suffer your part.
>
> =>
> Int is not long enough to store the size of a dirty bitmap.
>
> This patch fixes this problem with the introduction of a wrapper
> function to calculate the sizes of dirty bitmaps.
>
> Note: in mark_page_dirty(), we have to consider the fact that
> __set_bit() takes the offset as int, not long.
>
> Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: avi@redhat.com, kvm@vger.kernel.org, kvm-ia64@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows
Date: Mon, 12 Apr 2010 14:39:51 -0300 [thread overview]
Message-ID: <20100412173951.GA5614@amt.cnet> (raw)
In-Reply-To: <20100412193535.6c502695.yoshikawa.takuya@oss.ntt.co.jp>
On Mon, Apr 12, 2010 at 07:35:35PM +0900, Takuya Yoshikawa wrote:
> This patch fixes a bug found by Avi during the review process
> of my dirty bitmap related work.
>
> To ppc and ia64 people:
> The fix is really simple but touches all architectures using
> dirty bitmaps. So please check this will not suffer your part.
>
> ===
>
> Int is not long enough to store the size of a dirty bitmap.
>
> This patch fixes this problem with the introduction of a wrapper
> function to calculate the sizes of dirty bitmaps.
>
> Note: in mark_page_dirty(), we have to consider the fact that
> __set_bit() takes the offset as int, not long.
>
> Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Applied, thanks.
next prev parent reply other threads:[~2010-04-12 17:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 10:35 [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows Takuya Yoshikawa
2010-04-12 10:35 ` Takuya Yoshikawa
2010-04-12 10:35 ` Takuya Yoshikawa
2010-04-12 11:10 ` Alexander Graf
2010-04-12 11:10 ` Alexander Graf
2010-04-12 11:10 ` Alexander Graf
2010-04-12 17:39 ` Marcelo Tosatti [this message]
2010-04-12 17:39 ` Marcelo Tosatti
2010-04-12 17:39 ` Marcelo Tosatti
2010-04-13 0:52 ` Takuya Yoshikawa
2010-04-13 0:52 ` Takuya Yoshikawa
2010-04-13 0:52 ` Takuya Yoshikawa
2010-04-13 6:50 ` Avi Kivity
2010-04-13 6:50 ` Avi Kivity
2010-04-13 6:50 ` Avi Kivity
2010-04-13 7:03 ` Takuya Yoshikawa
2010-04-13 7:03 ` Takuya Yoshikawa
2010-04-13 7:03 ` Takuya Yoshikawa
2010-04-13 7:05 ` Avi Kivity
2010-04-13 7:05 ` Avi Kivity
2010-04-13 7:05 ` Avi Kivity
2010-04-13 13:47 ` [PATCH] KVM: cleanup: limit the number of pages per memory slot Takuya Yoshikawa
2010-04-14 16:58 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412173951.GA5614@amt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.