From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows
Date: Tue, 13 Apr 2010 07:05:38 +0000 [thread overview]
Message-ID: <4BC417C2.9030905@redhat.com> (raw)
In-Reply-To: <20100412193535.6c502695.yoshikawa.takuya@oss.ntt.co.jp>
On 04/13/2010 10:03 AM, Takuya Yoshikawa wrote:
>> It's better to limit memory slots to something that can be handled by
>> everything, then. 2^31 pages is plenty. Return -EINVAL if the slot is
>> too large.
>
>
> I agree with that, so we make this patch pending to fix like that?
> -- or should make a new patch based on this patch?
We need a new patch to block oversize memory slots. The current patch
can come on top (but now page numbers fit inside an int, so it is just a
cleanup, not a bugfix).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, kvm-ia64@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows
Date: Tue, 13 Apr 2010 07:05:38 +0000 [thread overview]
Message-ID: <4BC417C2.9030905@redhat.com> (raw)
In-Reply-To: <4BC41758.4000008@oss.ntt.co.jp>
On 04/13/2010 10:03 AM, Takuya Yoshikawa wrote:
>> It's better to limit memory slots to something that can be handled by
>> everything, then. 2^31 pages is plenty. Return -EINVAL if the slot is
>> too large.
>
>
> I agree with that, so we make this patch pending to fix like that?
> -- or should make a new patch based on this patch?
We need a new patch to block oversize memory slots. The current patch
can come on top (but now page numbers fit inside an int, so it is just a
cleanup, not a bugfix).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, kvm-ia64@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows
Date: Tue, 13 Apr 2010 10:05:38 +0300 [thread overview]
Message-ID: <4BC417C2.9030905@redhat.com> (raw)
In-Reply-To: <4BC41758.4000008@oss.ntt.co.jp>
On 04/13/2010 10:03 AM, Takuya Yoshikawa wrote:
>> It's better to limit memory slots to something that can be handled by
>> everything, then. 2^31 pages is plenty. Return -EINVAL if the slot is
>> too large.
>
>
> I agree with that, so we make this patch pending to fix like that?
> -- or should make a new patch based on this patch?
We need a new patch to block oversize memory slots. The current patch
can come on top (but now page numbers fit inside an int, so it is just a
cleanup, not a bugfix).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-04-13 7:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 10:35 [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows Takuya Yoshikawa
2010-04-12 10:35 ` Takuya Yoshikawa
2010-04-12 10:35 ` Takuya Yoshikawa
2010-04-12 11:10 ` Alexander Graf
2010-04-12 11:10 ` Alexander Graf
2010-04-12 11:10 ` Alexander Graf
2010-04-12 17:39 ` Marcelo Tosatti
2010-04-12 17:39 ` Marcelo Tosatti
2010-04-12 17:39 ` Marcelo Tosatti
2010-04-13 0:52 ` Takuya Yoshikawa
2010-04-13 0:52 ` Takuya Yoshikawa
2010-04-13 0:52 ` Takuya Yoshikawa
2010-04-13 6:50 ` Avi Kivity
2010-04-13 6:50 ` Avi Kivity
2010-04-13 6:50 ` Avi Kivity
2010-04-13 7:03 ` Takuya Yoshikawa
2010-04-13 7:03 ` Takuya Yoshikawa
2010-04-13 7:03 ` Takuya Yoshikawa
2010-04-13 7:05 ` Avi Kivity [this message]
2010-04-13 7:05 ` Avi Kivity
2010-04-13 7:05 ` Avi Kivity
2010-04-13 13:47 ` [PATCH] KVM: cleanup: limit the number of pages per memory slot Takuya Yoshikawa
2010-04-14 16:58 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC417C2.9030905@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.