From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"David S. Miller" <davem@davemloft.net>,
Andrei Emeltchenko <andrei.emeltchenko@nokia.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] bluetooth: handle l2cap_create_connless_pdu() errors
Date: Thu, 22 Apr 2010 12:33:47 +0000 [thread overview]
Message-ID: <20100422123347.GA5265@vigoh> (raw)
In-Reply-To: <20100422095201.GO29647@bicker>
Hi Dan,
* Dan Carpenter <error27@gmail.com> [2010-04-22 11:52:01 +0200]:
> l2cap_create_connless_pdu() can sometimes return ERR_PTR(-ENOMEM) or
> ERR_PTR(-EFAULT).
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index 99d68c3..9753b69 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -1626,7 +1626,10 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms
> /* Connectionless channel */
> if (sk->sk_type = SOCK_DGRAM) {
> skb = l2cap_create_connless_pdu(sk, msg, len);
> - err = l2cap_do_send(sk, skb);
> + if (IS_ERR(skb))
> + err = PTR_ERR(skb);
> + else
> + err = l2cap_do_send(sk, skb);
> goto done;
> }
Your fix looks ok, but we have changed l2cap_do_send() to void, so you
have to modify your patch.
That change is not in the bluetooth-testingtree yet, so remote add my git
tree and use the branch ertm.
git://git.profusion.mobi/users/padovan/bluetooth-testing.git
Regards,
--
Gustavo F. Padovan
http://padovan.org
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"David S. Miller" <davem@davemloft.net>,
Andrei Emeltchenko <andrei.emeltchenko@nokia.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] bluetooth: handle l2cap_create_connless_pdu() errors
Date: Thu, 22 Apr 2010 09:33:47 -0300 [thread overview]
Message-ID: <20100422123347.GA5265@vigoh> (raw)
In-Reply-To: <20100422095201.GO29647@bicker>
Hi Dan,
* Dan Carpenter <error27@gmail.com> [2010-04-22 11:52:01 +0200]:
> l2cap_create_connless_pdu() can sometimes return ERR_PTR(-ENOMEM) or
> ERR_PTR(-EFAULT).
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index 99d68c3..9753b69 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -1626,7 +1626,10 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms
> /* Connectionless channel */
> if (sk->sk_type == SOCK_DGRAM) {
> skb = l2cap_create_connless_pdu(sk, msg, len);
> - err = l2cap_do_send(sk, skb);
> + if (IS_ERR(skb))
> + err = PTR_ERR(skb);
> + else
> + err = l2cap_do_send(sk, skb);
> goto done;
> }
Your fix looks ok, but we have changed l2cap_do_send() to void, so you
have to modify your patch.
That change is not in the bluetooth-testingtree yet, so remote add my git
tree and use the branch ertm.
git://git.profusion.mobi/users/padovan/bluetooth-testing.git
Regards,
--
Gustavo F. Padovan
http://padovan.org
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo F. Padovan" <gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org>
To: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Andrei Emeltchenko
<andrei.emeltchenko-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] bluetooth: handle l2cap_create_connless_pdu() errors
Date: Thu, 22 Apr 2010 09:33:47 -0300 [thread overview]
Message-ID: <20100422123347.GA5265@vigoh> (raw)
In-Reply-To: <20100422095201.GO29647@bicker>
Hi Dan,
* Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [2010-04-22 11:52:01 +0200]:
> l2cap_create_connless_pdu() can sometimes return ERR_PTR(-ENOMEM) or
> ERR_PTR(-EFAULT).
>
> Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index 99d68c3..9753b69 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -1626,7 +1626,10 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms
> /* Connectionless channel */
> if (sk->sk_type == SOCK_DGRAM) {
> skb = l2cap_create_connless_pdu(sk, msg, len);
> - err = l2cap_do_send(sk, skb);
> + if (IS_ERR(skb))
> + err = PTR_ERR(skb);
> + else
> + err = l2cap_do_send(sk, skb);
> goto done;
> }
Your fix looks ok, but we have changed l2cap_do_send() to void, so you
have to modify your patch.
That change is not in the bluetooth-testingtree yet, so remote add my git
tree and use the branch ertm.
git://git.profusion.mobi/users/padovan/bluetooth-testing.git
Regards,
--
Gustavo F. Padovan
http://padovan.org
next prev parent reply other threads:[~2010-04-22 12:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:52 [patch] bluetooth: handle l2cap_create_connless_pdu() errors Dan Carpenter
2010-04-22 9:52 ` Dan Carpenter
2010-04-22 9:52 ` Dan Carpenter
2010-04-22 12:33 ` Gustavo F. Padovan [this message]
2010-04-22 12:33 ` Gustavo F. Padovan
2010-04-22 12:33 ` Gustavo F. Padovan
2010-04-26 11:36 ` [patch v2] " Dan Carpenter
2010-04-26 11:36 ` Dan Carpenter
2010-04-26 15:09 ` Gustavo F. Padovan
2010-04-26 15:09 ` Gustavo F. Padovan
2010-04-26 18:12 ` David Miller
2010-04-26 18:12 ` David Miller
2010-04-26 18:27 ` Gustavo F. Padovan
2010-04-26 18:27 ` Gustavo F. Padovan
2010-04-26 18:27 ` Gustavo F. Padovan
2010-04-27 2:05 ` Marcel Holtmann
2010-04-27 2:05 ` Marcel Holtmann
2010-04-27 2:05 ` Marcel Holtmann
2010-04-28 0:03 ` David Miller
2010-04-28 0:03 ` David Miller
2010-04-28 0:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422123347.GA5265@vigoh \
--to=gustavo@padovan.org \
--cc=andrei.emeltchenko@nokia.com \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.