From: Andrea Arcangeli <aarcange@redhat.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/2] Fix migration races in rmap_walk()
Date: Tue, 27 Apr 2010 01:04:12 +0200 [thread overview]
Message-ID: <20100426230412.GL8860@random.random> (raw)
In-Reply-To: <1272321478-28481-1-git-send-email-mel@csn.ul.ie>
On Mon, Apr 26, 2010 at 11:37:56PM +0100, Mel Gorman wrote:
> The other issues raised about expand_downwards will need to be re-examined to
> see if they still exist and transparent hugepage support will need further
> thinking to see if split_huge_page() can deal with these situations.
So patch 1 is for aa.git too, and patch 2 is only for mainline with
the new anon-vma changes (patch 2 not needed in current aa.git, and if
I apply it, it'll deadlock so...) right?
split_huge_page is somewhat simpler and more strict in its checking
than migrate.c in this respect, and yes patch 2 will also need to be
extended to cover split_huge_page the moment I stop backing out the
new anon-vma code (but it won't be any different, whatever works for
migrate will also work for split_huge_page later).
For now I'm much more interested in patch 1 and I'll leave patch 2 to
mainline digestion and check it later hope to find all issues fixed by
the time transparent hugepage gets merged.
About patch 1 it's very interesting because I looked at the race
against fork and migrate yesterday and I didn't see issues but I'm
going to read your patch 1 in detail now to understand what is the
problem you're fixing.
Good you posted this fast, so I can try to help ;)
Andrea
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/2] Fix migration races in rmap_walk()
Date: Tue, 27 Apr 2010 01:04:12 +0200 [thread overview]
Message-ID: <20100426230412.GL8860@random.random> (raw)
In-Reply-To: <1272321478-28481-1-git-send-email-mel@csn.ul.ie>
On Mon, Apr 26, 2010 at 11:37:56PM +0100, Mel Gorman wrote:
> The other issues raised about expand_downwards will need to be re-examined to
> see if they still exist and transparent hugepage support will need further
> thinking to see if split_huge_page() can deal with these situations.
So patch 1 is for aa.git too, and patch 2 is only for mainline with
the new anon-vma changes (patch 2 not needed in current aa.git, and if
I apply it, it'll deadlock so...) right?
split_huge_page is somewhat simpler and more strict in its checking
than migrate.c in this respect, and yes patch 2 will also need to be
extended to cover split_huge_page the moment I stop backing out the
new anon-vma code (but it won't be any different, whatever works for
migrate will also work for split_huge_page later).
For now I'm much more interested in patch 1 and I'll leave patch 2 to
mainline digestion and check it later hope to find all issues fixed by
the time transparent hugepage gets merged.
About patch 1 it's very interesting because I looked at the race
against fork and migrate yesterday and I didn't see issues but I'm
going to read your patch 1 in detail now to understand what is the
problem you're fixing.
Good you posted this fast, so I can try to help ;)
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-26 23:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 22:37 [PATCH 0/2] Fix migration races in rmap_walk() Mel Gorman
2010-04-26 22:37 ` Mel Gorman
2010-04-26 22:37 ` [PATCH 1/2] mm,migration: During fork(), wait for migration to end if migration PTE is encountered Mel Gorman
2010-04-26 22:37 ` Mel Gorman
2010-04-26 23:28 ` Minchan Kim
2010-04-26 23:28 ` Minchan Kim
2010-04-27 0:08 ` Rik van Riel
2010-04-27 0:08 ` Rik van Riel
2010-04-26 22:37 ` [PATCH 2/2] mm,migration: Prevent rmap_walk_[anon|ksm] seeing the wrong VMA information Mel Gorman
2010-04-26 22:37 ` Mel Gorman
2010-04-26 23:05 ` Minchan Kim
2010-04-26 23:05 ` Minchan Kim
2010-04-27 0:30 ` KAMEZAWA Hiroyuki
2010-04-27 0:30 ` KAMEZAWA Hiroyuki
2010-04-27 9:17 ` Mel Gorman
2010-04-27 9:17 ` Mel Gorman
2010-04-26 23:15 ` Minchan Kim
2010-04-26 23:15 ` Minchan Kim
2010-04-27 0:07 ` KAMEZAWA Hiroyuki
2010-04-27 0:07 ` KAMEZAWA Hiroyuki
2010-04-27 3:50 ` KAMEZAWA Hiroyuki
2010-04-27 3:50 ` KAMEZAWA Hiroyuki
2010-04-27 4:03 ` KAMEZAWA Hiroyuki
2010-04-27 4:03 ` KAMEZAWA Hiroyuki
2010-04-27 8:59 ` Mel Gorman
2010-04-27 8:59 ` Mel Gorman
2010-04-27 9:09 ` KAMEZAWA Hiroyuki
2010-04-27 9:09 ` KAMEZAWA Hiroyuki
2010-04-27 10:29 ` Mel Gorman
2010-04-27 10:29 ` Mel Gorman
2010-04-27 15:37 ` Andrea Arcangeli
2010-04-27 15:37 ` Andrea Arcangeli
2010-04-27 16:35 ` Mel Gorman
2010-04-27 16:35 ` Mel Gorman
2010-04-27 0:30 ` Rik van Riel
2010-04-27 0:30 ` Rik van Riel
2010-04-27 0:31 ` KAMEZAWA Hiroyuki
2010-04-27 0:31 ` KAMEZAWA Hiroyuki
2010-04-27 2:13 ` Rik van Riel
2010-04-27 2:13 ` Rik van Riel
2010-04-26 23:04 ` Andrea Arcangeli [this message]
2010-04-26 23:04 ` [PATCH 0/2] Fix migration races in rmap_walk() Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426230412.GL8860@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.