From: Andrea Arcangeli <aarcange@redhat.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] mm,migration: Prevent rmap_walk_[anon|ksm] seeing the wrong VMA information
Date: Tue, 27 Apr 2010 17:37:59 +0200 [thread overview]
Message-ID: <20100427153759.GZ8860@random.random> (raw)
In-Reply-To: <20100427102905.GE4895@csn.ul.ie>
On Tue, Apr 27, 2010 at 11:29:05AM +0100, Mel Gorman wrote:
> It could have been in both but the vma lock should have been held across
> the rmap_one. It still reproduces but it's still the right thing to do.
> This is the current version of patch 2/2.
Well, keep in mind I reproduced the swapops bug with 2.6.33 anon-vma
code, it's unlikely that focusing on patch 2 you'll fix bug in
swapops.h. If this is a bug in the new anon-vma code, it needs fixing
of course! But I doubt this bug is related to swapops in execve on the
bprm->p args.
I've yet to check in detail patch 1 sorry, I'll let you know my
opinion about it as soon as I checked it in detail.
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] mm,migration: Prevent rmap_walk_[anon|ksm] seeing the wrong VMA information
Date: Tue, 27 Apr 2010 17:37:59 +0200 [thread overview]
Message-ID: <20100427153759.GZ8860@random.random> (raw)
In-Reply-To: <20100427102905.GE4895@csn.ul.ie>
On Tue, Apr 27, 2010 at 11:29:05AM +0100, Mel Gorman wrote:
> It could have been in both but the vma lock should have been held across
> the rmap_one. It still reproduces but it's still the right thing to do.
> This is the current version of patch 2/2.
Well, keep in mind I reproduced the swapops bug with 2.6.33 anon-vma
code, it's unlikely that focusing on patch 2 you'll fix bug in
swapops.h. If this is a bug in the new anon-vma code, it needs fixing
of course! But I doubt this bug is related to swapops in execve on the
bprm->p args.
I've yet to check in detail patch 1 sorry, I'll let you know my
opinion about it as soon as I checked it in detail.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-27 15:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 22:37 [PATCH 0/2] Fix migration races in rmap_walk() Mel Gorman
2010-04-26 22:37 ` Mel Gorman
2010-04-26 22:37 ` [PATCH 1/2] mm,migration: During fork(), wait for migration to end if migration PTE is encountered Mel Gorman
2010-04-26 22:37 ` Mel Gorman
2010-04-26 23:28 ` Minchan Kim
2010-04-26 23:28 ` Minchan Kim
2010-04-27 0:08 ` Rik van Riel
2010-04-27 0:08 ` Rik van Riel
2010-04-26 22:37 ` [PATCH 2/2] mm,migration: Prevent rmap_walk_[anon|ksm] seeing the wrong VMA information Mel Gorman
2010-04-26 22:37 ` Mel Gorman
2010-04-26 23:05 ` Minchan Kim
2010-04-26 23:05 ` Minchan Kim
2010-04-27 0:30 ` KAMEZAWA Hiroyuki
2010-04-27 0:30 ` KAMEZAWA Hiroyuki
2010-04-27 9:17 ` Mel Gorman
2010-04-27 9:17 ` Mel Gorman
2010-04-26 23:15 ` Minchan Kim
2010-04-26 23:15 ` Minchan Kim
2010-04-27 0:07 ` KAMEZAWA Hiroyuki
2010-04-27 0:07 ` KAMEZAWA Hiroyuki
2010-04-27 3:50 ` KAMEZAWA Hiroyuki
2010-04-27 3:50 ` KAMEZAWA Hiroyuki
2010-04-27 4:03 ` KAMEZAWA Hiroyuki
2010-04-27 4:03 ` KAMEZAWA Hiroyuki
2010-04-27 8:59 ` Mel Gorman
2010-04-27 8:59 ` Mel Gorman
2010-04-27 9:09 ` KAMEZAWA Hiroyuki
2010-04-27 9:09 ` KAMEZAWA Hiroyuki
2010-04-27 10:29 ` Mel Gorman
2010-04-27 10:29 ` Mel Gorman
2010-04-27 15:37 ` Andrea Arcangeli [this message]
2010-04-27 15:37 ` Andrea Arcangeli
2010-04-27 16:35 ` Mel Gorman
2010-04-27 16:35 ` Mel Gorman
2010-04-27 0:30 ` Rik van Riel
2010-04-27 0:30 ` Rik van Riel
2010-04-27 0:31 ` KAMEZAWA Hiroyuki
2010-04-27 0:31 ` KAMEZAWA Hiroyuki
2010-04-27 2:13 ` Rik van Riel
2010-04-27 2:13 ` Rik van Riel
2010-04-26 23:04 ` [PATCH 0/2] Fix migration races in rmap_walk() Andrea Arcangeli
2010-04-26 23:04 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427153759.GZ8860@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.