From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: fubar@us.ibm.com, nhorman@tuxdriver.com, netdev@vger.kernel.org,
mpm@selenic.com, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, jmoyer@redhat.com,
gospo@redhat.com, bonding-devel@lists.sourceforge.net
Subject: Re: [Bridge] [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices
Date: Tue, 27 Apr 2010 15:22:36 -0700 (PDT) [thread overview]
Message-ID: <20100427.152236.73676344.davem@davemloft.net> (raw)
In-Reply-To: <20100427075937.4908.18468.sendpatchset@localhost.localdomain>
From: Amerigo Wang <amwang@redhat.com>
Date: Tue, 27 Apr 2010 03:55:41 -0400
> + if (ndev->priv_flags & IFF_DISABLE_NETPOLL
> + || !ndev->netdev_ops->ndo_poll_controller) {
" ||" goes on first line, not second, and second line needs to be indented
properly so that "!ndev->..." matches up with "ndev->priv_flags ..." on
the previous line.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: linux-kernel@vger.kernel.org, mpm@selenic.com,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
gospo@redhat.com, nhorman@tuxdriver.com, jmoyer@redhat.com,
shemminger@linux-foundation.org,
bonding-devel@lists.sourceforge.net, fubar@us.ibm.com
Subject: Re: [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices
Date: Tue, 27 Apr 2010 15:22:36 -0700 (PDT) [thread overview]
Message-ID: <20100427.152236.73676344.davem@davemloft.net> (raw)
In-Reply-To: <20100427075937.4908.18468.sendpatchset@localhost.localdomain>
From: Amerigo Wang <amwang@redhat.com>
Date: Tue, 27 Apr 2010 03:55:41 -0400
> + if (ndev->priv_flags & IFF_DISABLE_NETPOLL
> + || !ndev->netdev_ops->ndo_poll_controller) {
" ||" goes on first line, not second, and second line needs to be indented
properly so that "!ndev->..." matches up with "ndev->priv_flags ..." on
the previous line.
next prev parent reply other threads:[~2010-04-27 22:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 7:55 [Bridge] [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices Amerigo Wang
2010-04-27 7:55 ` Amerigo Wang
2010-04-27 7:55 ` [Bridge] [v4 Patch 2/3] bridge: make bridge support netpoll Amerigo Wang
2010-04-27 7:55 ` Amerigo Wang
2010-04-27 22:23 ` [Bridge] " David Miller
2010-04-27 22:23 ` David Miller
2010-04-27 7:56 ` [Bridge] [v4 Patch 3/3] bonding: make bonding " Amerigo Wang
2010-04-27 7:56 ` Amerigo Wang
2010-04-27 22:24 ` [Bridge] " David Miller
2010-04-27 22:24 ` David Miller
2010-04-28 2:08 ` [Bridge] " Cong Wang
2010-04-28 2:08 ` Cong Wang
2010-04-27 22:22 ` David Miller [this message]
2010-04-27 22:22 ` [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices David Miller
2010-04-28 4:02 ` [Bridge] " Dongdong Deng
2010-04-28 4:02 ` Dongdong Deng
2010-04-28 4:02 ` Dongdong Deng
2010-04-28 9:59 ` [Bridge] " Cong Wang
2010-04-28 9:59 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427.152236.73676344.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=bridge@lists.linux-foundation.org \
--cc=fubar@us.ibm.com \
--cc=gospo@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.