From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: fubar@us.ibm.com, nhorman@tuxdriver.com, netdev@vger.kernel.org,
mpm@selenic.com, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, jmoyer@redhat.com,
gospo@redhat.com, bonding-devel@lists.sourceforge.net
Subject: Re: [Bridge] [v4 Patch 3/3] bonding: make bonding support netpoll
Date: Wed, 28 Apr 2010 10:08:57 +0800 [thread overview]
Message-ID: <4BD798B9.3010007@redhat.com> (raw)
In-Reply-To: <20100427.152424.236240666.davem@davemloft.net>
David Miller wrote:
> From: Amerigo Wang <amwang@redhat.com>
> Date: Tue, 27 Apr 2010 03:56:09 -0400
>
>> + if ((slave->dev->priv_flags & IFF_DISABLE_NETPOLL)
>> + || !slave->dev->netdev_ops->ndo_poll_controller)
>
> "|| on first line please, plus fix second line's indentation as per
> comments given in patch #1 and #2
Thanks, David!
I will fix all of this style problem.
WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, mpm@selenic.com,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
gospo@redhat.com, nhorman@tuxdriver.com, jmoyer@redhat.com,
shemminger@linux-foundation.org,
bonding-devel@lists.sourceforge.net, fubar@us.ibm.com
Subject: Re: [v4 Patch 3/3] bonding: make bonding support netpoll
Date: Wed, 28 Apr 2010 10:08:57 +0800 [thread overview]
Message-ID: <4BD798B9.3010007@redhat.com> (raw)
In-Reply-To: <20100427.152424.236240666.davem@davemloft.net>
David Miller wrote:
> From: Amerigo Wang <amwang@redhat.com>
> Date: Tue, 27 Apr 2010 03:56:09 -0400
>
>> + if ((slave->dev->priv_flags & IFF_DISABLE_NETPOLL)
>> + || !slave->dev->netdev_ops->ndo_poll_controller)
>
> "|| on first line please, plus fix second line's indentation as per
> comments given in patch #1 and #2
Thanks, David!
I will fix all of this style problem.
next prev parent reply other threads:[~2010-04-28 2:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 7:55 [Bridge] [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices Amerigo Wang
2010-04-27 7:55 ` Amerigo Wang
2010-04-27 7:55 ` [Bridge] [v4 Patch 2/3] bridge: make bridge support netpoll Amerigo Wang
2010-04-27 7:55 ` Amerigo Wang
2010-04-27 22:23 ` [Bridge] " David Miller
2010-04-27 22:23 ` David Miller
2010-04-27 7:56 ` [Bridge] [v4 Patch 3/3] bonding: make bonding " Amerigo Wang
2010-04-27 7:56 ` Amerigo Wang
2010-04-27 22:24 ` [Bridge] " David Miller
2010-04-27 22:24 ` David Miller
2010-04-28 2:08 ` Cong Wang [this message]
2010-04-28 2:08 ` Cong Wang
2010-04-27 22:22 ` [Bridge] [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices David Miller
2010-04-27 22:22 ` David Miller
2010-04-28 4:02 ` [Bridge] " Dongdong Deng
2010-04-28 4:02 ` Dongdong Deng
2010-04-28 4:02 ` Dongdong Deng
2010-04-28 9:59 ` [Bridge] " Cong Wang
2010-04-28 9:59 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD798B9.3010007@redhat.com \
--to=amwang@redhat.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=gospo@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.