* [PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro
@ 2010-04-29 9:58 Arnaud Patard
2010-04-29 16:39 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Arnaud Patard @ 2010-04-29 9:58 UTC (permalink / raw)
To: linux-mips
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
There's a typo in the LOONGSON_ADDRWIN_CFG macro. The cpu window mmap
register address should contain the destination parameters not the
source one (this has not been noticed because the code is only using
source=destination)
Signed-off-by: Arnaud Patard <apatard@mandriva.com>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix_addrwin_cfg_macro.patch --]
[-- Type: text/x-patch, Size: 573 bytes --]
Index: linux-2.6/arch/mips/include/asm/mach-loongson/loongson.h
===================================================================
--- linux-2.6.orig/arch/mips/include/asm/mach-loongson/loongson.h
+++ linux-2.6/arch/mips/include/asm/mach-loongson/loongson.h
@@ -307,7 +307,7 @@ extern unsigned long _loongson_addrwincf
*/
#define LOONGSON_ADDRWIN_CFG(s, d, w, src, dst, size) do {\
s##_WIN##w##_BASE = (src); \
- s##_WIN##w##_MMAP = (src) | ADDRWIN_MAP_DST_##d; \
+ s##_WIN##w##_MMAP = (dst) | ADDRWIN_MAP_DST_##d; \
s##_WIN##w##_MASK = ~(size-1); \
} while (0)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro
2010-04-29 9:58 [PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro Arnaud Patard
@ 2010-04-29 16:39 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2010-04-29 16:39 UTC (permalink / raw)
To: Arnaud Patard; +Cc: linux-mips
On Thu, Apr 29, 2010 at 11:58:51AM +0200, Arnaud Patard wrote:
> There's a typo in the LOONGSON_ADDRWIN_CFG macro. The cpu window mmap
> register address should contain the destination parameters not the
> source one (this has not been noticed because the code is only using
> source=destination)
>
> Signed-off-by: Arnaud Patard <apatard@mandriva.com>
Thanks, applied as well.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-29 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-29 9:58 [PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro Arnaud Patard
2010-04-29 16:39 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.