[PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro

[PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro

[Arnaud Patard]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]


There's a typo in the LOONGSON_ADDRWIN_CFG macro. The cpu window mmap
register address should contain the destination parameters not the
source one (this has not been noticed because the code is only using
source=destination)

Signed-off-by: Arnaud Patard <apatard@mandriva.com>
---

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix_addrwin_cfg_macro.patch --]
[-- Type: text/x-patch, Size: 573 bytes --]

Index: linux-2.6/arch/mips/include/asm/mach-loongson/loongson.h
===================================================================
--- linux-2.6.orig/arch/mips/include/asm/mach-loongson/loongson.h
+++ linux-2.6/arch/mips/include/asm/mach-loongson/loongson.h
@@ -307,7 +307,7 @@ extern unsigned long _loongson_addrwincf
  */
 #define LOONGSON_ADDRWIN_CFG(s, d, w, src, dst, size) do {\
 	s##_WIN##w##_BASE = (src); \
-	s##_WIN##w##_MMAP = (src) | ADDRWIN_MAP_DST_##d; \
+	s##_WIN##w##_MMAP = (dst) | ADDRWIN_MAP_DST_##d; \
 	s##_WIN##w##_MASK = ~(size-1); \
 } while (0)
 

Re: [PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro

[Ralf Baechle]

On Thu, Apr 29, 2010 at 11:58:51AM +0200, Arnaud Patard wrote:

> There's a typo in the LOONGSON_ADDRWIN_CFG macro. The cpu window mmap
> register address should contain the destination parameters not the
> source one (this has not been noticed because the code is only using
> source=destination)
> 
> Signed-off-by: Arnaud Patard <apatard@mandriva.com>

Thanks, applied as well.

  Ralf