From: "rain_maker@root-forum.org" <rain_maker@root-forum.org>
To: linux-wireless@vger.kernel.org
Cc: Ivo van Doorn <ivdoorn@gmail.com>
Subject: [PATCH] rt2x00: remove USB-ID 148f:2573 from rt2500usb driver
Date: Mon, 3 May 2010 16:24:45 +0200 [thread overview]
Message-ID: <201005031624.45409.rain_maker@root-forum.org> (raw)
The drivers rt2500usb and rt73usb both contain the usb id 148f:2573 while only
the latter is suitable for devices with that id.
As a consequence, both drivers will be loaded and system log shows messages
like "rt2500usb_init_eeprom: Error - Invalid RT chipset detected".
If you use the above search term, you will find more than 1500 hits with a
well known search engine, confirming that rt2500usb is always the wrong
driver for devices with usb id 148f:2573 and quite often as a side effect
confusion arose about this -non fatal but misleading- error message in the
respective bug reports or threads.
This trivial patch removes the id 148f:2573 from rt2500usb driver.
Signed-off-by: Axel Koellhofer <rain_maker@root-forum.org>
---
diff -Naur a/drivers/net/wireless/rt2x00/rt2500usb.c
b/drivers/net/wireless/rt2x00/rt2500usb.c
--- a/drivers/net/wireless/rt2x00/rt2500usb.c 2010-05-03 16:03:29.572101896
+0200
+++ b/drivers/net/wireless/rt2x00/rt2500usb.c 2010-05-03 16:03:51.902854565
+0200
@@ -1879,7 +1879,6 @@
/* Ralink */
{ USB_DEVICE(0x148f, 0x1706), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x148f, 0x2570), USB_DEVICE_DATA(&rt2500usb_ops) },
- { USB_DEVICE(0x148f, 0x2573), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x148f, 0x9020), USB_DEVICE_DATA(&rt2500usb_ops) },
/* Sagem */
{ USB_DEVICE(0x079b, 0x004b), USB_DEVICE_DATA(&rt2500usb_ops) },
next reply other threads:[~2010-05-03 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 14:24 rain_maker [this message]
2010-05-03 14:58 ` [PATCH] rt2x00: remove USB-ID 148f:2573 from rt2500usb driver John W. Linville
2010-05-03 15:20 ` rain_maker
2010-05-03 15:47 ` John W. Linville
2010-05-03 16:53 ` rain_maker
2010-05-03 15:13 ` Ivo Van Doorn
2010-05-03 15:29 ` Johannes Berg
2010-05-03 15:30 ` Ivo Van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005031624.45409.rain_maker@root-forum.org \
--to=rain_maker@root-forum.org \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.