All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org, qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch uq/master 5/9] kvm: synchronize state from cpu context
Date: Tue, 04 May 2010 09:45:23 -0300	[thread overview]
Message-ID: <20100504124634.399797233@redhat.com> (raw)
In-Reply-To: 20100504124518.979470863@redhat.com

[-- Attachment #1: cpu-sync-state-use-run-on-cpu --]
[-- Type: text/plain, Size: 982 bytes --]

From: Jan Kiszka <jan.kiszka@siemens.com>

It is not safe to retrieve the KVM internal state of a given cpu
while its potentially modifying it.

Queue the request to run on cpu context, similarly to qemu-kvm.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: qemu/kvm-all.c
===================================================================
--- qemu.orig/kvm-all.c
+++ qemu/kvm-all.c
@@ -796,14 +796,22 @@ void kvm_flush_coalesced_mmio_buffer(voi
 #endif
 }
 
-void kvm_cpu_synchronize_state(CPUState *env)
+static void do_kvm_cpu_synchronize_state(void *_env)
 {
+    CPUState *env = _env;
+
     if (!env->kvm_vcpu_dirty) {
         kvm_arch_get_registers(env);
         env->kvm_vcpu_dirty = 1;
     }
 }
 
+void kvm_cpu_synchronize_state(CPUState *env)
+{
+    if (!env->kvm_vcpu_dirty)
+        run_on_cpu(env, do_kvm_cpu_synchronize_state, env);
+}
+
 void kvm_cpu_synchronize_post_reset(CPUState *env)
 {
     kvm_arch_put_registers(env, KVM_PUT_RESET_STATE);



WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org, qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Subject: [Qemu-devel] [patch uq/master 5/9] kvm: synchronize state from cpu context
Date: Tue, 04 May 2010 09:45:23 -0300	[thread overview]
Message-ID: <20100504124634.399797233@redhat.com> (raw)
In-Reply-To: 20100504124518.979470863@redhat.com

[-- Attachment #1: cpu-sync-state-use-run-on-cpu --]
[-- Type: text/plain, Size: 980 bytes --]

From: Jan Kiszka <jan.kiszka@siemens.com>

It is not safe to retrieve the KVM internal state of a given cpu
while its potentially modifying it.

Queue the request to run on cpu context, similarly to qemu-kvm.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: qemu/kvm-all.c
===================================================================
--- qemu.orig/kvm-all.c
+++ qemu/kvm-all.c
@@ -796,14 +796,22 @@ void kvm_flush_coalesced_mmio_buffer(voi
 #endif
 }
 
-void kvm_cpu_synchronize_state(CPUState *env)
+static void do_kvm_cpu_synchronize_state(void *_env)
 {
+    CPUState *env = _env;
+
     if (!env->kvm_vcpu_dirty) {
         kvm_arch_get_registers(env);
         env->kvm_vcpu_dirty = 1;
     }
 }
 
+void kvm_cpu_synchronize_state(CPUState *env)
+{
+    if (!env->kvm_vcpu_dirty)
+        run_on_cpu(env, do_kvm_cpu_synchronize_state, env);
+}
+
 void kvm_cpu_synchronize_post_reset(CPUState *env)
 {
     kvm_arch_put_registers(env, KVM_PUT_RESET_STATE);

  parent reply	other threads:[~2010-05-04 13:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 12:45 [patch uq/master 0/9] enable smp > 1 and related fixes Marcelo Tosatti
2010-05-04 12:45 ` [Qemu-devel] " Marcelo Tosatti
2010-05-04 12:45 ` [patch uq/master 1/9] kvm: set cpu_single_env around KVM_RUN ioctl Marcelo Tosatti
2010-05-04 12:45   ` [Qemu-devel] " Marcelo Tosatti
2010-05-04 12:45 ` [patch uq/master 2/9] make SIG_IPI to tcg vcpu thread reliable Marcelo Tosatti
2010-05-04 12:45   ` [Qemu-devel] " Marcelo Tosatti
2010-05-04 12:45 ` [patch uq/master 3/9] standardize on qemu_cpu_kick for signalling cpu thread(s) Marcelo Tosatti
2010-05-04 12:45   ` [Qemu-devel] " Marcelo Tosatti
2010-05-04 12:45 ` [patch uq/master 4/9] port qemu-kvm's on_vcpu code Marcelo Tosatti
2010-05-04 12:45   ` [Qemu-devel] " Marcelo Tosatti
2010-05-04 12:45 ` Marcelo Tosatti [this message]
2010-05-04 12:45   ` [Qemu-devel] [patch uq/master 5/9] kvm: synchronize state from cpu context Marcelo Tosatti
2010-05-06 11:31   ` Avi Kivity
2010-05-06 11:31     ` [Qemu-devel] " Avi Kivity
2010-05-04 12:45 ` [patch uq/master 6/9] add cpu_is_stopped helper Marcelo Tosatti
2010-05-04 12:45   ` [Qemu-devel] " Marcelo Tosatti
2010-05-04 12:45 ` [patch uq/master 7/9] move stop/stopped CPU_COMMON fields after area zeroed by reset Marcelo Tosatti
2010-05-04 12:45   ` [Qemu-devel] " Marcelo Tosatti
2010-05-04 12:45 ` [patch uq/master 8/9] kvm: validate context for kvm cpu get/put operations Marcelo Tosatti
2010-05-04 12:45   ` [Qemu-devel] " Marcelo Tosatti
2010-05-04 12:45 ` [patch uq/master 9/9] kvm: enable smp > 1 Marcelo Tosatti
2010-05-04 12:45   ` [Qemu-devel] " Marcelo Tosatti
2010-05-05 18:24 ` [patch uq/master 0/9] enable smp > 1 and related fixes Anthony Liguori
2010-05-05 18:24   ` [Qemu-devel] " Anthony Liguori
2010-05-06 11:33   ` Avi Kivity
2010-05-06 11:33     ` [Qemu-devel] " Avi Kivity
2010-05-06 11:34 ` Avi Kivity
2010-05-06 11:34   ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100504124634.399797233@redhat.com \
    --to=mtosatti@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.