From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: question on virtio
Date: Thu, 6 May 2010 11:02:41 +0930 [thread overview]
Message-ID: <201005061102.42306.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100505110947.GA27872@redhat.com>
On Wed, 5 May 2010 08:39:47 pm Michael S. Tsirkin wrote:
> Hi!
> I see this in virtio_ring.c:
>
> /* Put entry in available array (but don't update avail->idx *
> until they do sync). */
>
> Why is it done this way?
> It seems that updating the index straight away would be simpler, while
> this might allow the host to specilatively look up the buffer and handle
> it, without waiting for the kick.
I agree. From my TODO:
what if we actually expose in ->add_buf?
I don't *think* anyone adds buffers without being ready for them to be used,
so changing this should be safe.
Want to give it a try and report back?
Thanks!
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org
Subject: [Qemu-devel] Re: question on virtio
Date: Thu, 6 May 2010 11:02:41 +0930 [thread overview]
Message-ID: <201005061102.42306.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100505110947.GA27872@redhat.com>
On Wed, 5 May 2010 08:39:47 pm Michael S. Tsirkin wrote:
> Hi!
> I see this in virtio_ring.c:
>
> /* Put entry in available array (but don't update avail->idx *
> until they do sync). */
>
> Why is it done this way?
> It seems that updating the index straight away would be simpler, while
> this might allow the host to specilatively look up the buffer and handle
> it, without waiting for the kick.
I agree. From my TODO:
what if we actually expose in ->add_buf?
I don't *think* anyone adds buffers without being ready for them to be used,
so changing this should be safe.
Want to give it a try and report back?
Thanks!
Rusty.
next prev parent reply other threads:[~2010-05-06 1:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 11:09 question on virtio Michael S. Tsirkin
2010-05-05 11:09 ` [Qemu-devel] " Michael S. Tsirkin
2010-05-05 19:40 ` Anthony Liguori
2010-05-05 19:40 ` Anthony Liguori
2010-05-05 19:40 ` [Qemu-devel] " Anthony Liguori
2010-05-05 20:59 ` Michael S. Tsirkin
2010-05-05 20:59 ` Michael S. Tsirkin
2010-05-05 20:59 ` [Qemu-devel] " Michael S. Tsirkin
2010-05-06 1:32 ` Rusty Russell
2010-05-06 1:32 ` Rusty Russell [this message]
2010-05-06 1:32 ` [Qemu-devel] " Rusty Russell
2010-05-06 16:43 ` [Qemu-devel] " Jamie Lokier
2010-05-06 16:43 ` Jamie Lokier
2010-05-06 16:43 ` Jamie Lokier
-- strict thread matches above, loose matches on Subject: below --
2010-05-05 11:09 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005061102.42306.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.