* [patch]hp_accel: Fix race in device removal
@ 2010-05-07 16:04 ` Oliver Neukum
0 siblings, 0 replies; 20+ messages in thread
From: Oliver Neukum @ 2010-05-07 16:04 UTC (permalink / raw)
To: Andrew Morton
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
>From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oliver@neukum.org>
Date: Fri, 7 May 2010 18:02:07 +0200
Subject: [PATCH] hp_accel: Fix race in device removal
The work queue has to be flushed after the device has been made
inaccessible.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
---
drivers/hwmon/hp_accel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
index c8ab505..7580f55 100644
--- a/drivers/hwmon/hp_accel.c
+++ b/drivers/hwmon/hp_accel.c
@@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
lis3lv02d_joystick_disable();
lis3lv02d_poweroff(&lis3_dev);
- flush_work(&hpled_led.work);
led_classdev_unregister(&hpled_led.led_classdev);
+ flush_work(&hpled_led.work);
return lis3lv02d_remove_fs(&lis3_dev);
}
--
1.6.4.2
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [lm-sensors] [patch]hp_accel: Fix race in device removal
2010-05-07 16:04 ` Oliver Neukum
@ 2010-05-07 16:07 ` Pavel Machek
-1 siblings, 0 replies; 20+ messages in thread
From: Pavel Machek @ 2010-05-07 16:07 UTC (permalink / raw)
To: Oliver Neukum
Cc: Andrew Morton, Eric Piel, Pavel Herrmann, lm-sensors,
linux-kernel, stable
On Fri 2010-05-07 18:04:20, Oliver Neukum wrote:
> From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Fri, 7 May 2010 18:02:07 +0200
> Subject: [PATCH] hp_accel: Fix race in device removal
>
> The work queue has to be flushed after the device has been made
> inaccessible.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
ACK.
> ---
> drivers/hwmon/hp_accel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> index c8ab505..7580f55 100644
> --- a/drivers/hwmon/hp_accel.c
> +++ b/drivers/hwmon/hp_accel.c
> @@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
> lis3lv02d_joystick_disable();
> lis3lv02d_poweroff(&lis3_dev);
>
> - flush_work(&hpled_led.work);
> led_classdev_unregister(&hpled_led.led_classdev);
> + flush_work(&hpled_led.work);
>
> return lis3lv02d_remove_fs(&lis3_dev);
> }
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [patch]hp_accel: Fix race in device removal
@ 2010-05-07 16:07 ` Pavel Machek
0 siblings, 0 replies; 20+ messages in thread
From: Pavel Machek @ 2010-05-07 16:07 UTC (permalink / raw)
To: Oliver Neukum
Cc: Andrew Morton, Eric Piel, Pavel Herrmann, lm-sensors,
linux-kernel, stable
On Fri 2010-05-07 18:04:20, Oliver Neukum wrote:
> From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Fri, 7 May 2010 18:02:07 +0200
> Subject: [PATCH] hp_accel: Fix race in device removal
>
> The work queue has to be flushed after the device has been made
> inaccessible.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
ACK.
> ---
> drivers/hwmon/hp_accel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> index c8ab505..7580f55 100644
> --- a/drivers/hwmon/hp_accel.c
> +++ b/drivers/hwmon/hp_accel.c
> @@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
> lis3lv02d_joystick_disable();
> lis3lv02d_poweroff(&lis3_dev);
>
> - flush_work(&hpled_led.work);
> led_classdev_unregister(&hpled_led.led_classdev);
> + flush_work(&hpled_led.work);
>
> return lis3lv02d_remove_fs(&lis3_dev);
> }
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [lm-sensors] [patch]hp_accel: Fix race in device removal
2010-05-07 16:04 ` Oliver Neukum
@ 2010-05-07 16:09 ` Éric Piel
-1 siblings, 0 replies; 20+ messages in thread
From: Éric Piel @ 2010-05-07 16:09 UTC (permalink / raw)
To: Oliver Neukum
Cc: Andrew Morton, Pavel Machek, Pavel Herrmann, lm-sensors,
linux-kernel, stable
Op 07-05-10 18:04, Oliver Neukum schreef:
> From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Fri, 7 May 2010 18:02:07 +0200
> Subject: [PATCH] hp_accel: Fix race in device removal
>
> The work queue has to be flushed after the device has been made
> inaccessible.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
Ah, flushing the work before unregistering the device seemed more
logical... but now that you mention it, I understand the race.
Thanks
Acked-by: Eric Piel <eric.piel@tremplin-utc.net>
> ---
> drivers/hwmon/hp_accel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> index c8ab505..7580f55 100644
> --- a/drivers/hwmon/hp_accel.c
> +++ b/drivers/hwmon/hp_accel.c
> @@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
> lis3lv02d_joystick_disable();
> lis3lv02d_poweroff(&lis3_dev);
>
> - flush_work(&hpled_led.work);
> led_classdev_unregister(&hpled_led.led_classdev);
> + flush_work(&hpled_led.work);
>
> return lis3lv02d_remove_fs(&lis3_dev);
> }
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [patch]hp_accel: Fix race in device removal
@ 2010-05-07 16:09 ` Éric Piel
0 siblings, 0 replies; 20+ messages in thread
From: Éric Piel @ 2010-05-07 16:09 UTC (permalink / raw)
To: Oliver Neukum
Cc: Andrew Morton, Pavel Machek, Pavel Herrmann, lm-sensors,
linux-kernel, stable
Op 07-05-10 18:04, Oliver Neukum schreef:
> From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Fri, 7 May 2010 18:02:07 +0200
> Subject: [PATCH] hp_accel: Fix race in device removal
>
> The work queue has to be flushed after the device has been made
> inaccessible.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
Ah, flushing the work before unregistering the device seemed more
logical... but now that you mention it, I understand the race.
Thanks
Acked-by: Eric Piel <eric.piel@tremplin-utc.net>
> ---
> drivers/hwmon/hp_accel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> index c8ab505..7580f55 100644
> --- a/drivers/hwmon/hp_accel.c
> +++ b/drivers/hwmon/hp_accel.c
> @@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
> lis3lv02d_joystick_disable();
> lis3lv02d_poweroff(&lis3_dev);
>
> - flush_work(&hpled_led.work);
> led_classdev_unregister(&hpled_led.led_classdev);
> + flush_work(&hpled_led.work);
>
> return lis3lv02d_remove_fs(&lis3_dev);
> }
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [lm-sensors] [patch]hp_accel: Fix race in device removal
2010-05-07 16:04 ` Oliver Neukum
@ 2010-05-10 22:46 ` Andrew Morton
-1 siblings, 0 replies; 20+ messages in thread
From: Andrew Morton @ 2010-05-10 22:46 UTC (permalink / raw)
To: Oliver Neukum
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
On Fri, 7 May 2010 18:04:20 +0200
Oliver Neukum <oneukum@suse.de> wrote:
> >From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Fri, 7 May 2010 18:02:07 +0200
> Subject: [PATCH] hp_accel: Fix race in device removal
>
> The work queue has to be flushed after the device has been made
> inaccessible.
>
You cc'ed stable@kernel.org so presumably you think it's a pretty
serious bug.
But alas, I (and presumably others) cannot confirm that, because you
didn't describe the bug :( This also means that if someone hits a
problem with this driver, they won't easily be able to work out whether
this patch will fix it.
Under what circumstances does it trigger?
What are the observed effects when it triggers?
Please always include this sort of information when sending bugfixes, thanks.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [patch]hp_accel: Fix race in device removal
@ 2010-05-10 22:46 ` Andrew Morton
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Morton @ 2010-05-10 22:46 UTC (permalink / raw)
To: Oliver Neukum
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
On Fri, 7 May 2010 18:04:20 +0200
Oliver Neukum <oneukum@suse.de> wrote:
> >From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Fri, 7 May 2010 18:02:07 +0200
> Subject: [PATCH] hp_accel: Fix race in device removal
>
> The work queue has to be flushed after the device has been made
> inaccessible.
>
You cc'ed stable@kernel.org so presumably you think it's a pretty
serious bug.
But alas, I (and presumably others) cannot confirm that, because you
didn't describe the bug :( This also means that if someone hits a
problem with this driver, they won't easily be able to work out whether
this patch will fix it.
Under what circumstances does it trigger?
What are the observed effects when it triggers?
Please always include this sort of information when sending bugfixes, thanks.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [lm-sensors] [patch]hp_accel: Fix race in device removal
2010-05-10 22:46 ` Andrew Morton
@ 2010-05-11 5:55 ` Oliver Neukum
-1 siblings, 0 replies; 20+ messages in thread
From: Oliver Neukum @ 2010-05-11 5:55 UTC (permalink / raw)
To: Andrew Morton
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton:
> But alas, I (and presumably others) cannot confirm that, because you
> didn't describe the bug :( This also means that if someone hits a
> problem with this driver, they won't easily be able to work out whether
> this patch will fix it.
>
>
> Under what circumstances does it trigger?
>
> What are the observed effects when it triggers?
>
> Please always include this sort of information when sending bugfixes, thanks.
Sorry,
the patch closes a window during which a work queue might remain
active after the device is removed and would then lead to ACPI calls
with undefined behavior.
Regards
Oliver
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [patch]hp_accel: Fix race in device removal
@ 2010-05-11 5:55 ` Oliver Neukum
0 siblings, 0 replies; 20+ messages in thread
From: Oliver Neukum @ 2010-05-11 5:55 UTC (permalink / raw)
To: Andrew Morton
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton:
> But alas, I (and presumably others) cannot confirm that, because you
> didn't describe the bug :( This also means that if someone hits a
> problem with this driver, they won't easily be able to work out whether
> this patch will fix it.
>
>
> Under what circumstances does it trigger?
>
> What are the observed effects when it triggers?
>
> Please always include this sort of information when sending bugfixes, thanks.
Sorry,
the patch closes a window during which a work queue might remain
active after the device is removed and would then lead to ACPI calls
with undefined behavior.
Regards
Oliver
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [lm-sensors] [patch]hp_accel: Fix race in device removal
2010-05-11 5:55 ` Oliver Neukum
@ 2010-05-11 2:57 ` Andrew Morton
-1 siblings, 0 replies; 20+ messages in thread
From: Andrew Morton @ 2010-05-11 2:57 UTC (permalink / raw)
To: Oliver Neukum
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
On Tue, 11 May 2010 07:55:07 +0200 Oliver Neukum <oneukum@suse.de> wrote:
> Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton:
> > But alas, I (and presumably others) cannot confirm that, because you
> > didn't describe the bug :( This also means that if someone hits a
> > problem with this driver, they won't easily be able to work out whether
> > this patch will fix it.
> >
> >
> > Under what circumstances does it trigger?
> >
> > What are the observed effects when it triggers?
> >
> > Please always include this sort of information when sending bugfixes, thanks.
>
> Sorry,
>
> the patch closes a window during which a work queue might remain
> active after the device is removed and would then lead to ACPI calls
> with undefined behavior.
Had anyone observed this in the field? Was a machine crashing, perhaps?
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [patch]hp_accel: Fix race in device removal
@ 2010-05-11 2:57 ` Andrew Morton
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Morton @ 2010-05-11 2:57 UTC (permalink / raw)
To: Oliver Neukum
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
On Tue, 11 May 2010 07:55:07 +0200 Oliver Neukum <oneukum@suse.de> wrote:
> Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton:
> > But alas, I (and presumably others) cannot confirm that, because you
> > didn't describe the bug :( This also means that if someone hits a
> > problem with this driver, they won't easily be able to work out whether
> > this patch will fix it.
> >
> >
> > Under what circumstances does it trigger?
> >
> > What are the observed effects when it triggers?
> >
> > Please always include this sort of information when sending bugfixes, thanks.
>
> Sorry,
>
> the patch closes a window during which a work queue might remain
> active after the device is removed and would then lead to ACPI calls
> with undefined behavior.
Had anyone observed this in the field? Was a machine crashing, perhaps?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [lm-sensors] [patch]hp_accel: Fix race in device removal
2010-05-11 2:57 ` Andrew Morton
@ 2010-05-11 6:04 ` Oliver Neukum
-1 siblings, 0 replies; 20+ messages in thread
From: Oliver Neukum @ 2010-05-11 6:04 UTC (permalink / raw)
To: Andrew Morton
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
Am Dienstag, 11. Mai 2010 04:57:25 schrieb Andrew Morton:
> On Tue, 11 May 2010 07:55:07 +0200 Oliver Neukum <oneukum@suse.de> wrote:
>
> > Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton:
> > > But alas, I (and presumably others) cannot confirm that, because you
> > > didn't describe the bug :( This also means that if someone hits a
> > > problem with this driver, they won't easily be able to work out whether
> > > this patch will fix it.
> > >
> > >
> > > Under what circumstances does it trigger?
> > >
> > > What are the observed effects when it triggers?
> > >
> > > Please always include this sort of information when sending bugfixes, thanks.
> >
> > Sorry,
> >
> > the patch closes a window during which a work queue might remain
> > active after the device is removed and would then lead to ACPI calls
> > with undefined behavior.
>
> Had anyone observed this in the field? Was a machine crashing, perhaps?
No, this was found during a code review.
Regards
Oliver
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [patch]hp_accel: Fix race in device removal
@ 2010-05-11 6:04 ` Oliver Neukum
0 siblings, 0 replies; 20+ messages in thread
From: Oliver Neukum @ 2010-05-11 6:04 UTC (permalink / raw)
To: Andrew Morton
Cc: Eric Piel, Pavel Machek, Pavel Herrmann, lm-sensors, linux-kernel,
stable
Am Dienstag, 11. Mai 2010 04:57:25 schrieb Andrew Morton:
> On Tue, 11 May 2010 07:55:07 +0200 Oliver Neukum <oneukum@suse.de> wrote:
>
> > Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton:
> > > But alas, I (and presumably others) cannot confirm that, because you
> > > didn't describe the bug :( This also means that if someone hits a
> > > problem with this driver, they won't easily be able to work out whether
> > > this patch will fix it.
> > >
> > >
> > > Under what circumstances does it trigger?
> > >
> > > What are the observed effects when it triggers?
> > >
> > > Please always include this sort of information when sending bugfixes, thanks.
> >
> > Sorry,
> >
> > the patch closes a window during which a work queue might remain
> > active after the device is removed and would then lead to ACPI calls
> > with undefined behavior.
>
> Had anyone observed this in the field? Was a machine crashing, perhaps?
No, this was found during a code review.
Regards
Oliver
^ permalink raw reply [flat|nested] 20+ messages in thread