From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
Linus Torvalds <torvalds@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
Christoph Lameter <cl@linux.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks
Date: Wed, 12 May 2010 12:54:27 -0700 [thread overview]
Message-ID: <20100512125427.d1b170ba.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100512092239.2120.A69D9226@jp.fujitsu.com>
On Wed, 12 May 2010 09:23:44 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > diff --git a/fs/exec.c b/fs/exec.c
> > index 725d7ef..13f8e7f 100644
> > --- a/fs/exec.c
> > +++ b/fs/exec.c
> > @@ -242,9 +242,10 @@ static int __bprm_mm_init(struct linux_binprm *bprm)
> > * use STACK_TOP because that can depend on attributes which aren't
> > * configured yet.
> > */
> > + BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);
>
> Can we use BUILD_BUG_ON()?
That's vastly preferable - I made that change.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
Linus Torvalds <torvalds@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
Christoph Lameter <cl@linux.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks
Date: Wed, 12 May 2010 12:54:27 -0700 [thread overview]
Message-ID: <20100512125427.d1b170ba.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100512092239.2120.A69D9226@jp.fujitsu.com>
On Wed, 12 May 2010 09:23:44 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > diff --git a/fs/exec.c b/fs/exec.c
> > index 725d7ef..13f8e7f 100644
> > --- a/fs/exec.c
> > +++ b/fs/exec.c
> > @@ -242,9 +242,10 @@ static int __bprm_mm_init(struct linux_binprm *bprm)
> > * use STACK_TOP because that can depend on attributes which aren't
> > * configured yet.
> > */
> > + BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);
>
> Can we use BUILD_BUG_ON()?
That's vastly preferable - I made that change.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-12 19:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 8:57 [PATCH] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks Mel Gorman
2010-05-11 8:57 ` Mel Gorman
2010-05-11 12:10 ` Rik van Riel
2010-05-11 12:10 ` Rik van Riel
2010-05-11 17:11 ` Linus Torvalds
2010-05-11 17:11 ` Linus Torvalds
2010-05-11 17:21 ` Rik van Riel
2010-05-11 17:21 ` Rik van Riel
2010-05-12 0:23 ` KOSAKI Motohiro
2010-05-12 0:23 ` KOSAKI Motohiro
2010-05-12 19:54 ` Andrew Morton [this message]
2010-05-12 19:54 ` Andrew Morton
2010-05-12 20:51 ` Mel Gorman
2010-05-12 20:51 ` Mel Gorman
2010-05-12 20:58 ` Andrew Morton
2010-05-12 20:58 ` Andrew Morton
2010-05-12 23:06 ` KOSAKI Motohiro
2010-05-12 23:06 ` KOSAKI Motohiro
2010-05-12 21:33 ` Christoph Lameter
2010-05-12 21:33 ` Christoph Lameter
2010-05-13 0:19 ` KAMEZAWA Hiroyuki
2010-05-13 0:19 ` KAMEZAWA Hiroyuki
2010-05-13 17:22 ` Christoph Lameter
2010-05-13 17:22 ` Christoph Lameter
2010-05-13 23:51 ` KAMEZAWA Hiroyuki
2010-05-13 23:51 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512125427.d1b170ba.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=cl@linux.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.