From: Rik van Riel <riel@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
Christoph Lameter <cl@linux.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks
Date: Tue, 11 May 2010 13:21:16 -0400 [thread overview]
Message-ID: <4BE9920C.3020901@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1005111009500.3711@i5.linux-foundation.org>
On 05/11/2010 01:11 PM, Linus Torvalds wrote:
> On Tue, 11 May 2010, Mel Gorman wrote:
>>
>> This patch closes the most important race in relation to exec and
>> migration. With it applied, the swapops bug is no longer triggering for
>> known problem workloads. If you pick it up, it should go with the other
>> mmmigration-* fixes in mm.
>
> Ack. _Much_ better and clearer.
>
> I'm not entirely sure we need that "maybe_stack" (if we need it, that
> would sound like a problem anyway), but I guess it can't hurt either.
Just a heads up - I am looking at creating a patch now that
allows us to _always_ lock the root anon_vma lock, when locking
the anon_vma.
That should take care of the other issue pretty cleanly, while
still allowing us to only walk the VMAs we have to walk in
places like rmap_walk.
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
Christoph Lameter <cl@linux.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks
Date: Tue, 11 May 2010 13:21:16 -0400 [thread overview]
Message-ID: <4BE9920C.3020901@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1005111009500.3711@i5.linux-foundation.org>
On 05/11/2010 01:11 PM, Linus Torvalds wrote:
> On Tue, 11 May 2010, Mel Gorman wrote:
>>
>> This patch closes the most important race in relation to exec and
>> migration. With it applied, the swapops bug is no longer triggering for
>> known problem workloads. If you pick it up, it should go with the other
>> mmmigration-* fixes in mm.
>
> Ack. _Much_ better and clearer.
>
> I'm not entirely sure we need that "maybe_stack" (if we need it, that
> would sound like a problem anyway), but I guess it can't hurt either.
Just a heads up - I am looking at creating a patch now that
allows us to _always_ lock the root anon_vma lock, when locking
the anon_vma.
That should take care of the other issue pretty cleanly, while
still allowing us to only walk the VMAs we have to walk in
places like rmap_walk.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-11 17:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 8:57 [PATCH] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks Mel Gorman
2010-05-11 8:57 ` Mel Gorman
2010-05-11 12:10 ` Rik van Riel
2010-05-11 12:10 ` Rik van Riel
2010-05-11 17:11 ` Linus Torvalds
2010-05-11 17:11 ` Linus Torvalds
2010-05-11 17:21 ` Rik van Riel [this message]
2010-05-11 17:21 ` Rik van Riel
2010-05-12 0:23 ` KOSAKI Motohiro
2010-05-12 0:23 ` KOSAKI Motohiro
2010-05-12 19:54 ` Andrew Morton
2010-05-12 19:54 ` Andrew Morton
2010-05-12 20:51 ` Mel Gorman
2010-05-12 20:51 ` Mel Gorman
2010-05-12 20:58 ` Andrew Morton
2010-05-12 20:58 ` Andrew Morton
2010-05-12 23:06 ` KOSAKI Motohiro
2010-05-12 23:06 ` KOSAKI Motohiro
2010-05-12 21:33 ` Christoph Lameter
2010-05-12 21:33 ` Christoph Lameter
2010-05-13 0:19 ` KAMEZAWA Hiroyuki
2010-05-13 0:19 ` KAMEZAWA Hiroyuki
2010-05-13 17:22 ` Christoph Lameter
2010-05-13 17:22 ` Christoph Lameter
2010-05-13 23:51 ` KAMEZAWA Hiroyuki
2010-05-13 23:51 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE9920C.3020901@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.