All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	David Rientjes <rientjes@google.com>,
	Alex Chiang <achiang@hp.com>,
	linux-kernel@vger.kernel.org, ak@linux.intel.com,
	fengguang.wu@intel.com, haicheng.li@linux.intel.com,
	shaohui.zheng@linux.intel.com
Subject: Re: [RFC, 3/7] NUMA hotplug emulator
Date: Thu, 13 May 2010 09:55:11 -0700	[thread overview]
Message-ID: <20100513165511.GB25212@suse.de> (raw)
In-Reply-To: <20100513114835.GD2169@shaohui>

On Thu, May 13, 2010 at 07:48:35PM +0800, Shaohui Zheng wrote:
> Userland interface to hotplug-add fake offlined nodes.

Why include 2 copies of the patch in one email?

> Add a sysfs entry "probe" under /sys/devices/system/node/:
> 
>  - to show all fake offlined nodes:
>     $ cat /sys/devices/system/node/probe
> 
>  - to hotadd a fake offlined node, e.g. nodeid is N:
>     $ echo N > /sys/devices/system/node/probe

As you are trying to add a new sysfs file, please create the matching
Documentation/ABI/ file as well.

Also note that sysfs files are "one value per file", which I don't think
this file follows, right?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	David Rientjes <rientjes@google.com>,
	Alex Chiang <achiang@hp.com>,
	linux-kernel@vger.kernel.org, ak@linux.intel.com,
	fengguang.wu@intel.com, haicheng.li@linux.intel.com,
	shaohui.zheng@linux.intel.com
Subject: Re: [RFC, 3/7] NUMA hotplug emulator
Date: Thu, 13 May 2010 09:55:11 -0700	[thread overview]
Message-ID: <20100513165511.GB25212@suse.de> (raw)
In-Reply-To: <20100513114835.GD2169@shaohui>

On Thu, May 13, 2010 at 07:48:35PM +0800, Shaohui Zheng wrote:
> Userland interface to hotplug-add fake offlined nodes.

Why include 2 copies of the patch in one email?

> Add a sysfs entry "probe" under /sys/devices/system/node/:
> 
>  - to show all fake offlined nodes:
>     $ cat /sys/devices/system/node/probe
> 
>  - to hotadd a fake offlined node, e.g. nodeid is N:
>     $ echo N > /sys/devices/system/node/probe

As you are trying to add a new sysfs file, please create the matching
Documentation/ABI/ file as well.

Also note that sysfs files are "one value per file", which I don't think
this file follows, right?

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-05-13 16:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 11:48 [RFC, 3/7] NUMA hotplug emulator Shaohui Zheng
2010-05-13 16:55 ` Greg KH [this message]
2010-05-13 16:55   ` Greg KH
2010-05-13 17:54   ` Dave Hansen
2010-05-13 17:54     ` Dave Hansen
2010-05-13 18:05     ` Greg KH
2010-05-13 18:05       ` Greg KH
2010-05-14  2:13     ` Haicheng Li
2010-05-14  2:13       ` Haicheng Li
2010-05-14  1:45   ` Shaohui Zheng
2010-05-14  1:45     ` Shaohui Zheng
2010-05-14  2:01     ` Wu Fengguang
2010-05-14  2:01       ` Wu Fengguang
2010-05-14  2:11       ` Shaohui Zheng
2010-05-14  2:11         ` Shaohui Zheng
2010-05-14  2:01   ` Haicheng Li
2010-05-14  2:01     ` Haicheng Li
2010-05-14  3:31 ` Haicheng Li
2010-05-14  3:31   ` Haicheng Li
2010-05-14  4:11   ` Wu Fengguang
2010-05-14  4:11     ` Wu Fengguang
2010-05-14  5:19     ` Shaohui Zheng
2010-05-14  5:19       ` Shaohui Zheng
2010-05-14  5:32     ` Haicheng Li
2010-05-14  5:32       ` Haicheng Li
2010-05-14  5:52       ` Wu Fengguang
2010-05-14  5:52         ` Wu Fengguang
2010-05-21 10:08 ` Ankita Garg
2010-05-21 10:08   ` Ankita Garg
2010-05-24  1:31   ` Shaohui Zheng
2010-05-24  1:31     ` Shaohui Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100513165511.GB25212@suse.de \
    --to=gregkh@suse.de \
    --cc=achiang@hp.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=haicheng.li@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=rientjes@google.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=shaohui.zheng@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.