From: Wu Fengguang <fengguang.wu@intel.com>
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
David Rientjes <rientjes@google.com>,
Alex Chiang <achiang@hp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ak@linux.intel.co" <ak@linux.intel.co>,
"shaohui.zheng@linux.intel.com" <shaohui.zheng@linux.intel.com>
Subject: Re: [RFC, 3/7] NUMA hotplug emulator
Date: Fri, 14 May 2010 12:11:36 +0800 [thread overview]
Message-ID: <20100514041136.GA12020@localhost> (raw)
In-Reply-To: <4BECC418.2080602@linux.intel.com>
> Pls. replace it with following code:
>
> +#ifdef CONFIG_NODE_HOTPLUG_EMU
> +static ssize_t store_nodes_probe(struct sysdev_class *class,
> + struct sysdev_class_attribute *attr,
> + const char *buf, size_t count)
> +{
> + long nid;
> + int ret;
> +
> + ret = strict_strtol(buf, 0, &nid);
> + if (ret == -EINVAL)
> + return ret;
> +
> + ret = hotadd_hidden_nodes(nid);
> + if (!ret)
> + return count;
> + else
> + return -EIO;
> +}
> +#endif
How about this?
err = strict_strtol(buf, 0, &nid);
if (err < 0)
return err;
err = hotadd_hidden_nodes(nid);
if (err < 0)
return err;
return count;
Thanks,
Fengguang
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
David Rientjes <rientjes@google.com>,
Alex Chiang <achiang@hp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ak@linux.intel.co" <ak@linux.intel.co>,
"shaohui.zheng@linux.intel.com" <shaohui.zheng@linux.intel.com>
Subject: Re: [RFC, 3/7] NUMA hotplug emulator
Date: Fri, 14 May 2010 12:11:36 +0800 [thread overview]
Message-ID: <20100514041136.GA12020@localhost> (raw)
In-Reply-To: <4BECC418.2080602@linux.intel.com>
> Pls. replace it with following code:
>
> +#ifdef CONFIG_NODE_HOTPLUG_EMU
> +static ssize_t store_nodes_probe(struct sysdev_class *class,
> + struct sysdev_class_attribute *attr,
> + const char *buf, size_t count)
> +{
> + long nid;
> + int ret;
> +
> + ret = strict_strtol(buf, 0, &nid);
> + if (ret == -EINVAL)
> + return ret;
> +
> + ret = hotadd_hidden_nodes(nid);
> + if (!ret)
> + return count;
> + else
> + return -EIO;
> +}
> +#endif
How about this?
err = strict_strtol(buf, 0, &nid);
if (err < 0)
return err;
err = hotadd_hidden_nodes(nid);
if (err < 0)
return err;
return count;
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-14 4:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 11:48 [RFC, 3/7] NUMA hotplug emulator Shaohui Zheng
2010-05-13 16:55 ` Greg KH
2010-05-13 16:55 ` Greg KH
2010-05-13 17:54 ` Dave Hansen
2010-05-13 17:54 ` Dave Hansen
2010-05-13 18:05 ` Greg KH
2010-05-13 18:05 ` Greg KH
2010-05-14 2:13 ` Haicheng Li
2010-05-14 2:13 ` Haicheng Li
2010-05-14 1:45 ` Shaohui Zheng
2010-05-14 1:45 ` Shaohui Zheng
2010-05-14 2:01 ` Wu Fengguang
2010-05-14 2:01 ` Wu Fengguang
2010-05-14 2:11 ` Shaohui Zheng
2010-05-14 2:11 ` Shaohui Zheng
2010-05-14 2:01 ` Haicheng Li
2010-05-14 2:01 ` Haicheng Li
2010-05-14 3:31 ` Haicheng Li
2010-05-14 3:31 ` Haicheng Li
2010-05-14 4:11 ` Wu Fengguang [this message]
2010-05-14 4:11 ` Wu Fengguang
2010-05-14 5:19 ` Shaohui Zheng
2010-05-14 5:19 ` Shaohui Zheng
2010-05-14 5:32 ` Haicheng Li
2010-05-14 5:32 ` Haicheng Li
2010-05-14 5:52 ` Wu Fengguang
2010-05-14 5:52 ` Wu Fengguang
2010-05-21 10:08 ` Ankita Garg
2010-05-21 10:08 ` Ankita Garg
2010-05-24 1:31 ` Shaohui Zheng
2010-05-24 1:31 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514041136.GA12020@localhost \
--to=fengguang.wu@intel.com \
--cc=achiang@hp.com \
--cc=ak@linux.intel.co \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=haicheng.li@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=shaohui.zheng@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.