From: Dan Carpenter <error27@gmail.com>
To: Christian Koenig <deathsimple@vodafone.de>
Cc: dri-devel@lists.sourceforge.net
Subject: bug report: "drm/radeon/kms: HDMI irq support"
Date: Fri, 14 May 2010 13:29:27 +0200 [thread overview]
Message-ID: <20100514112927.GF5695@bicker> (raw)
Smatch complains about something from: f2594933df97 "drm/radeon/kms:
HDMI irq support"
drivers/gpu/drm/radeon/r600_hdmi.c +557 r600_hdmi_disable(20) error:
offset is never equal to 29696 (wrong type 0 - 255).
+
+ /* disable irq */
+ rdev->irq.hdmi[offset == R600_HDMI_BLOCK1 ? 0 : 1] = false;
^^^^^^^^^^^^^^^^^^^^^^^^^^
offset is 8 bits so this condition is always false.
+ radeon_irq_set(rdev);
+
regards,
dan carpenter
------------------------------------------------------------------------------
--
reply other threads:[~2010-05-14 11:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514112927.GF5695@bicker \
--to=error27@gmail.com \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.