* bug report: "drm/radeon/kms: HDMI irq support"
@ 2010-05-14 11:29 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-05-14 11:29 UTC (permalink / raw)
To: Christian Koenig; +Cc: dri-devel
Smatch complains about something from: f2594933df97 "drm/radeon/kms:
HDMI irq support"
drivers/gpu/drm/radeon/r600_hdmi.c +557 r600_hdmi_disable(20) error:
offset is never equal to 29696 (wrong type 0 - 255).
+
+ /* disable irq */
+ rdev->irq.hdmi[offset == R600_HDMI_BLOCK1 ? 0 : 1] = false;
^^^^^^^^^^^^^^^^^^^^^^^^^^
offset is 8 bits so this condition is always false.
+ radeon_irq_set(rdev);
+
regards,
dan carpenter
------------------------------------------------------------------------------
--
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-14 11:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-14 11:29 bug report: "drm/radeon/kms: HDMI irq support" Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.