From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Nigel Cunningham <ncunningham@crca.org.au>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Matt Reimer <mattjreimer@gmail.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
Jens Axboe <jens.axboe@oracle.com>,
"linux-pm" <linux-pm@lists.linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [linux-pm] Is it supposed to be ok to call del_gendisk while userspace is frozen?
Date: Sun, 16 May 2010 21:35:18 +0200 [thread overview]
Message-ID: <201005162135.18767.rjw@sisk.pl> (raw)
In-Reply-To: <4BEE0CC5.60804@crca.org.au>
On Saturday 15 May 2010, Nigel Cunningham wrote:
> Hi.
>
> On 15/05/10 12:37, Alan Stern wrote:
> > On Fri, 14 May 2010, Nigel Cunningham wrote:
> >
> >> Hi.
> >
> >>> Subject: [PATCH] fs: prevent hang on suspend/resume when MMC/SD card present
> >>>
> >>> Devices can come and go bus during suspend or resume, when the
> >>> writeback thread is frozen, resulting in a hang. Prevent the hang
> >>> by thawing the writeback thread in del_gendisk().
> >
> >> Why not just make it unfreezeable to start with?
> >
> > If the writeback thread were unfreezable, it might wake up and try to
> > write dirty pages back to disks after they were already suspended.
> > That would not lead to good consequences...
>
> If it syncs data as it should when we freeze processes, there won't be
> any problem. Perhaps this is just an argument against making syncing
> optional?
No, there is a problem. The writeback threads were made freezable after some
people had reported hangs during suspend that had been tracked down to that
issue. IIRC.
Rafael
next prev parent reply other threads:[~2010-05-16 19:34 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 13:29 Is it supposed to be ok to call del_gendisk while userspace is frozen? Maxim Levitsky
2010-02-13 13:29 ` Maxim Levitsky
2010-02-15 16:00 ` Maxim Levitsky
2010-02-15 21:04 ` Rafael J. Wysocki
2010-02-16 16:27 ` Alan Stern
2010-02-16 16:27 ` [linux-pm] " Alan Stern
2010-02-20 22:22 ` Maxim Levitsky
2010-02-20 22:22 ` [linux-pm] " Maxim Levitsky
2010-02-23 12:33 ` Jens Axboe
2010-02-23 15:29 ` Alan Stern
2010-02-23 15:29 ` [linux-pm] " Alan Stern
2010-02-23 15:58 ` Jens Axboe
2010-02-23 16:33 ` Alan Stern
2010-02-23 22:16 ` Jens Axboe
2010-02-23 22:16 ` [linux-pm] " Jens Axboe
2010-02-24 15:59 ` Alan Stern
2010-02-24 19:12 ` Jens Axboe
2010-02-24 19:12 ` [linux-pm] " Jens Axboe
2010-02-24 20:19 ` Alan Stern
2010-02-24 20:19 ` Alan Stern
2010-02-24 15:59 ` Alan Stern
2010-02-23 16:33 ` Alan Stern
2010-02-23 16:42 ` Testing for dirty buffers on a block device Alan Stern
2010-02-23 22:13 ` Jens Axboe
2010-02-23 22:13 ` Jens Axboe
2010-02-24 15:51 ` Alan Stern
2010-02-24 15:51 ` Alan Stern
2010-02-24 19:09 ` Jens Axboe
2010-02-24 20:09 ` Alan Stern
2010-02-25 8:20 ` Jens Axboe
2010-02-25 22:19 ` Dave Chinner
2010-02-25 22:19 ` Dave Chinner
2010-02-25 8:20 ` Jens Axboe
2010-02-24 20:09 ` Alan Stern
2010-02-24 19:09 ` Jens Axboe
2010-02-23 16:42 ` Alan Stern
2010-02-23 15:58 ` Is it supposed to be ok to call del_gendisk while userspace is frozen? Jens Axboe
2010-03-01 6:35 ` Pavel Machek
2010-03-01 6:35 ` [linux-pm] " Pavel Machek
2010-03-01 15:23 ` Alan Stern
2010-03-01 15:23 ` [linux-pm] " Alan Stern
2010-03-03 21:50 ` Pavel Machek
2010-03-03 22:23 ` Alan Stern
2010-03-04 0:23 ` Rafael J. Wysocki
2010-03-04 2:48 ` Alan Stern
2010-03-04 19:26 ` Rafael J. Wysocki
2010-03-04 19:26 ` [linux-pm] " Rafael J. Wysocki
2010-03-04 19:36 ` Alan Stern
2010-03-04 19:36 ` [linux-pm] " Alan Stern
2010-03-04 20:04 ` Rafael J. Wysocki
2010-03-04 20:04 ` Rafael J. Wysocki
2010-03-04 20:15 ` Pavel Machek
2010-03-04 20:15 ` [linux-pm] " Pavel Machek
2010-04-22 23:40 ` Matt Reimer
2010-04-23 5:17 ` Rafael J. Wysocki
2010-04-23 5:17 ` [linux-pm] " Rafael J. Wysocki
2010-05-11 23:55 ` Matt Reimer
2010-05-11 23:55 ` [linux-pm] " Matt Reimer
2010-05-12 14:50 ` Alan Stern
2010-05-12 14:50 ` [linux-pm] " Alan Stern
2010-05-13 21:44 ` Matt Reimer
2010-05-13 21:44 ` [linux-pm] " Matt Reimer
2010-05-13 21:54 ` Alan Stern
2010-05-13 21:54 ` [linux-pm] " Alan Stern
2010-05-13 22:20 ` Matt Reimer
2010-05-13 22:20 ` [linux-pm] " Matt Reimer
2010-05-13 22:47 ` Nigel Cunningham
2010-05-13 22:47 ` [linux-pm] " Nigel Cunningham
2010-05-15 2:37 ` Alan Stern
2010-05-15 2:53 ` Nigel Cunningham
2010-05-16 19:35 ` Rafael J. Wysocki
2010-05-16 19:35 ` Rafael J. Wysocki [this message]
2010-05-15 2:53 ` Nigel Cunningham
2010-05-15 2:37 ` Alan Stern
2010-05-15 2:32 ` [linux-pm] " Alan Stern
2010-05-15 20:30 ` Rafael J. Wysocki
2010-05-15 20:30 ` [linux-pm] " Rafael J. Wysocki
2010-05-16 7:49 ` Nigel Cunningham
2010-05-16 7:49 ` [linux-pm] " Nigel Cunningham
2010-05-16 19:38 ` Rafael J. Wysocki
2010-05-16 21:32 ` Nigel Cunningham
2010-05-17 2:22 ` Alan Stern
2010-05-17 7:45 ` Nigel Cunningham
2010-05-17 20:35 ` Rafael J. Wysocki
2010-05-17 22:51 ` Nigel Cunningham
2010-05-18 19:43 ` Rafael J. Wysocki
2010-05-18 19:43 ` [linux-pm] " Rafael J. Wysocki
2010-05-18 20:06 ` Alan Stern
2010-05-18 20:06 ` [linux-pm] " Alan Stern
2010-05-24 19:02 ` Pavel Machek
2010-05-24 21:21 ` Nigel Cunningham
2010-05-24 21:21 ` Nigel Cunningham
2010-05-24 19:02 ` Pavel Machek
2010-05-17 22:51 ` Nigel Cunningham
2010-05-17 20:35 ` Rafael J. Wysocki
2010-05-17 7:45 ` Nigel Cunningham
2010-05-17 2:22 ` Alan Stern
2010-05-16 21:32 ` Nigel Cunningham
2010-05-16 19:38 ` Rafael J. Wysocki
2010-05-15 2:32 ` Alan Stern
2010-04-22 23:40 ` Matt Reimer
2010-03-04 2:48 ` Alan Stern
2010-03-04 0:23 ` Rafael J. Wysocki
2010-03-04 13:53 ` [linux-pm] " Pavel Machek
2010-06-04 11:20 ` Maxim Levitsky
2010-06-04 11:20 ` [linux-pm] " Maxim Levitsky
2010-06-04 14:59 ` Alan Stern
2010-06-04 15:19 ` Maxim Levitsky
2010-06-04 17:52 ` Alan Stern
2010-06-04 17:52 ` [linux-pm] " Alan Stern
2010-06-04 15:19 ` Maxim Levitsky
2010-06-04 14:59 ` Alan Stern
2010-03-04 13:53 ` Pavel Machek
2010-03-03 22:23 ` Alan Stern
2010-03-03 21:50 ` Pavel Machek
2010-02-23 12:33 ` Jens Axboe
2010-02-15 21:04 ` Rafael J. Wysocki
2010-02-15 16:00 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005162135.18767.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mattjreimer@gmail.com \
--cc=ncunningham@crca.org.au \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.