From: Ben Dooks <ben-linux@fluff.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com,
ben-linux@fluff.org, kgene.kim@samsung.com
Subject: Re: [PATCH 01/15] ARM: Samsung: fix broken timer irq base
Date: Tue, 18 May 2010 05:57:03 +0100 [thread overview]
Message-ID: <20100518045703.GA26401@trinity.fluff.org> (raw)
In-Reply-To: <1273817946-29404-2-git-send-email-m.szyprowski@samsung.com>
On Fri, May 14, 2010 at 08:18:52AM +0200, Marek Szyprowski wrote:
> Timer interrupts range was defined as 43-47, what overlaps with VIC0 range
> (32-64). This was caused probably by a typo while the common interrupts
> definition was refactored. This patch moves timer interrupt range to safe
> area of 11-15 (just before uart range).
I've put this on for-2635/s5p-general as it is a reasonably important
bugfix for s5p. Have updated the comment to reference the commit that
caused the problem in the first place.
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-s5p/include/plat/irqs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s5p/include/plat/irqs.h b/arch/arm/plat-s5p/include/plat/irqs.h
> index 42e757f..9ff3d71 100644
> --- a/arch/arm/plat-s5p/include/plat/irqs.h
> +++ b/arch/arm/plat-s5p/include/plat/irqs.h
> @@ -79,7 +79,7 @@
> #define S5P_IRQ_VIC2(x) (S5P_VIC2_BASE + (x))
> #define S5P_IRQ_VIC3(x) (S5P_VIC3_BASE + (x))
>
> -#define S5P_TIMER_IRQ(x) S5P_IRQ(11 + (x))
> +#define S5P_TIMER_IRQ(x) (11 + (x))
>
> #define IRQ_TIMER0 S5P_TIMER_IRQ(0)
> #define IRQ_TIMER1 S5P_TIMER_IRQ(1)
> --
> 1.6.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
WARNING: multiple messages have this Message-ID (diff)
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/15] ARM: Samsung: fix broken timer irq base
Date: Tue, 18 May 2010 05:57:03 +0100 [thread overview]
Message-ID: <20100518045703.GA26401@trinity.fluff.org> (raw)
In-Reply-To: <1273817946-29404-2-git-send-email-m.szyprowski@samsung.com>
On Fri, May 14, 2010 at 08:18:52AM +0200, Marek Szyprowski wrote:
> Timer interrupts range was defined as 43-47, what overlaps with VIC0 range
> (32-64). This was caused probably by a typo while the common interrupts
> definition was refactored. This patch moves timer interrupt range to safe
> area of 11-15 (just before uart range).
I've put this on for-2635/s5p-general as it is a reasonably important
bugfix for s5p. Have updated the comment to reference the commit that
caused the problem in the first place.
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-s5p/include/plat/irqs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s5p/include/plat/irqs.h b/arch/arm/plat-s5p/include/plat/irqs.h
> index 42e757f..9ff3d71 100644
> --- a/arch/arm/plat-s5p/include/plat/irqs.h
> +++ b/arch/arm/plat-s5p/include/plat/irqs.h
> @@ -79,7 +79,7 @@
> #define S5P_IRQ_VIC2(x) (S5P_VIC2_BASE + (x))
> #define S5P_IRQ_VIC3(x) (S5P_VIC3_BASE + (x))
>
> -#define S5P_TIMER_IRQ(x) S5P_IRQ(11 + (x))
> +#define S5P_TIMER_IRQ(x) (11 + (x))
>
> #define IRQ_TIMER0 S5P_TIMER_IRQ(0)
> #define IRQ_TIMER1 S5P_TIMER_IRQ(1)
> --
> 1.6.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-05-18 4:57 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 6:18 [PATCH v2] ARM: Samsung: S5PC100 platform cleanup Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-14 6:18 ` [PATCH 01/15] ARM: Samsung: fix broken timer irq base Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:52 ` Kukjin Kim
2010-05-17 11:52 ` Kukjin Kim
2010-05-18 4:57 ` Ben Dooks [this message]
2010-05-18 4:57 ` Ben Dooks
2010-05-14 6:18 ` [PATCH 02/15] ARM: Samsung: move common I2C0 device helpers to machine directories Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 13:23 ` Kukjin Kim
2010-05-17 13:23 ` Kukjin Kim
2010-05-14 6:18 ` [PATCH 03/15] ARM: Samsung: move driver strength gpio configuration helper to common dir Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-14 6:18 ` [PATCH 04/15] drivers: serial: S5PC100 serial driver cleanup Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:14 ` Kukjin Kim
2010-05-17 11:14 ` Kukjin Kim
2010-05-14 6:18 ` [PATCH 05/15] ARM: S5PC100: Use common functions for gpiolib implementation Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:14 ` Kukjin Kim
2010-05-17 11:14 ` Kukjin Kim
2010-05-17 13:59 ` Maurus Cuelenaere
2010-05-17 13:59 ` Maurus Cuelenaere
2010-05-14 6:18 ` [PATCH 06/15] ARM: S5PC100: Move gpio support from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:24 ` Kukjin Kim
2010-05-17 11:24 ` Kukjin Kim
2010-05-18 9:38 ` Marek Szyprowski
2010-05-18 9:38 ` Marek Szyprowski
2010-05-14 6:18 ` [PATCH 07/15] ARM: S5PC100: rename gpio registers from s5pc1xx to s5pc100 Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:48 ` Kukjin Kim
2010-05-17 11:48 ` Kukjin Kim
2010-05-14 6:18 ` [PATCH 08/15] ARM: S5PC100: Move frame buffer helpers from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 13:45 ` Kukjin Kim
2010-05-17 13:45 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 09/15] ARM: S5PC100: Move i2c " Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-17 13:00 ` Kukjin Kim
2010-05-17 13:00 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 10/15] ARM: S5PC100: Move sdhci " Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-17 12:45 ` Kukjin Kim
2010-05-17 12:45 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 11/15] ARM: Samsung: move S5PC100 support from plat-s5pc1xx to plat-s5p framework Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-14 6:19 ` [PATCH 12/15] ARM: SMDKC100: fix frame buffer definitions Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-17 13:36 ` Kukjin Kim
2010-05-17 13:36 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 13/15] ARM: Samsung: Move external interrupts support from plat-s5pc1xx to plat-s5p Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-17 13:28 ` Kukjin Kim
2010-05-17 13:28 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 14/15] ARM: S5PC100: Add support for gpio interrupt Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-14 6:19 ` [PATCH 15/15] ARM: remove obsolete plat-s5pc1xx directory Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518045703.GA26401@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.