From: Maurus Cuelenaere <mcuelenaere@gmail.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Marek Szyprowski' <m.szyprowski@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com,
ben-linux@fluff.org
Subject: Re: [PATCH 05/15] ARM: S5PC100: Use common functions for gpiolib implementation
Date: Mon, 17 May 2010 15:59:41 +0200 [thread overview]
Message-ID: <4BF14BCD.3050500@gmail.com> (raw)
In-Reply-To: <003201caf5b2$2d641d00$882c5700$%kim@samsung.com>
Op 17-05-10 13:14, Kukjin Kim schreef:
> Marek Szyprowski wrote:
>
> <snip>
>> -
>> static __init int s5pc1xx_gpiolib_init(void)
>> {
>> - struct s3c_gpio_chip *chips;
>> + struct s3c_gpio_chip *chip;
>> int nr_chips;
>>
>> - chips = s5pc100_gpio_chips;
>> - nr_chips = ARRAY_SIZE(s5pc100_gpio_chips);
>> + chip = s5pc100_gpio_chips;
>> + nr_chips = ARRAY_SIZE(s5pc100_gpio_chips);
>> +
>> + for (; nr_chips > 0; nr_chips--, chip++)
>> + s5pc100_gpiolib_link(chip);
>>
>> - s5pc1xx_gpiolib_add(chips, nr_chips, s5pc1xx_gpiolib_link);
>> + samsung_gpiolib_add_4bit_chips(s5pc100_gpio_chips,
>> + ARRAY_SIZE(s5pc100_gpio_chips));
>>
> nr_chips?
>
You can't use nr_chips as it has been decremented to 0 in the for loop
above it.
--
Maurus Cuelenaere
WARNING: multiple messages have this Message-ID (diff)
From: mcuelenaere@gmail.com (Maurus Cuelenaere)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/15] ARM: S5PC100: Use common functions for gpiolib implementation
Date: Mon, 17 May 2010 15:59:41 +0200 [thread overview]
Message-ID: <4BF14BCD.3050500@gmail.com> (raw)
In-Reply-To: <003201caf5b2$2d641d00$882c5700$%kim@samsung.com>
Op 17-05-10 13:14, Kukjin Kim schreef:
> Marek Szyprowski wrote:
>
> <snip>
>> -
>> static __init int s5pc1xx_gpiolib_init(void)
>> {
>> - struct s3c_gpio_chip *chips;
>> + struct s3c_gpio_chip *chip;
>> int nr_chips;
>>
>> - chips = s5pc100_gpio_chips;
>> - nr_chips = ARRAY_SIZE(s5pc100_gpio_chips);
>> + chip = s5pc100_gpio_chips;
>> + nr_chips = ARRAY_SIZE(s5pc100_gpio_chips);
>> +
>> + for (; nr_chips > 0; nr_chips--, chip++)
>> + s5pc100_gpiolib_link(chip);
>>
>> - s5pc1xx_gpiolib_add(chips, nr_chips, s5pc1xx_gpiolib_link);
>> + samsung_gpiolib_add_4bit_chips(s5pc100_gpio_chips,
>> + ARRAY_SIZE(s5pc100_gpio_chips));
>>
> nr_chips?
>
You can't use nr_chips as it has been decremented to 0 in the for loop
above it.
--
Maurus Cuelenaere
next prev parent reply other threads:[~2010-05-17 13:59 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 6:18 [PATCH v2] ARM: Samsung: S5PC100 platform cleanup Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-14 6:18 ` [PATCH 01/15] ARM: Samsung: fix broken timer irq base Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:52 ` Kukjin Kim
2010-05-17 11:52 ` Kukjin Kim
2010-05-18 4:57 ` Ben Dooks
2010-05-18 4:57 ` Ben Dooks
2010-05-14 6:18 ` [PATCH 02/15] ARM: Samsung: move common I2C0 device helpers to machine directories Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 13:23 ` Kukjin Kim
2010-05-17 13:23 ` Kukjin Kim
2010-05-14 6:18 ` [PATCH 03/15] ARM: Samsung: move driver strength gpio configuration helper to common dir Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-14 6:18 ` [PATCH 04/15] drivers: serial: S5PC100 serial driver cleanup Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:14 ` Kukjin Kim
2010-05-17 11:14 ` Kukjin Kim
2010-05-14 6:18 ` [PATCH 05/15] ARM: S5PC100: Use common functions for gpiolib implementation Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:14 ` Kukjin Kim
2010-05-17 11:14 ` Kukjin Kim
2010-05-17 13:59 ` Maurus Cuelenaere [this message]
2010-05-17 13:59 ` Maurus Cuelenaere
2010-05-14 6:18 ` [PATCH 06/15] ARM: S5PC100: Move gpio support from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:24 ` Kukjin Kim
2010-05-17 11:24 ` Kukjin Kim
2010-05-18 9:38 ` Marek Szyprowski
2010-05-18 9:38 ` Marek Szyprowski
2010-05-14 6:18 ` [PATCH 07/15] ARM: S5PC100: rename gpio registers from s5pc1xx to s5pc100 Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 11:48 ` Kukjin Kim
2010-05-17 11:48 ` Kukjin Kim
2010-05-14 6:18 ` [PATCH 08/15] ARM: S5PC100: Move frame buffer helpers from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-14 6:18 ` Marek Szyprowski
2010-05-17 13:45 ` Kukjin Kim
2010-05-17 13:45 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 09/15] ARM: S5PC100: Move i2c " Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-17 13:00 ` Kukjin Kim
2010-05-17 13:00 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 10/15] ARM: S5PC100: Move sdhci " Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-17 12:45 ` Kukjin Kim
2010-05-17 12:45 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 11/15] ARM: Samsung: move S5PC100 support from plat-s5pc1xx to plat-s5p framework Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-14 6:19 ` [PATCH 12/15] ARM: SMDKC100: fix frame buffer definitions Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-17 13:36 ` Kukjin Kim
2010-05-17 13:36 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 13/15] ARM: Samsung: Move external interrupts support from plat-s5pc1xx to plat-s5p Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-17 13:28 ` Kukjin Kim
2010-05-17 13:28 ` Kukjin Kim
2010-05-14 6:19 ` [PATCH 14/15] ARM: S5PC100: Add support for gpio interrupt Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
2010-05-14 6:19 ` [PATCH 15/15] ARM: remove obsolete plat-s5pc1xx directory Marek Szyprowski
2010-05-14 6:19 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF14BCD.3050500@gmail.com \
--to=mcuelenaere@gmail.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.