From: Jarkko Nikula <jhnikula@gmail.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Tony Lindgren <tony@atomide.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API
Date: Wed, 19 May 2010 08:22:45 +0300 [thread overview]
Message-ID: <20100519082245.b51fc5bc.jhnikula@gmail.com> (raw)
In-Reply-To: <1274213594-26554-3-git-send-email-lrg@slimlogic.co.uk>
On Tue, 18 May 2010 21:13:12 +0100
Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> Add a small API to configure McBSP smart idle modes
> to conserve power.
>
> Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
> ---
> arch/arm/plat-omap/include/plat/mcbsp.h | 15 ++++
> arch/arm/plat-omap/mcbsp.c | 122 +++++++++++++++++++++++++++++++
> 2 files changed, 137 insertions(+), 0 deletions(-)
>
> +#define MCBSP_IDLE_FORCE 0
> +#define MCBSP_IDLE_NONE 1
> +#define MCBSP_IDLE_SMART 2
> +
...
> +int omap_mcbsp_set_idle_smart(unsigned int id, unsigned int clk_activity,
> + unsigned int wake);
> +int omap_mcbsp_set_idle_none(unsigned int id);
> +int omap_mcbsp_set_idle_force(unsigned int id);
> +int omap_mcbsp_get_idle_mode(unsigned int id);
Only minor comment but IMO single set function looks better. E.g.
omap_mcbsp_set_idle_mode(unsigned int id, int mode);
--
Jarkko
next prev parent reply other threads:[~2010-05-19 5:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 20:13 [PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC Liam Girdwood
2010-05-18 20:13 ` [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode() Liam Girdwood
2010-05-19 6:13 ` Jarkko Nikula
2010-05-19 10:50 ` Eduardo Valentin
2010-05-19 11:30 ` Liam Girdwood
2010-05-18 20:13 ` [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API Liam Girdwood
2010-05-18 20:42 ` Nishanth Menon
2010-05-18 23:01 ` [alsa-devel] " Kevin Hilman
2010-05-19 10:43 ` Liam Girdwood
2010-05-19 12:15 ` Peter Ujfalusi
2010-05-19 15:33 ` Kevin Hilman
2010-05-19 5:22 ` Jarkko Nikula [this message]
2010-05-19 10:46 ` Eduardo Valentin
2010-05-19 11:21 ` [alsa-devel] " Liam Girdwood
2010-05-19 11:31 ` Eduardo Valentin
2010-05-18 20:13 ` [PATCH 3/4] ASoC: mcbsp - add machine threshold callback Liam Girdwood
2010-05-18 20:38 ` Mark Brown
2010-05-18 20:56 ` Candelaria Villarreal, Jorge
2010-05-19 5:45 ` Jarkko Nikula
2010-05-19 9:37 ` [alsa-devel] " Liam Girdwood
2010-05-18 20:13 ` [PATCH 4/4] OMAP: mcbsp - remove sysfs set for DMA op mode Liam Girdwood
2010-05-19 5:13 ` [PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC Jarkko Nikula
2010-05-19 8:31 ` Peter Ujfalusi
2010-05-19 8:37 ` Peter Ujfalusi
2010-05-19 10:52 ` Eduardo Valentin
2010-05-19 11:36 ` Peter Ujfalusi
2010-05-19 11:46 ` Eduardo Valentin
2010-05-19 12:09 ` Peter Ujfalusi
2010-05-19 10:42 ` Eduardo Valentin
2010-05-19 11:07 ` Liam Girdwood
2010-05-19 11:28 ` Eduardo Valentin
2010-05-19 12:27 ` Peter Ujfalusi
2010-05-19 14:50 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519082245.b51fc5bc.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.