From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: ext Liam Girdwood <lrg@slimlogic.co.uk>,
"Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC
Date: Wed, 19 May 2010 17:50:05 +0300 [thread overview]
Message-ID: <20100519175005.0e702bdd.jhnikula@gmail.com> (raw)
In-Reply-To: <201005191527.35439.peter.ujfalusi@nokia.com>
On Wed, 19 May 2010 15:27:35 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> > The sysfs set interface implies userspace having knowledge of driver
> > capabilities and configuration in order to safely toggle between the two
> > DMA modes. Imo, the mcbsp client driver should be the only entity
> > configuring it's DMA modes (in a safe manner) depending on the use case.
>
> Furthermore, if there is a need for 'Use Cases', than the machine driver can
> provide user control to switch between them.
> The thing is that in most cases these are trivial, and mostly the same settings,
> but if you throw a codec like the tlv320dac33 into the mix, which has it's own
> FIFO, than things gets complicated.
> The user (the real one, not the developer) has several settings scattered all
> around the place, and those has to be configured in harmony.
> The only place is to do this, is in the machine driver, whihc than can build up
> 'scenarios', and configure the things in synchronized manner.
>
Yes and I think only very few developers know what to do with those op
mode and threshold sysfs controls so most probably they are unused.
Then machine drivers setting them automatically/with some control could
give us more testing base.
But as those sysfs controls are there we must preserve them for a
release cycle or two in case if someone is using them. At least Linus
or Andrew may complain about removal of them.
--
Jarkko
prev parent reply other threads:[~2010-05-19 14:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 20:13 [PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC Liam Girdwood
2010-05-18 20:13 ` [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode() Liam Girdwood
2010-05-19 6:13 ` Jarkko Nikula
2010-05-19 10:50 ` Eduardo Valentin
2010-05-19 11:30 ` Liam Girdwood
2010-05-18 20:13 ` [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API Liam Girdwood
2010-05-18 20:42 ` Nishanth Menon
2010-05-18 23:01 ` [alsa-devel] " Kevin Hilman
2010-05-19 10:43 ` Liam Girdwood
2010-05-19 12:15 ` Peter Ujfalusi
2010-05-19 15:33 ` Kevin Hilman
2010-05-19 5:22 ` Jarkko Nikula
2010-05-19 10:46 ` Eduardo Valentin
2010-05-19 11:21 ` [alsa-devel] " Liam Girdwood
2010-05-19 11:31 ` Eduardo Valentin
2010-05-18 20:13 ` [PATCH 3/4] ASoC: mcbsp - add machine threshold callback Liam Girdwood
2010-05-18 20:38 ` Mark Brown
2010-05-18 20:56 ` Candelaria Villarreal, Jorge
2010-05-19 5:45 ` Jarkko Nikula
2010-05-19 9:37 ` [alsa-devel] " Liam Girdwood
2010-05-18 20:13 ` [PATCH 4/4] OMAP: mcbsp - remove sysfs set for DMA op mode Liam Girdwood
2010-05-19 5:13 ` [PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC Jarkko Nikula
2010-05-19 8:31 ` Peter Ujfalusi
2010-05-19 8:37 ` Peter Ujfalusi
2010-05-19 10:52 ` Eduardo Valentin
2010-05-19 11:36 ` Peter Ujfalusi
2010-05-19 11:46 ` Eduardo Valentin
2010-05-19 12:09 ` Peter Ujfalusi
2010-05-19 10:42 ` Eduardo Valentin
2010-05-19 11:07 ` Liam Girdwood
2010-05-19 11:28 ` Eduardo Valentin
2010-05-19 12:27 ` Peter Ujfalusi
2010-05-19 14:50 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519175005.0e702bdd.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.