Re: [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API

[Kevin Hilman <khilman@deeprootsystems.com>]

Liam Girdwood <lrg@slimlogic.co.uk> writes:

> On Tue, 2010-05-18 at 16:01 -0700, Kevin Hilman wrote:
>> Liam Girdwood <lrg@slimlogic.co.uk> writes:
>> 
>> > Add a small API to configure McBSP smart idle modes
>> > to conserve power.
>> 
>> Would be useful here to explain why client drivers need to change
>> idle modes.
>> 
>
> I think Peter has covered this in one of his replies.
>
>> Also, this patch is telling me that it's time the McBSP is converted
>> over to the omap_hwmod/omap_device infrastructure where this type
>> of functionality would already be provided.
>> 
>> Not necesssarily a reason to prevent this patch for now, but this
>> will all need to be changed when converted to hwmod.
>
> Ok, I think I'll actually just convert it to hwmod rather than adding a
> soon to be deprecated API.

Excellent, that would certainly be my preference.

For reference, you can check out the pm-wip/uart and pm-wip/mmc
branches of my tree[1] for some hwmod conversions for UART and MMC
that are in progress.

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git