* [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. @ 2010-05-14 21:53 Jorge Pereira 2010-05-15 18:57 ` Jorge Pereira 0 siblings, 1 reply; 6+ messages in thread From: Jorge Pereira @ 2010-05-14 21:53 UTC (permalink / raw) To: Kernel - PlatformDriver-x86 [-- Attachment #1: Type: text/plain, Size: 627 bytes --] Hi! Recently i bought the sony laptop model 'VPCEB15FB' and this model has Three buttons top of keyboard[1] that don't work until then. added support to all three keys at the driver sony-laptop.c and sonypi.h Atc, if you have something wrong, I would be grateful if someone helps. [1] Same family of http://www.sonystyle.com/webapp/wcs/stores/servlet/CategoryDisplay?catalogId=10551&storeId=10151&langId=-1&categoryId=8198552921644699998&N=4294953240 Thanks, -- Regards, +--------------------------------------------+ Jorge Pereira, Blog: http://blog.jorgepereira.com.br/ +--------------------------------------------+ [-- Attachment #2: 0001-Adding-support-for-new-keys-ASSIST-WEB-and-VAIO-of-t.patch --] [-- Type: text/x-patch, Size: 2433 bytes --] From d2c812270bfce82da57a88c40f43a7eea42ba1f2 Mon Sep 17 00:00:00 2001 From: Jorge Pereira <jpereiran@gmail.com> Date: Fri, 14 May 2010 18:18:19 -0300 Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. --- drivers/platform/x86/sony-laptop.c | 12 ++++++++++++ include/linux/sonypi.h | 3 +++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c index a2a742c..d432b08 100644 --- a/drivers/platform/x86/sony-laptop.c +++ b/drivers/platform/x86/sony-laptop.c @@ -232,6 +232,9 @@ static int sony_laptop_input_index[] = { 56, /* 69 SONYPI_EVENT_VOLUME_INC_PRESSED */ 57, /* 70 SONYPI_EVENT_VOLUME_DEC_PRESSED */ -1, /* 71 SONYPI_EVENT_BRIGHTNESS_PRESSED */ + 58, /* 72 SONYPI_EVENT_DEDICATED_SUPPORT */ + 59, /* 73 SONYPI_EVENT_DEDICATED_WEB */ + 60, /* 74 SONYPI_EVENT_DEDICATED_VAIO */ }; static int sony_laptop_input_keycode_map[] = { @@ -293,6 +296,9 @@ static int sony_laptop_input_keycode_map[] = { KEY_F15, /* 55 SONYPI_EVENT_SETTINGKEY_PRESSED */ KEY_VOLUMEUP, /* 56 SONYPI_EVENT_VOLUME_INC_PRESSED */ KEY_VOLUMEDOWN, /* 57 SONYPI_EVENT_VOLUME_DEC_PRESSED */ + KEY_HELP, /* 58 SONYPI_EVENT_DEDICATED_SUPPORT */ + KEY_HOMEPAGE, /* 59 SONYPI_EVENT_DEDICATED_WEB */ + KEY_SHOP, /* 60 SONYPI_EVENT_DEDICATED_VAIO */ }; /* release buttons after a short delay if pressed */ @@ -890,6 +896,12 @@ static struct sony_nc_event sony_100_events[] = { { 0x0C, SONYPI_EVENT_FNKEY_RELEASED }, { 0x9f, SONYPI_EVENT_CD_EJECT_PRESSED }, { 0x1f, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa4, SONYPI_EVENT_DEDICATED_WEB }, + { 0x24, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa5, SONYPI_EVENT_DEDICATED_VAIO }, + { 0x25, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa6, SONYPI_EVENT_DEDICATED_SUPPORT }, + { 0x26, SONYPI_EVENT_ANYBUTTON_RELEASED }, { 0, 0 }, }; diff --git a/include/linux/sonypi.h b/include/linux/sonypi.h index 34c4475..d1ebb02 100644 --- a/include/linux/sonypi.h +++ b/include/linux/sonypi.h @@ -111,6 +111,9 @@ #define SONYPI_EVENT_VOLUME_INC_PRESSED 69 #define SONYPI_EVENT_VOLUME_DEC_PRESSED 70 #define SONYPI_EVENT_BRIGHTNESS_PRESSED 71 +#define SONYPI_EVENT_DEDICATED_SUPPORT 72 +#define SONYPI_EVENT_DEDICATED_WEB 73 +#define SONYPI_EVENT_DEDICATED_VAIO 74 /* get/set brightness */ #define SONYPI_IOCGBRT _IOR('v', 0, __u8) -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. 2010-05-14 21:53 [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series Jorge Pereira @ 2010-05-15 18:57 ` Jorge Pereira 2010-05-16 6:36 ` Jorge Pereira 0 siblings, 1 reply; 6+ messages in thread From: Jorge Pereira @ 2010-05-15 18:57 UTC (permalink / raw) To: Kernel - PlatformDriver-x86; +Cc: Mattia Dongili, Mattia Dongili Hi! Recently i bought the sony laptop model 'VPCEB15FB' and this model has Three buttons top of keyboard[1] that don't work until then. added support to all three keys at the driver sony-laptop.c and sonypi.h Atc, if you have something wrong, I would be grateful if someone helps. [1] Same family of http://www.sonystyle.com/webapp/wcs/stores/servlet/CategoryDisplay?catalogId=10551&storeId=10151&langId=-1&categoryId=8198552921644699998&N=4294953240 Thanks, -- Regards, +--------------------------------------------+ Jorge Pereira, Blog: http://blog.jorgepereira.com.br/ +--------------------------------------------+ ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. 2010-05-15 18:57 ` Jorge Pereira @ 2010-05-16 6:36 ` Jorge Pereira 2010-05-17 22:19 ` Mattia Dongili 0 siblings, 1 reply; 6+ messages in thread From: Jorge Pereira @ 2010-05-16 6:36 UTC (permalink / raw) To: Kernel - PlatformDriver-x86; +Cc: Mattia Dongili, Mattia Dongili [-- Attachment #1: Type: text/plain, Size: 626 bytes --] Hi! Recently i bought the sony laptop model 'VPCEB15FB' and this model has Three buttons top of keyboard[1] that don't work until then. added support to all three keys at the driver sony-laptop.c and sonypi.h Atc, if you have something wrong, I would be grateful if someone helps. [1] Same family of http://www.sonystyle.com/webapp/wcs/stores/servlet/CategoryDisplay?catalogId=10551&storeId=10151&langId=-1&categoryId=8198552921644699998&N=4294953240 Thanks, -- Regards, +--------------------------------------------+ Jorge Pereira, Blog: http://blog.jorgepereira.com.br/ +--------------------------------------------+ [-- Attachment #2: 0001-Adding-support-for-new-keys-ASSIST-WEB-and-VAIO-of-t.patch --] [-- Type: text/x-patch, Size: 2433 bytes --] From d2c812270bfce82da57a88c40f43a7eea42ba1f2 Mon Sep 17 00:00:00 2001 From: Jorge Pereira <jpereiran@gmail.com> Date: Fri, 14 May 2010 18:18:19 -0300 Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. --- drivers/platform/x86/sony-laptop.c | 12 ++++++++++++ include/linux/sonypi.h | 3 +++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c index a2a742c..d432b08 100644 --- a/drivers/platform/x86/sony-laptop.c +++ b/drivers/platform/x86/sony-laptop.c @@ -232,6 +232,9 @@ static int sony_laptop_input_index[] = { 56, /* 69 SONYPI_EVENT_VOLUME_INC_PRESSED */ 57, /* 70 SONYPI_EVENT_VOLUME_DEC_PRESSED */ -1, /* 71 SONYPI_EVENT_BRIGHTNESS_PRESSED */ + 58, /* 72 SONYPI_EVENT_DEDICATED_SUPPORT */ + 59, /* 73 SONYPI_EVENT_DEDICATED_WEB */ + 60, /* 74 SONYPI_EVENT_DEDICATED_VAIO */ }; static int sony_laptop_input_keycode_map[] = { @@ -293,6 +296,9 @@ static int sony_laptop_input_keycode_map[] = { KEY_F15, /* 55 SONYPI_EVENT_SETTINGKEY_PRESSED */ KEY_VOLUMEUP, /* 56 SONYPI_EVENT_VOLUME_INC_PRESSED */ KEY_VOLUMEDOWN, /* 57 SONYPI_EVENT_VOLUME_DEC_PRESSED */ + KEY_HELP, /* 58 SONYPI_EVENT_DEDICATED_SUPPORT */ + KEY_HOMEPAGE, /* 59 SONYPI_EVENT_DEDICATED_WEB */ + KEY_SHOP, /* 60 SONYPI_EVENT_DEDICATED_VAIO */ }; /* release buttons after a short delay if pressed */ @@ -890,6 +896,12 @@ static struct sony_nc_event sony_100_events[] = { { 0x0C, SONYPI_EVENT_FNKEY_RELEASED }, { 0x9f, SONYPI_EVENT_CD_EJECT_PRESSED }, { 0x1f, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa4, SONYPI_EVENT_DEDICATED_WEB }, + { 0x24, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa5, SONYPI_EVENT_DEDICATED_VAIO }, + { 0x25, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa6, SONYPI_EVENT_DEDICATED_SUPPORT }, + { 0x26, SONYPI_EVENT_ANYBUTTON_RELEASED }, { 0, 0 }, }; diff --git a/include/linux/sonypi.h b/include/linux/sonypi.h index 34c4475..d1ebb02 100644 --- a/include/linux/sonypi.h +++ b/include/linux/sonypi.h @@ -111,6 +111,9 @@ #define SONYPI_EVENT_VOLUME_INC_PRESSED 69 #define SONYPI_EVENT_VOLUME_DEC_PRESSED 70 #define SONYPI_EVENT_BRIGHTNESS_PRESSED 71 +#define SONYPI_EVENT_DEDICATED_SUPPORT 72 +#define SONYPI_EVENT_DEDICATED_WEB 73 +#define SONYPI_EVENT_DEDICATED_VAIO 74 /* get/set brightness */ #define SONYPI_IOCGBRT _IOR('v', 0, __u8) -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. 2010-05-16 6:36 ` Jorge Pereira @ 2010-05-17 22:19 ` Mattia Dongili 2010-05-18 6:56 ` Jorge Pereira 0 siblings, 1 reply; 6+ messages in thread From: Mattia Dongili @ 2010-05-17 22:19 UTC (permalink / raw) To: Jorge Pereira; +Cc: Kernel - PlatformDriver-x86 Hi Jorge On Sun, May 16, 2010 at 03:36:52AM -0300, Jorge Pereira wrote: > Hi! > > Recently i bought the sony laptop model 'VPCEB15FB' and this model > has Three buttons top of keyboard[1] that don't work until then. > added support to all three keys at the driver sony-laptop.c and sonypi.h Thanks for the patch, it's fundamentally ok but to be honest I'm not too convinced about the naming. I'm not sure how "dedicated" the Web will be after you pressed the DEDICATED_WEB button. :) Also, you seem to have patched an old version of the driver, please make sure the patch applies on current code. See a couple of comments below. ... > From d2c812270bfce82da57a88c40f43a7eea42ba1f2 Mon Sep 17 00:00:00 2001 > From: Jorge Pereira <jpereiran@gmail.com> > Date: Fri, 14 May 2010 18:18:19 -0300 > Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. > > --- Please also Sign-off the patch in your commit log. ... > + 58, /* 72 SONYPI_EVENT_DEDICATED_SUPPORT */ > + 59, /* 73 SONYPI_EVENT_DEDICATED_WEB */ > + 60, /* 74 SONYPI_EVENT_DEDICATED_VAIO */ Can't these just be SONYPY_EVENT_ASSIST_PRESSED, SONYPI_EVENT_WEB_PRESSED and SONYPI_EVENT_VAIO_PRESSED? If necessary you can describe what they were originally inteded to in the commit message. Thanks! -- mattia :wq! ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. 2010-05-17 22:19 ` Mattia Dongili @ 2010-05-18 6:56 ` Jorge Pereira 2010-05-19 22:48 ` Mattia Dongili 0 siblings, 1 reply; 6+ messages in thread From: Jorge Pereira @ 2010-05-18 6:56 UTC (permalink / raw) To: Mattia Dongili; +Cc: Kernel - PlatformDriver-x86 [-- Attachment #1: Type: text/plain, Size: 1770 bytes --] Hi Mattia, Great, agree with yours comments and following the new patch. thanks. -- Regards, +--------------------------------------------+ Jorge Pereira, Blog: http://blog.jorgepereira.com.br/ +--------------------------------------------+ On Mon, May 17, 2010 at 7:19 PM, Mattia Dongili <malattia@linux.it> wrote: > Hi Jorge > > On Sun, May 16, 2010 at 03:36:52AM -0300, Jorge Pereira wrote: >> Hi! >> >> Recently i bought the sony laptop model 'VPCEB15FB' and this model >> has Three buttons top of keyboard[1] that don't work until then. >> added support to all three keys at the driver sony-laptop.c and sonypi.h > > Thanks for the patch, it's fundamentally ok but to be honest I'm not too > convinced about the naming. I'm not sure how "dedicated" the Web will > be after you pressed the DEDICATED_WEB button. :) > Also, you seem to have patched an old version of the driver, please > make sure the patch applies on current code. > > See a couple of comments below. > > ... >> From d2c812270bfce82da57a88c40f43a7eea42ba1f2 Mon Sep 17 00:00:00 2001 >> From: Jorge Pereira <jpereiran@gmail.com> >> Date: Fri, 14 May 2010 18:18:19 -0300 >> Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. >> >> --- > > Please also Sign-off the patch in your commit log. > > ... >> + 58, /* 72 SONYPI_EVENT_DEDICATED_SUPPORT */ >> + 59, /* 73 SONYPI_EVENT_DEDICATED_WEB */ >> + 60, /* 74 SONYPI_EVENT_DEDICATED_VAIO */ > > Can't these just be SONYPY_EVENT_ASSIST_PRESSED, > SONYPI_EVENT_WEB_PRESSED and SONYPI_EVENT_VAIO_PRESSED? > If necessary you can describe what they were originally inteded to in > the commit message. > > Thanks! > -- > mattia > :wq! > [-- Attachment #2: 0001-Adding-support-for-new-keys-ASSIST-WEB-and-VAIO-of-t.patch --] [-- Type: text/x-patch, Size: 2392 bytes --] From 5b8ef2e688b64427afb82243a80af8822e063112 Mon Sep 17 00:00:00 2001 From: Jorge Pereira <jpereiran@gmail.com> Date: Tue, 18 May 2010 03:56:04 -0300 Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. --- drivers/platform/x86/sony-laptop.c | 12 ++++++++++++ include/linux/sonypi.h | 3 +++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c index 1387c5f..3580ca4 100644 --- a/drivers/platform/x86/sony-laptop.c +++ b/drivers/platform/x86/sony-laptop.c @@ -235,6 +235,9 @@ static int sony_laptop_input_index[] = { 57, /* 70 SONYPI_EVENT_VOLUME_DEC_PRESSED */ -1, /* 71 SONYPI_EVENT_BRIGHTNESS_PRESSED */ 58, /* 72 SONYPI_EVENT_MEDIA_PRESSED */ + 59, /* 73 SONYPI_EVENT_ASSIST_PRESSED */ + 60, /* 74 SONYPI_EVENT_WEB_PRESSED */ + 61, /* 75 SONYPI_EVENT_VAIO_PRESSED */ }; static int sony_laptop_input_keycode_map[] = { @@ -297,6 +300,9 @@ static int sony_laptop_input_keycode_map[] = { KEY_VOLUMEUP, /* 56 SONYPI_EVENT_VOLUME_INC_PRESSED */ KEY_VOLUMEDOWN, /* 57 SONYPI_EVENT_VOLUME_DEC_PRESSED */ KEY_MEDIA, /* 58 SONYPI_EVENT_MEDIA_PRESSED */ + KEY_HELP, /* 59 SONYPI_EVENT_ASSIST_PRESSED */ + KEY_HOMEPAGE, /* 60 SONYPI_EVENT_WEB_PRESSED */ + KEY_SHOP, /* 61 SONYPI_EVENT_VAIO_PRESSED */ }; /* release buttons after a short delay if pressed */ @@ -899,6 +905,12 @@ static struct sony_nc_event sony_100_events[] = { { 0x1f, SONYPI_EVENT_ANYBUTTON_RELEASED }, { 0xa1, SONYPI_EVENT_MEDIA_PRESSED }, { 0x21, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa4, SONYPI_EVENT_WEB_PRESSED }, + { 0x24, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa5, SONYPI_EVENT_VAIO_PRESSED }, + { 0x25, SONYPI_EVENT_ANYBUTTON_RELEASED }, + { 0xa6, SONYPI_EVENT_ASSIST_PRESSED }, + { 0x26, SONYPI_EVENT_ANYBUTTON_RELEASED }, { 0, 0 }, }; diff --git a/include/linux/sonypi.h b/include/linux/sonypi.h index 4f95c1a..55369d8 100644 --- a/include/linux/sonypi.h +++ b/include/linux/sonypi.h @@ -112,6 +112,9 @@ #define SONYPI_EVENT_VOLUME_DEC_PRESSED 70 #define SONYPI_EVENT_BRIGHTNESS_PRESSED 71 #define SONYPI_EVENT_MEDIA_PRESSED 72 +#define SONYPI_EVENT_ASSIST_PRESSED 73 +#define SONYPI_EVENT_WEB_PRESSED 74 +#define SONYPI_EVENT_VAIO_PRESSED 75 /* get/set brightness */ #define SONYPI_IOCGBRT _IOR('v', 0, __u8) -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. 2010-05-18 6:56 ` Jorge Pereira @ 2010-05-19 22:48 ` Mattia Dongili 0 siblings, 0 replies; 6+ messages in thread From: Mattia Dongili @ 2010-05-19 22:48 UTC (permalink / raw) To: Jorge Pereira; +Cc: Kernel - PlatformDriver-x86 On Tue, May 18, 2010 at 03:56:43AM -0300, Jorge Pereira wrote: > Hi Mattia, Hi Jorge, ... > From 5b8ef2e688b64427afb82243a80af8822e063112 Mon Sep 17 00:00:00 2001 > From: Jorge Pereira <jpereiran@gmail.com> > Date: Tue, 18 May 2010 03:56:04 -0300 > Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series. > Still missing your sign-off line, see Documentation/SubmittingPatches > --- > drivers/platform/x86/sony-laptop.c | 12 ++++++++++++ > include/linux/sonypi.h | 3 +++ > 2 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c > index 1387c5f..3580ca4 100644 > --- a/drivers/platform/x86/sony-laptop.c > +++ b/drivers/platform/x86/sony-laptop.c > @@ -235,6 +235,9 @@ static int sony_laptop_input_index[] = { > 57, /* 70 SONYPI_EVENT_VOLUME_DEC_PRESSED */ > -1, /* 71 SONYPI_EVENT_BRIGHTNESS_PRESSED */ > 58, /* 72 SONYPI_EVENT_MEDIA_PRESSED */ > + 59, /* 73 SONYPI_EVENT_ASSIST_PRESSED */ > + 60, /* 74 SONYPI_EVENT_WEB_PRESSED */ > + 61, /* 75 SONYPI_EVENT_VAIO_PRESSED */ > }; and while we are at it, would you mind indenting those comments like the previous ones are with at tab? (sorry for not mentioning it before) > > static int sony_laptop_input_keycode_map[] = { > @@ -297,6 +300,9 @@ static int sony_laptop_input_keycode_map[] = { > KEY_VOLUMEUP, /* 56 SONYPI_EVENT_VOLUME_INC_PRESSED */ > KEY_VOLUMEDOWN, /* 57 SONYPI_EVENT_VOLUME_DEC_PRESSED */ > KEY_MEDIA, /* 58 SONYPI_EVENT_MEDIA_PRESSED */ > + KEY_HELP, /* 59 SONYPI_EVENT_ASSIST_PRESSED */ > + KEY_HOMEPAGE, /* 60 SONYPI_EVENT_WEB_PRESSED */ > + KEY_SHOP, /* 61 SONYPI_EVENT_VAIO_PRESSED */ > }; ditto thanks -- mattia :wq! ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-19 22:48 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-05-14 21:53 [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series Jorge Pereira 2010-05-15 18:57 ` Jorge Pereira 2010-05-16 6:36 ` Jorge Pereira 2010-05-17 22:19 ` Mattia Dongili 2010-05-18 6:56 ` Jorge Pereira 2010-05-19 22:48 ` Mattia Dongili
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.