All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 04/11] hwmon: Storage class should be
Date: Thu, 20 May 2010 09:06:48 +0000	[thread overview]
Message-ID: <20100520110648.49116879@hyperion.delvare> (raw)
In-Reply-To: <1274344488-8918-1-git-send-email-tklauser@distanz.ch>

Hi Tobias,

On Thu, 20 May 2010 10:34:48 +0200, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
> 
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  drivers/hwmon/emc1403.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> index 28cca34..0e4b564 100644
> --- a/drivers/hwmon/emc1403.c
> +++ b/drivers/hwmon/emc1403.c
> @@ -308,7 +308,7 @@ static const unsigned short emc1403_address_list[] = {
>  	0x18, 0x2a, 0x4c, 0x4d, I2C_CLIENT_END
>  };
>  
> -const static struct i2c_device_id emc1403_idtable[] = {
> +static const struct i2c_device_id emc1403_idtable[] = {
>  	{ "emc1403", 0 },
>  	{ }
>  };

Good catch. I've folded your fix into the original patch, as it isn't
upstream yet.

Could this error be caught by checkpatch.pl in the future? It seems
easy enough to identify, and would save you the manual work.

-- 
Jean Delvare

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 04/11] hwmon: Storage class should be
Date: Thu, 20 May 2010 09:06:48 +0000	[thread overview]
Message-ID: <20100520110648.49116879@hyperion.delvare> (raw)
In-Reply-To: <1274344488-8918-1-git-send-email-tklauser@distanz.ch>

Hi Tobias,

On Thu, 20 May 2010 10:34:48 +0200, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
> 
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  drivers/hwmon/emc1403.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> index 28cca34..0e4b564 100644
> --- a/drivers/hwmon/emc1403.c
> +++ b/drivers/hwmon/emc1403.c
> @@ -308,7 +308,7 @@ static const unsigned short emc1403_address_list[] = {
>  	0x18, 0x2a, 0x4c, 0x4d, I2C_CLIENT_END
>  };
>  
> -const static struct i2c_device_id emc1403_idtable[] = {
> +static const struct i2c_device_id emc1403_idtable[] = {
>  	{ "emc1403", 0 },
>  	{ }
>  };

Good catch. I've folded your fix into the original patch, as it isn't
upstream yet.

Could this error be caught by checkpatch.pl in the future? It seems
easy enough to identify, and would save you the manual work.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2010-05-20  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-20  8:34 [PATCH 04/11] hwmon: Storage class should be before const qualifier Tobias Klauser
2010-05-20  8:34 ` [lm-sensors] [PATCH 04/11] hwmon: Storage class should be before Tobias Klauser
2010-05-20  9:06 ` Jean Delvare [this message]
2010-05-20  9:06   ` [lm-sensors] [PATCH 04/11] hwmon: Storage class should be Jean Delvare
2010-05-20  9:11 ` Tobias Klauser
2010-05-20  9:11   ` [lm-sensors] [PATCH 04/11] hwmon: Storage class should Tobias Klauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100520110648.49116879@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.