* [PATCH 04/11] hwmon: Storage class should be before const qualifier
@ 2010-05-20 8:34 ` Tobias Klauser
0 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2010-05-20 8:34 UTC (permalink / raw)
To: kernel-janitors
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/hwmon/emc1403.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
index 28cca34..0e4b564 100644
--- a/drivers/hwmon/emc1403.c
+++ b/drivers/hwmon/emc1403.c
@@ -308,7 +308,7 @@ static const unsigned short emc1403_address_list[] = {
0x18, 0x2a, 0x4c, 0x4d, I2C_CLIENT_END
};
-const static struct i2c_device_id emc1403_idtable[] = {
+static const struct i2c_device_id emc1403_idtable[] = {
{ "emc1403", 0 },
{ }
};
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [lm-sensors] [PATCH 04/11] hwmon: Storage class should be before
@ 2010-05-20 8:34 ` Tobias Klauser
0 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2010-05-20 8:34 UTC (permalink / raw)
To: kernel-janitors
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/hwmon/emc1403.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
index 28cca34..0e4b564 100644
--- a/drivers/hwmon/emc1403.c
+++ b/drivers/hwmon/emc1403.c
@@ -308,7 +308,7 @@ static const unsigned short emc1403_address_list[] = {
0x18, 0x2a, 0x4c, 0x4d, I2C_CLIENT_END
};
-const static struct i2c_device_id emc1403_idtable[] = {
+static const struct i2c_device_id emc1403_idtable[] = {
{ "emc1403", 0 },
{ }
};
--
1.6.3.3
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH 04/11] hwmon: Storage class should be
2010-05-20 8:34 ` [lm-sensors] [PATCH 04/11] hwmon: Storage class should be before Tobias Klauser
@ 2010-05-20 9:06 ` Jean Delvare
-1 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2010-05-20 9:06 UTC (permalink / raw)
To: kernel-janitors
Hi Tobias,
On Thu, 20 May 2010 10:34:48 +0200, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> drivers/hwmon/emc1403.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> index 28cca34..0e4b564 100644
> --- a/drivers/hwmon/emc1403.c
> +++ b/drivers/hwmon/emc1403.c
> @@ -308,7 +308,7 @@ static const unsigned short emc1403_address_list[] = {
> 0x18, 0x2a, 0x4c, 0x4d, I2C_CLIENT_END
> };
>
> -const static struct i2c_device_id emc1403_idtable[] = {
> +static const struct i2c_device_id emc1403_idtable[] = {
> { "emc1403", 0 },
> { }
> };
Good catch. I've folded your fix into the original patch, as it isn't
upstream yet.
Could this error be caught by checkpatch.pl in the future? It seems
easy enough to identify, and would save you the manual work.
--
Jean Delvare
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH 04/11] hwmon: Storage class should be
@ 2010-05-20 9:06 ` Jean Delvare
0 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2010-05-20 9:06 UTC (permalink / raw)
To: kernel-janitors
Hi Tobias,
On Thu, 20 May 2010 10:34:48 +0200, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> drivers/hwmon/emc1403.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> index 28cca34..0e4b564 100644
> --- a/drivers/hwmon/emc1403.c
> +++ b/drivers/hwmon/emc1403.c
> @@ -308,7 +308,7 @@ static const unsigned short emc1403_address_list[] = {
> 0x18, 0x2a, 0x4c, 0x4d, I2C_CLIENT_END
> };
>
> -const static struct i2c_device_id emc1403_idtable[] = {
> +static const struct i2c_device_id emc1403_idtable[] = {
> { "emc1403", 0 },
> { }
> };
Good catch. I've folded your fix into the original patch, as it isn't
upstream yet.
Could this error be caught by checkpatch.pl in the future? It seems
easy enough to identify, and would save you the manual work.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH 04/11] hwmon: Storage class should be
2010-05-20 8:34 ` [lm-sensors] [PATCH 04/11] hwmon: Storage class should be before Tobias Klauser
@ 2010-05-20 9:11 ` Tobias Klauser
-1 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2010-05-20 9:11 UTC (permalink / raw)
To: kernel-janitors
Hi Jean,
On 2010-05-20 at 11:06:48 +0200, Jean Delvare <khali@linux-fr.org> wrote:
> On Thu, 20 May 2010 10:34:48 +0200, Tobias Klauser wrote:
> > The C99 specification states in section 6.11.5:
> >
> > The placement of a storage-class specifier other than at the beginning
> > of the declaration specifiers in a declaration is an obsolescent
> > feature.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > ---
> > drivers/hwmon/emc1403.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> > index 28cca34..0e4b564 100644
> > --- a/drivers/hwmon/emc1403.c
> > +++ b/drivers/hwmon/emc1403.c
> > @@ -308,7 +308,7 @@ static const unsigned short emc1403_address_list[] = {
> > 0x18, 0x2a, 0x4c, 0x4d, I2C_CLIENT_END
> > };
> >
> > -const static struct i2c_device_id emc1403_idtable[] = {
> > +static const struct i2c_device_id emc1403_idtable[] = {
> > { "emc1403", 0 },
> > { }
> > };
>
> Good catch. I've folded your fix into the original patch, as it isn't
> upstream yet.
>
> Could this error be caught by checkpatch.pl in the future? It seems
> easy enough to identify, and would save you the manual work.
I'll do that and submit a patch. Thanks for the suggestion.
Cheers Tobias
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH 04/11] hwmon: Storage class should
@ 2010-05-20 9:11 ` Tobias Klauser
0 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2010-05-20 9:11 UTC (permalink / raw)
To: kernel-janitors
Hi Jean,
On 2010-05-20 at 11:06:48 +0200, Jean Delvare <khali@linux-fr.org> wrote:
> On Thu, 20 May 2010 10:34:48 +0200, Tobias Klauser wrote:
> > The C99 specification states in section 6.11.5:
> >
> > The placement of a storage-class specifier other than at the beginning
> > of the declaration specifiers in a declaration is an obsolescent
> > feature.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > ---
> > drivers/hwmon/emc1403.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> > index 28cca34..0e4b564 100644
> > --- a/drivers/hwmon/emc1403.c
> > +++ b/drivers/hwmon/emc1403.c
> > @@ -308,7 +308,7 @@ static const unsigned short emc1403_address_list[] = {
> > 0x18, 0x2a, 0x4c, 0x4d, I2C_CLIENT_END
> > };
> >
> > -const static struct i2c_device_id emc1403_idtable[] = {
> > +static const struct i2c_device_id emc1403_idtable[] = {
> > { "emc1403", 0 },
> > { }
> > };
>
> Good catch. I've folded your fix into the original patch, as it isn't
> upstream yet.
>
> Could this error be caught by checkpatch.pl in the future? It seems
> easy enough to identify, and would save you the manual work.
I'll do that and submit a patch. Thanks for the suggestion.
Cheers Tobias
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-20 9:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-20 8:34 [PATCH 04/11] hwmon: Storage class should be before const qualifier Tobias Klauser
2010-05-20 8:34 ` [lm-sensors] [PATCH 04/11] hwmon: Storage class should be before Tobias Klauser
2010-05-20 9:06 ` [lm-sensors] [PATCH 04/11] hwmon: Storage class should be Jean Delvare
2010-05-20 9:06 ` Jean Delvare
2010-05-20 9:11 ` Tobias Klauser
2010-05-20 9:11 ` [lm-sensors] [PATCH 04/11] hwmon: Storage class should Tobias Klauser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.