[U-Boot] Support similar boards at same board file?

[U-Boot] Support similar boards at same board file?

[Minkyu Kang]

Dear Wolfgang,

I will post two boards "aquila" and "goni". (s5pc110 soc)
These board are very similar and can detect the board by gpio. (at runtime)
So, I want to support these two boards at same board file.
Thus, I will use same binary at two boards.

How you think?
Please give your opinion.

Thanks
Minkyu Kang
-- 
from. prom.
www.promsoft.net

[U-Boot] Support similar boards at same board file?

[Stefan Roese]

Hi Minkyu,

On Thursday 20 May 2010 10:46:43 Minkyu Kang wrote:
> I will post two boards "aquila" and "goni". (s5pc110 soc)
> These board are very similar and can detect the board by gpio. (at runtime)
> So, I want to support these two boards at same board file.
> Thus, I will use same binary at two boards.
> 
> How you think?
> Please give your opinion.

We usually don't want or even accept code duplications resulting from similar 
boards. So I definitely prefer such a runtime detection of the board type.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

[U-Boot] Support similar boards at same board file?

[Wolfgang Denk]

Dear Minkyu Kang,

In message <AANLkTikGitnfUE9UQZpgJW5GiTMrwylk6ASQbqQMllGc@mail.gmail.com> you wrote:
> 
> I will post two boards "aquila" and "goni". (s5pc110 soc)
> These board are very similar and can detect the board by gpio. (at runtime)
> So, I want to support these two boards at same board file.
> Thus, I will use same binary at two boards.

OK.

> How you think?
> Please give your opinion.

Sorry, but I fail to see a question?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nothing ever becomes real until it is experienced.       - John Keats

[U-Boot] Support similar boards at same board file?

[Minkyu Kang]

Dear Wolfgang,

On 20 May 2010 20:43, Wolfgang Denk <wd@denx.de> wrote:
> Dear Minkyu Kang,
>
> In message <AANLkTikGitnfUE9UQZpgJW5GiTMrwylk6ASQbqQMllGc@mail.gmail.com> you wrote:
>>
>> I will post two boards "aquila" and "goni". (s5pc110 soc)
>> These board are very similar and can detect the board by gpio. (at runtime)
>> So, I want to support these two boards at same board file.
>> Thus, I will use same binary at two boards.
>
> OK.
>
>> How you think?
>> Please give your opinion.
>
> Sorry, but I fail to see a question?
>

Question...
How I can configure the board directory?
board/samsung/aquila or board/samsung/goni?
or need another naming for two boards?

Thanks
Minkyu Kang
-- 
from. prom.
www.promsoft.net

[U-Boot] Support similar boards at same board file?

[Wolfgang Denk]

Dear Minkyu Kang,

In message <AANLkTinxDyzb6NiN8KBFl9V_lmu7mW0G8Kv-c6qgAc6f@mail.gmail.com> you wrote:
> 
> >> I will post two boards "aquila" and "goni". (s5pc110 soc)
> >> These board are very similar and can detect the board by gpio. (at runtime)
> >> So, I want to support these two boards at same board file.
> >> Thus, I will use same binary at two boards.
...
> 
> Question...
> How I can configure the board directory?
> board/samsung/aquila or board/samsung/goni?
> or need another naming for two boards?

Use either name (but don't invent a third one). Which one to use -
that's your choice. I cannot answer this. If one of the two boards is
more general or more popular than the other, then use this one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If anything can go wrong, it will."                   - Edsel Murphy

[U-Boot] Support similar boards at same board file?

[Minkyu Kang]

Dear Wolfgang Denk,

On 25 May 2010 05:50, Wolfgang Denk <wd@denx.de> wrote:
> Dear Minkyu Kang,
>
> In message <AANLkTinxDyzb6NiN8KBFl9V_lmu7mW0G8Kv-c6qgAc6f@mail.gmail.com> you wrote:
>>
>> >> I will post two boards "aquila" and "goni". (s5pc110 soc)
>> >> These board are very similar and can detect the board by gpio. (at runtime)
>> >> So, I want to support these two boards at same board file.
>> >> Thus, I will use same binary at two boards.
> ...
>>
>> Question...
>> How I can configure the board directory?
>> board/samsung/aquila or board/samsung/goni?
>> or need another naming for two boards?
>
> Use either name (but don't invent a third one). Which one to use -
> that's your choice. I cannot answer this. If one of the two boards is
> more general or more popular than the other, then use this one.

OK.
Thanks.

Minkyu Kang
-- 
from. prom.
www.promsoft.net

[U-Boot] Support similar boards at same board file?

[Kyungmin Park]

Hi,

My bet is goni. Since it's new GPIO based board.

Thank you,
Kyungmin Park

> -----Original Message-----
> From: Minkyu Kang [mailto:promsoft at gmail.com]
> Sent: Tuesday, May 25, 2010 12:38 PM
> To: Wolfgang Denk
> Cc: u-boot at lists.denx.de; ???
> Subject: Re: Support similar boards at same board file?
> 
> Dear Wolfgang Denk,
> 
> On 25 May 2010 05:50, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Minkyu Kang,
> >
> > In message <AANLkTinxDyzb6NiN8KBFl9V_lmu7mW0G8Kv-
> c6qgAc6f at mail.gmail.com> you wrote:
> >>
> >> >> I will post two boards "aquila" and "goni". (s5pc110 soc)
> >> >> These board are very similar and can detect the board by gpio. (at
> runtime)
> >> >> So, I want to support these two boards at same board file.
> >> >> Thus, I will use same binary at two boards.
> > ...
> >>
> >> Question...
> >> How I can configure the board directory?
> >> board/samsung/aquila or board/samsung/goni?
> >> or need another naming for two boards?
> >
> > Use either name (but don't invent a third one). Which one to use -
> > that's your choice. I cannot answer this. If one of the two boards is
> > more general or more popular than the other, then use this one.
> 
> OK.
> Thanks.
> 
> Minkyu Kang
> --
> from. prom.
> www.promsoft.net