* [patch] nuc900fb: release correct mem region
@ 2010-03-25 10:54 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-03-25 10:54 UTC (permalink / raw)
To: linux-arm-kernel
We should be releasing "res->start" here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
BTW. Congratulations on being an official driver maintainer now. :) Can
you add yourself to the MAINTAINERS file?
diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
index 6bf0d46..d4cde79 100644
--- a/drivers/video/nuc900fb.c
+++ b/drivers/video/nuc900fb.c
@@ -667,7 +667,7 @@ release_irq:
release_regs:
iounmap(fbi->io);
release_mem_region:
- release_mem_region((unsigned long)fbi->mem, size);
+ release_mem_region(res->start, size);
free_fb:
framebuffer_release(fbinfo);
return ret;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [patch] nuc900fb: release correct mem region
@ 2010-03-25 10:54 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-03-25 10:54 UTC (permalink / raw)
To: linux-arm-kernel
We should be releasing "res->start" here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
BTW. Congratulations on being an official driver maintainer now. :) Can
you add yourself to the MAINTAINERS file?
diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
index 6bf0d46..d4cde79 100644
--- a/drivers/video/nuc900fb.c
+++ b/drivers/video/nuc900fb.c
@@ -667,7 +667,7 @@ release_irq:
release_regs:
iounmap(fbi->io);
release_mem_region:
- release_mem_region((unsigned long)fbi->mem, size);
+ release_mem_region(res->start, size);
free_fb:
framebuffer_release(fbinfo);
return ret;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch] nuc900fb: release correct mem region
2010-03-25 10:54 ` Dan Carpenter
@ 2010-05-19 19:48 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-05-19 19:48 UTC (permalink / raw)
To: linux-arm-kernel
Ping. Any feedback on this patch?
regards,
dan carpenter
On Thu, Mar 25, 2010 at 01:54:08PM +0300, Dan Carpenter wrote:
> We should be releasing "res->start" here.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> BTW. Congratulations on being an official driver maintainer now. :) Can
> you add yourself to the MAINTAINERS file?
>
> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
> index 6bf0d46..d4cde79 100644
> --- a/drivers/video/nuc900fb.c
> +++ b/drivers/video/nuc900fb.c
> @@ -667,7 +667,7 @@ release_irq:
> release_regs:
> iounmap(fbi->io);
> release_mem_region:
> - release_mem_region((unsigned long)fbi->mem, size);
> + release_mem_region(res->start, size);
> free_fb:
> framebuffer_release(fbinfo);
> return ret;
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch] nuc900fb: release correct mem region
@ 2010-05-19 19:48 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2010-05-19 19:48 UTC (permalink / raw)
To: linux-arm-kernel
Ping. Any feedback on this patch?
regards,
dan carpenter
On Thu, Mar 25, 2010 at 01:54:08PM +0300, Dan Carpenter wrote:
> We should be releasing "res->start" here.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> BTW. Congratulations on being an official driver maintainer now. :) Can
> you add yourself to the MAINTAINERS file?
>
> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
> index 6bf0d46..d4cde79 100644
> --- a/drivers/video/nuc900fb.c
> +++ b/drivers/video/nuc900fb.c
> @@ -667,7 +667,7 @@ release_irq:
> release_regs:
> iounmap(fbi->io);
> release_mem_region:
> - release_mem_region((unsigned long)fbi->mem, size);
> + release_mem_region(res->start, size);
> free_fb:
> framebuffer_release(fbinfo);
> return ret;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] nuc900fb: release correct mem region
2010-05-19 19:48 ` Dan Carpenter
@ 2010-05-20 2:36 ` Wan ZongShun
-1 siblings, 0 replies; 8+ messages in thread
From: Wan ZongShun @ 2010-05-20 2:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi Dan,
Qiang brother have a busy doing business, so I can maintain the
nuc900fb driver instead.
It looks good to me.
Andrew , Could you help merge this patch? thanks a lot!
Acked-by: Wan ZongShun<mcuos.com@gmail.com>
2010/5/20 Dan Carpenter <error27@gmail.com>:
> Ping. Any feedback on this patch?
>
> regards,
> dan carpenter
>
> On Thu, Mar 25, 2010 at 01:54:08PM +0300, Dan Carpenter wrote:
>> We should be releasing "res->start" here.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>> ---
>> BTW. Congratulations on being an official driver maintainer now. :) Can
>> you add yourself to the MAINTAINERS file?
>>
>> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
>> index 6bf0d46..d4cde79 100644
>> --- a/drivers/video/nuc900fb.c
>> +++ b/drivers/video/nuc900fb.c
>> @@ -667,7 +667,7 @@ release_irq:
>> release_regs:
>> iounmap(fbi->io);
>> release_mem_region:
>> - release_mem_region((unsigned long)fbi->mem, size);
>> + release_mem_region(res->start, size);
>> free_fb:
>> framebuffer_release(fbinfo);
>> return ret;
>
--
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
* linux-arm-NUC900 mailing list
mail addr:NUC900@googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@gmail.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch] nuc900fb: release correct mem region
@ 2010-05-20 2:36 ` Wan ZongShun
0 siblings, 0 replies; 8+ messages in thread
From: Wan ZongShun @ 2010-05-20 2:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi Dan,
Qiang brother have a busy doing business, so I can maintain the
nuc900fb driver instead.
It looks good to me.
Andrew , Could you help merge this patch? thanks a lot!
Acked-by: Wan ZongShun<mcuos.com@gmail.com>
2010/5/20 Dan Carpenter <error27@gmail.com>:
> Ping. ?Any feedback on this patch?
>
> regards,
> dan carpenter
>
> On Thu, Mar 25, 2010 at 01:54:08PM +0300, Dan Carpenter wrote:
>> We should be releasing "res->start" here.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>> ---
>> BTW. ?Congratulations on being an official driver maintainer now. ?:) ?Can
>> you add yourself to the MAINTAINERS file?
>>
>> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
>> index 6bf0d46..d4cde79 100644
>> --- a/drivers/video/nuc900fb.c
>> +++ b/drivers/video/nuc900fb.c
>> @@ -667,7 +667,7 @@ release_irq:
>> ?release_regs:
>> ? ? ? iounmap(fbi->io);
>> ?release_mem_region:
>> - ? ? release_mem_region((unsigned long)fbi->mem, size);
>> + ? ? release_mem_region(res->start, size);
>> ?free_fb:
>> ? ? ? framebuffer_release(fbinfo);
>> ? ? ? return ret;
>
--
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel at lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
* linux-arm-NUC900 mailing list
mail addr:NUC900 at googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com at gmail.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] nuc900fb: release correct mem region
2010-05-20 2:36 ` Wan ZongShun
@ 2010-05-21 19:56 ` Andrew Morton
-1 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2010-05-21 19:56 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 20 May 2010 10:36:59 +0800
Wan ZongShun <mcuos.com@gmail.com> wrote:
> Hi Dan,
>
> Qiang brother have a busy doing business, so I can maintain the
> nuc900fb driver instead.
Feel free to send an update to the MAINTAINERS file.
> It looks good to me.
>
> Andrew , Could you help merge this patch? thanks a lot!
>
> Acked-by: Wan ZongShun<mcuos.com@gmail.com>
>
>
> 2010/5/20 Dan Carpenter <error27@gmail.com>:
> > Ping. __Any feedback on this patch?
> >
> > regards,
> > dan carpenter
> >
> > On Thu, Mar 25, 2010 at 01:54:08PM +0300, Dan Carpenter wrote:
> >> We should be releasing "res->start" here.
> >>
> >> Signed-off-by: Dan Carpenter <error27@gmail.com>
> >> ---
> >> BTW. __Congratulations on being an official driver maintainer now. __:) __Can
> >> you add yourself to the MAINTAINERS file?
> >>
> >> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
> >> index 6bf0d46..d4cde79 100644
> >> --- a/drivers/video/nuc900fb.c
> >> +++ b/drivers/video/nuc900fb.c
> >> @@ -667,7 +667,7 @@ release_irq:
> >> __release_regs:
> >> __ __ __ iounmap(fbi->io);
> >> __release_mem_region:
> >> - __ __ release_mem_region((unsigned long)fbi->mem, size);
> >> + __ __ release_mem_region(res->start, size);
> >> __free_fb:
> >> __ __ __ framebuffer_release(fbinfo);
> >> __ __ __ return ret;
> >
I don't think I ever received a copy of this patch. I reconstructed it.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch] nuc900fb: release correct mem region
@ 2010-05-21 19:56 ` Andrew Morton
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2010-05-21 19:56 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 20 May 2010 10:36:59 +0800
Wan ZongShun <mcuos.com@gmail.com> wrote:
> Hi Dan,
>
> Qiang brother have a busy doing business, so I can maintain the
> nuc900fb driver instead.
Feel free to send an update to the MAINTAINERS file.
> It looks good to me.
>
> Andrew , Could you help merge this patch? thanks a lot!
>
> Acked-by: Wan ZongShun<mcuos.com@gmail.com>
>
>
> 2010/5/20 Dan Carpenter <error27@gmail.com>:
> > Ping. __Any feedback on this patch?
> >
> > regards,
> > dan carpenter
> >
> > On Thu, Mar 25, 2010 at 01:54:08PM +0300, Dan Carpenter wrote:
> >> We should be releasing "res->start" here.
> >>
> >> Signed-off-by: Dan Carpenter <error27@gmail.com>
> >> ---
> >> BTW. __Congratulations on being an official driver maintainer now. __:) __Can
> >> you add yourself to the MAINTAINERS file?
> >>
> >> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
> >> index 6bf0d46..d4cde79 100644
> >> --- a/drivers/video/nuc900fb.c
> >> +++ b/drivers/video/nuc900fb.c
> >> @@ -667,7 +667,7 @@ release_irq:
> >> __release_regs:
> >> __ __ __ iounmap(fbi->io);
> >> __release_mem_region:
> >> - __ __ release_mem_region((unsigned long)fbi->mem, size);
> >> + __ __ release_mem_region(res->start, size);
> >> __free_fb:
> >> __ __ __ framebuffer_release(fbinfo);
> >> __ __ __ return ret;
> >
I don't think I ever received a copy of this patch. I reconstructed it.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-05-21 19:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-25 10:54 [patch] nuc900fb: release correct mem region Dan Carpenter
2010-03-25 10:54 ` Dan Carpenter
2010-05-19 19:48 ` Dan Carpenter
2010-05-19 19:48 ` Dan Carpenter
2010-05-20 2:36 ` Wan ZongShun
2010-05-20 2:36 ` Wan ZongShun
2010-05-21 19:56 ` Andrew Morton
2010-05-21 19:56 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.