From: Andrew Morton <akpm@linux-foundation.org>
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
andi.kleen@intel.com, cl@linux-foundation.org,
fengguang.wu@intel.com, mel@csn.ul.ie, tj@kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
minskey guo <chaohong.guo@intel.com>
Subject: Re: [PATCH] cpu_up: hold zonelists_mutex when build_all_zonelists
Date: Fri, 21 May 2010 13:08:08 -0700 [thread overview]
Message-ID: <20100521130808.919ecb35.akpm@linux-foundation.org> (raw)
In-Reply-To: <4BF4AB24.7070107@linux.intel.com>
On Thu, 20 May 2010 11:23:16 +0800
Haicheng Li <haicheng.li@linux.intel.com> wrote:
>
> Here is another issue, we should always hold zonelists_mutex when calling build_all_zonelists
> unless system_state == SYSTEM_BOOTING.
Taking a global mutex in the cpu-hotplug code is worrisome. Perhaps
because of the two years spent weeding out strange deadlocks between
cpu-hotplug and cpufreq.
Has this change been carefully and fully tested with lockdep enabled
(please)?
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -357,8 +357,11 @@ int __cpuinit cpu_up(unsigned int cpu)
> return -ENOMEM;
> }
>
> - if (pgdat->node_zonelists->_zonerefs->zone == NULL)
> + if (pgdat->node_zonelists->_zonerefs->zone == NULL) {
> + mutex_lock(&zonelists_mutex);
> build_all_zonelists(NULL);
> + mutex_unlock(&zonelists_mutex);
> + }
Your email client is performing space-stuffing and it replaces tabs
with spaces. This requires me to edit the patches rather a lot,
which is dull.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
andi.kleen@intel.com, cl@linux-foundation.org,
fengguang.wu@intel.com, mel@csn.ul.ie, tj@kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
minskey guo <chaohong.guo@intel.com>
Subject: Re: [PATCH] cpu_up: hold zonelists_mutex when build_all_zonelists
Date: Fri, 21 May 2010 13:08:08 -0700 [thread overview]
Message-ID: <20100521130808.919ecb35.akpm@linux-foundation.org> (raw)
In-Reply-To: <4BF4AB24.7070107@linux.intel.com>
On Thu, 20 May 2010 11:23:16 +0800
Haicheng Li <haicheng.li@linux.intel.com> wrote:
>
> Here is another issue, we should always hold zonelists_mutex when calling build_all_zonelists
> unless system_state == SYSTEM_BOOTING.
Taking a global mutex in the cpu-hotplug code is worrisome. Perhaps
because of the two years spent weeding out strange deadlocks between
cpu-hotplug and cpufreq.
Has this change been carefully and fully tested with lockdep enabled
(please)?
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -357,8 +357,11 @@ int __cpuinit cpu_up(unsigned int cpu)
> return -ENOMEM;
> }
>
> - if (pgdat->node_zonelists->_zonerefs->zone == NULL)
> + if (pgdat->node_zonelists->_zonerefs->zone == NULL) {
> + mutex_lock(&zonelists_mutex);
> build_all_zonelists(NULL);
> + mutex_unlock(&zonelists_mutex);
> + }
Your email client is performing space-stuffing and it replaces tabs
with spaces. This requires me to edit the patches rather a lot,
which is dull.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-21 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 22:54 + mem-hotplug-avoid-multiple-zones-sharing-same-boot-strapping-boot_pageset-fix.patch added to -mm tree akpm
2010-05-20 3:23 ` [PATCH] cpu_up: hold zonelists_mutex when build_all_zonelists Haicheng Li
2010-05-20 3:23 ` Haicheng Li
2010-05-21 20:08 ` Andrew Morton [this message]
2010-05-21 20:08 ` Andrew Morton
2010-05-25 5:05 ` Haicheng Li
2010-05-25 5:05 ` Haicheng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100521130808.919ecb35.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=chaohong.guo@intel.com \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.