From: Dave Chinner <david@fromorbit.com>
To: tytso@mit.edu, linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
jens.axboe@oracle.com
Subject: Re: [PATCH 3/6] ext4: Use our own write_cache_pages()
Date: Wed, 26 May 2010 08:42:59 +1000 [thread overview]
Message-ID: <20100525224259.GM2150@dastard> (raw)
In-Reply-To: <20100525130626.GD5556@thunk.org>
On Tue, May 25, 2010 at 09:06:26AM -0400, tytso@mit.edu wrote:
> On Tue, May 25, 2010 at 08:54:09PM +1000, Dave Chinner wrote:
> > From: Theodore Ts'o <tytso@mit.edu>
> >
> > Make a copy of write_cache_pages() for the benefit of
> > ext4_da_writepages(). This allows us to simplify the code some, and
> > will allow us to further customize the code in future patches.
>
> I'm going to be pushing this to Linus shortly, so it's likely you'll
> be able to drop this from your patch series.
Great!
> I just wanted to give
> you a heads up about what I was planning on doing, which hopefully
> simplified your life a little.
And that's appreciated. I included it to make sure everyone could
see how this all fitted together and others could test it if they so
desired. i.e. make sure I wasn't breaking ext4 by reverting the
changes to write_cache_pages. I'll leave it in the series until the
ext4 change is upstream, then I'll drop it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: tytso@mit.edu, linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
jens.axboe@oracle.com
Subject: Re: [PATCH 3/6] ext4: Use our own write_cache_pages()
Date: Wed, 26 May 2010 08:42:59 +1000 [thread overview]
Message-ID: <20100525224259.GM2150@dastard> (raw)
In-Reply-To: <20100525130626.GD5556@thunk.org>
On Tue, May 25, 2010 at 09:06:26AM -0400, tytso@mit.edu wrote:
> On Tue, May 25, 2010 at 08:54:09PM +1000, Dave Chinner wrote:
> > From: Theodore Ts'o <tytso@mit.edu>
> >
> > Make a copy of write_cache_pages() for the benefit of
> > ext4_da_writepages(). This allows us to simplify the code some, and
> > will allow us to further customize the code in future patches.
>
> I'm going to be pushing this to Linus shortly, so it's likely you'll
> be able to drop this from your patch series.
Great!
> I just wanted to give
> you a heads up about what I was planning on doing, which hopefully
> simplified your life a little.
And that's appreciated. I included it to make sure everyone could
see how this all fitted together and others could test it if they so
desired. i.e. make sure I wasn't breaking ext4 by reverting the
changes to write_cache_pages. I'll leave it in the series until the
ext4 change is upstream, then I'll drop it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-05-25 22:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 10:54 [PATCH 0/6] writeback: tracing and fixes Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 10:54 ` [PATCH 1/6] writeback: initial tracing support Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 11:13 ` Christoph Hellwig
2010-05-25 11:13 ` Christoph Hellwig
2010-05-27 21:32 ` Andrew Morton
2010-05-27 21:32 ` Andrew Morton
2010-05-28 0:44 ` Dave Chinner
2010-05-28 0:44 ` Dave Chinner
2010-05-28 1:20 ` Steven Rostedt
2010-05-28 1:20 ` Steven Rostedt
2010-05-28 1:18 ` Steven Rostedt
2010-05-28 1:18 ` Steven Rostedt
2010-05-28 7:45 ` Christoph Hellwig
2010-05-28 7:45 ` Christoph Hellwig
2010-05-25 10:54 ` [PATCH 2/6] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 11:13 ` Christoph Hellwig
2010-05-25 11:13 ` Christoph Hellwig
2010-05-25 10:54 ` [PATCH 3/6] ext4: Use our own write_cache_pages() Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 13:06 ` tytso
2010-05-25 13:06 ` tytso
2010-05-25 22:42 ` Dave Chinner [this message]
2010-05-25 22:42 ` Dave Chinner
2010-05-25 10:54 ` [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 11:11 ` Christoph Hellwig
2010-05-25 11:11 ` Christoph Hellwig
2010-05-27 21:32 ` Andrew Morton
2010-05-27 21:32 ` Andrew Morton
2010-05-28 0:56 ` Dave Chinner
2010-05-28 0:56 ` Dave Chinner
2010-05-25 10:54 ` [PATCH 5/6] xfs: remove nr_to_write writeback windup Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 11:14 ` Christoph Hellwig
2010-05-25 11:14 ` Christoph Hellwig
2010-05-25 10:54 ` [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-27 21:33 ` Andrew Morton
2010-05-27 21:33 ` Andrew Morton
2010-05-28 1:23 ` Dave Chinner
2010-05-28 1:23 ` Dave Chinner
2010-05-28 5:06 ` Nick Piggin
2010-05-28 5:06 ` Nick Piggin
2010-06-01 15:54 ` Jan Kara
2010-06-01 15:54 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525224259.GM2150@dastard \
--to=david@fromorbit.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.