From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
tytso@mit.edu, jens.axboe@oracle.com
Subject: Re: [PATCH 1/6] writeback: initial tracing support
Date: Fri, 28 May 2010 03:45:00 -0400 [thread overview]
Message-ID: <20100528074500.GA14151@infradead.org> (raw)
In-Reply-To: <20100527143233.836b2c47.akpm@linux-foundation.org>
On Thu, May 27, 2010 at 02:32:33PM -0700, Andrew Morton wrote:
> > +#define inode_to_bdi(inode) ((inode)->i_mapping->backing_dev_info)
>
> Could/should be implemented in C.
>
> > +/*
> > + * We don't actually have pdflush, but this one is exported though /proc...
> > + */
> > +int nr_pdflush_threads;
>
> So this is always zero now?
>
> We don't want to keep it forever. Add a
> printk_once("nr_pdflush_threads is deprecated") when someone reads it,
> remove it in 2014.
These two lines are just moved down a bit by the patch, I think any
cleanups should be left to separate patches.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: tytso@mit.edu, linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/6] writeback: initial tracing support
Date: Fri, 28 May 2010 03:45:00 -0400 [thread overview]
Message-ID: <20100528074500.GA14151@infradead.org> (raw)
In-Reply-To: <20100527143233.836b2c47.akpm@linux-foundation.org>
On Thu, May 27, 2010 at 02:32:33PM -0700, Andrew Morton wrote:
> > +#define inode_to_bdi(inode) ((inode)->i_mapping->backing_dev_info)
>
> Could/should be implemented in C.
>
> > +/*
> > + * We don't actually have pdflush, but this one is exported though /proc...
> > + */
> > +int nr_pdflush_threads;
>
> So this is always zero now?
>
> We don't want to keep it forever. Add a
> printk_once("nr_pdflush_threads is deprecated") when someone reads it,
> remove it in 2014.
These two lines are just moved down a bit by the patch, I think any
cleanups should be left to separate patches.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-05-28 7:45 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 10:54 [PATCH 0/6] writeback: tracing and fixes Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 10:54 ` [PATCH 1/6] writeback: initial tracing support Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 11:13 ` Christoph Hellwig
2010-05-25 11:13 ` Christoph Hellwig
2010-05-27 21:32 ` Andrew Morton
2010-05-27 21:32 ` Andrew Morton
2010-05-28 0:44 ` Dave Chinner
2010-05-28 0:44 ` Dave Chinner
2010-05-28 1:20 ` Steven Rostedt
2010-05-28 1:20 ` Steven Rostedt
2010-05-28 1:18 ` Steven Rostedt
2010-05-28 1:18 ` Steven Rostedt
2010-05-28 7:45 ` Christoph Hellwig [this message]
2010-05-28 7:45 ` Christoph Hellwig
2010-05-25 10:54 ` [PATCH 2/6] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 11:13 ` Christoph Hellwig
2010-05-25 11:13 ` Christoph Hellwig
2010-05-25 10:54 ` [PATCH 3/6] ext4: Use our own write_cache_pages() Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 13:06 ` tytso
2010-05-25 13:06 ` tytso
2010-05-25 22:42 ` Dave Chinner
2010-05-25 22:42 ` Dave Chinner
2010-05-25 10:54 ` [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 11:11 ` Christoph Hellwig
2010-05-25 11:11 ` Christoph Hellwig
2010-05-27 21:32 ` Andrew Morton
2010-05-27 21:32 ` Andrew Morton
2010-05-28 0:56 ` Dave Chinner
2010-05-28 0:56 ` Dave Chinner
2010-05-25 10:54 ` [PATCH 5/6] xfs: remove nr_to_write writeback windup Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-25 11:14 ` Christoph Hellwig
2010-05-25 11:14 ` Christoph Hellwig
2010-05-25 10:54 ` [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF Dave Chinner
2010-05-25 10:54 ` Dave Chinner
2010-05-27 21:33 ` Andrew Morton
2010-05-27 21:33 ` Andrew Morton
2010-05-28 1:23 ` Dave Chinner
2010-05-28 1:23 ` Dave Chinner
2010-05-28 5:06 ` Nick Piggin
2010-05-28 5:06 ` Nick Piggin
2010-06-01 15:54 ` Jan Kara
2010-06-01 15:54 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2010-06-03 23:55 [PATCH 0/6] writeback: tracing and fixes V3 Dave Chinner
2010-06-03 23:55 ` [PATCH 1/6] writeback: initial tracing support Dave Chinner
2010-06-03 23:55 ` Dave Chinner
2010-06-04 1:10 ` Li Zefan
2010-06-04 1:10 ` Li Zefan
2010-06-04 1:24 ` Dave Chinner
2010-06-04 1:24 ` Dave Chinner
2010-06-08 0:38 [PATCH 0/6] writeback: tracing and fixes V4 Dave Chinner
2010-06-08 0:38 ` [PATCH 1/6] writeback: initial tracing support Dave Chinner
2010-06-08 0:38 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528074500.GA14151@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.