From: Herbert Xu <herbert@gondor.hengli.com.au>
To: Dan Carpenter <error27@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Uri Simchoni <uri@jdland.co.il>, Nicolas Pitre <nico@marvell.com>,
Tejun Heo <tj@kernel.org>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mv_cesa: fixup error handling in mv_probe()
Date: Wed, 26 May 2010 00:45:35 +0000 [thread overview]
Message-ID: <20100526004535.GF20073@gondor.apana.org.au> (raw)
In-Reply-To: <20100525094947.GF22515@bicker>
On Tue, May 25, 2010 at 11:49:47AM +0200, Dan Carpenter wrote:
> The error handling in mv_probe() was a bit messed up. There were some
> gotos to the wrong labels so it ended up releasing stuff that that hadn't
> been aquired and not releasing stuff that was meant to be released. I
> shuffled it around a bit to fix it and make it clearer.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Patch applied. Thank you.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dan Carpenter <error27@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Uri Simchoni <uri@jdland.co.il>, Nicolas Pitre <nico@marvell.com>,
Tejun Heo <tj@kernel.org>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mv_cesa: fixup error handling in mv_probe()
Date: Wed, 26 May 2010 10:45:35 +1000 [thread overview]
Message-ID: <20100526004535.GF20073@gondor.apana.org.au> (raw)
In-Reply-To: <20100525094947.GF22515@bicker>
On Tue, May 25, 2010 at 11:49:47AM +0200, Dan Carpenter wrote:
> The error handling in mv_probe() was a bit messed up. There were some
> gotos to the wrong labels so it ended up releasing stuff that that hadn't
> been aquired and not releasing stuff that was meant to be released. I
> shuffled it around a bit to fix it and make it clearer.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Patch applied. Thank you.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2010-05-26 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 9:49 [patch] mv_cesa: fixup error handling in mv_probe() Dan Carpenter
2010-05-25 9:49 ` Dan Carpenter
2010-05-26 0:45 ` Herbert Xu [this message]
2010-05-26 0:45 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526004535.GF20073@gondor.apana.org.au \
--to=herbert@gondor.hengli.com.au \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=nico@marvell.com \
--cc=tj@kernel.org \
--cc=uri@jdland.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.