Re: usb_nop_xceiv_register() missing when OTG built as modules

[Felipe Balbi <felipe.balbi@nokia.com>]

Hi,

On Sun, May 23, 2010 at 01:53:10AM +0200, ext Amit Kucheria wrote:
>From 3df714f995b0895e905090760482194233f66a1d Mon Sep 17 00:00:00 2001
>Message-Id: <3df714f995b0895e905090760482194233f66a1d.1274570700.git.amit.kucheria@canonical.com>
>From: Amit Kucheria <amit.kucheria@canonical.com>
>Date: Sun, 23 May 2010 01:35:00 +0300
>Subject: [PATCH] omap: remove calls to usb_nop_xceiv_register from board files
>
>This will allow the OMAP USB drivers to be compiled in as modules. At the
>moment, CONFIG_NOP_USB_XCEIV cannot be a module.
>
>Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com>
>---
> arch/arm/mach-omap2/board-4430sdp.c  |   10 ++++++++--
> arch/arm/mach-omap2/board-omap3evm.c |   11 ++++++++---
> 2 files changed, 16 insertions(+), 5 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
>index e4a5d66..131f0fd 100644
>--- a/arch/arm/mach-omap2/board-4430sdp.c
>+++ b/arch/arm/mach-omap2/board-4430sdp.c
>@@ -110,8 +110,16 @@ static struct platform_device sdp4430_lcd_device = {
> 	.id		= -1,
> };
> 
>+static struct platform_device sdp4430_nop_usb_device = {
>+	.name		= "nop_usb_xceiv",
>+	.id		= -1,
>+	.resource	= NULL,
>+	.num_resources	= 0,

you don't need to zero-initialize a static variable. So you can just 
drop .resource and .num_resources altogether.

-- 
balbi

DefectiveByDesign.org