From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Gupta, Ajay Kumar" <ajay.gupta@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: usb_nop_xceiv_register() missing when OTG built as modules
Date: Thu, 04 Mar 2010 09:32:40 -0800 [thread overview]
Message-ID: <87eik03scn.fsf@deeprootsystems.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044DB7B6BD@dbde02.ent.ti.com> (Ajay Kumar Gupta's message of "Thu\, 4 Mar 2010 09\:59\:52 +0530")
"Gupta, Ajay Kumar" <ajay.gupta@ti.com> writes:
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> owner@vger.kernel.org] On Behalf Of Kevin Hilman
>> Sent: Thursday, March 04, 2010 5:39 AM
>> To: linux-omap@vger.kernel.org
>> Subject: usb_nop_xceiv_register() missing when OTG built as modules
>>
>> This just started happening with v2.6.33.
>>
>> On OMAP3EVM, usb_nop_xceiv_register() is called in the board file,
>> but if USB gadget support is built as a module, this causes a link
>> error (below)
>
> Kevin,
>
> usb_nop_xceiv_register() is defined at drivers/usb/otg/nop-usb-xceiv.c file
> which gets compiled if CONFIG_NOP_USB_XCEIV=y.
>
> I think you have enabled CONFIG_NOP_USB_XCEIV as module?
Yes, I did that intentionally. I *want* USB compiled as a module. If
I do that, the build fails, and that's a bug that needs to be fixed.
Kevin
>
>>
>> This is obviously broken, and this hook needs to be fixed to work when
>> called as a module.
>>
>> To reproduce, start with omap3_defconfig and change both USB host
>> and gadget to be built as modules.
>>
>> Kevin
>>
>>
>> [...]
>> LD .tmp_vmlinux1
>> arch/arm/mach-omap2/built-in.o: In function `omap3_evm_init':
>> /opt/home/khilman/work.local/kernel/omap/dev/arch/arm/mach-omap2/board-
>> omap3evm.c:686: undefined reference to `usb_nop_xceiv_register'
>> arch/arm/mach-omap2/built-in.o: In function `omap_4430sdp_init':
>> /opt/home/khilman/work.local/kernel/omap/dev/arch/arm/mach-omap2/board-
>> 4430sdp.c:143: undefined reference to `usb_nop_xceiv_register'
>> make[1]: *** [.tmp_vmlinux1] Error 1
>> make: *** [sub-make] Error 2
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-04 17:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 0:09 usb_nop_xceiv_register() missing when OTG built as modules Kevin Hilman
2010-03-04 4:29 ` Gupta, Ajay Kumar
2010-03-04 17:32 ` Kevin Hilman [this message]
2010-03-05 3:50 ` Gupta, Ajay Kumar
2010-03-05 9:04 ` Felipe Balbi
2010-03-05 17:59 ` Kevin Hilman
2010-03-05 19:54 ` me
2010-03-05 22:02 ` Kevin Hilman
2010-05-22 23:53 ` Amit Kucheria
2010-05-24 7:07 ` Gupta, Ajay Kumar
2010-05-26 6:03 ` Felipe Balbi
2010-05-26 6:20 ` Gupta, Ajay Kumar
2010-05-26 6:53 ` Gupta, Ajay Kumar
2010-05-26 6:02 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eik03scn.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=ajay.gupta@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.