From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Julia Lawall <julia@diku.dk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock
Date: Thu, 27 May 2010 11:11:36 +0000 [thread overview]
Message-ID: <20100527111136.GV3266@amd.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1005261755260.23743@ask.diku.dk>
On Wed, May 26, 2010 at 11:55:59AM -0400, Julia Lawall wrote:
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression E1;
> @@
>
> * spin_lock(E1,...);
> <+... when != E1
> if (...) {
> ... when != E1
> * return ...;
> }
> ...+>
> * spin_unlock(E1,...);
> // </smpl>
Btw, I think it would be great to have a collection of these semantic
match scripts in the kernel repository together with a build target to
run these scripts over the kernel sources (like the cscope target).
Opinions?
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Julia Lawall <julia@diku.dk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock
Date: Thu, 27 May 2010 13:11:36 +0200 [thread overview]
Message-ID: <20100527111136.GV3266@amd.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1005261755260.23743@ask.diku.dk>
On Wed, May 26, 2010 at 11:55:59AM -0400, Julia Lawall wrote:
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression E1;
> @@
>
> * spin_lock(E1,...);
> <+... when != E1
> if (...) {
> ... when != E1
> * return ...;
> }
> ...+>
> * spin_unlock(E1,...);
> // </smpl>
Btw, I think it would be great to have a collection of these semantic
match scripts in the kernel repository together with a build target to
run these scripts over the kernel sources (like the cscope target).
Opinions?
Joerg
next prev parent reply other threads:[~2010-05-27 11:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 15:55 [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock Julia Lawall
2010-05-26 15:55 ` Julia Lawall
2010-05-27 11:06 ` Roedel, Joerg
2010-05-27 11:06 ` Roedel, Joerg
2010-05-27 11:11 ` Roedel, Joerg [this message]
2010-05-27 11:11 ` Roedel, Joerg
2010-05-27 11:17 ` Julia Lawall
2010-05-27 11:17 ` Julia Lawall
2010-05-27 11:42 ` Nicolas Palix
2010-05-27 11:42 ` Nicolas Palix
2010-05-28 7:11 ` Roedel, Joerg
2010-05-28 7:11 ` Roedel, Joerg
2010-05-28 16:45 ` H. Peter Anvin
2010-05-28 16:45 ` H. Peter Anvin
2010-06-01 9:58 ` Joerg Roedel
2010-06-01 9:58 ` Joerg Roedel
2010-06-01 21:15 ` Andrew Morton
2010-06-01 21:15 ` Andrew Morton
2010-06-01 21:47 ` Thomas Gleixner
2010-06-01 21:47 ` Thomas Gleixner
2010-06-02 5:29 ` Julia Lawall
2010-06-02 5:29 ` Julia Lawall
2010-06-02 8:38 ` Roedel, Joerg
2010-06-02 8:38 ` Roedel, Joerg
2010-06-02 8:42 ` Julia Lawall
2010-06-02 8:42 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527111136.GV3266@amd.com \
--to=joerg.roedel@amd.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.