From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Julia Lawall <julia@diku.dk>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock
Date: Wed, 02 Jun 2010 08:38:38 +0000 [thread overview]
Message-ID: <20100602083837.GC21639@amd.com> (raw)
In-Reply-To: <20100601141529.0c99f22c.akpm@linux-foundation.org>
Hi Andrew,
On Tue, Jun 01, 2010 at 05:15:29PM -0400, Andrew Morton wrote:
> The reason why these bugs occur is that we sprinkle multiple `return'
> statements inside the middle of non-trivial functions. People miss
> some or fail to modify some when later changing locking rules and we
> gain bugs (or, similarly, resource leaks).
Right. I changed that in Julia's patch too before merging it into my
tree. It is already in -tip. See
http://git.kernel.org/tip/84fe6c19e4a598e8071e3bd1b2c923454eae1268
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Julia Lawall <julia@diku.dk>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock
Date: Wed, 2 Jun 2010 10:38:38 +0200 [thread overview]
Message-ID: <20100602083837.GC21639@amd.com> (raw)
In-Reply-To: <20100601141529.0c99f22c.akpm@linux-foundation.org>
Hi Andrew,
On Tue, Jun 01, 2010 at 05:15:29PM -0400, Andrew Morton wrote:
> The reason why these bugs occur is that we sprinkle multiple `return'
> statements inside the middle of non-trivial functions. People miss
> some or fail to modify some when later changing locking rules and we
> gain bugs (or, similarly, resource leaks).
Right. I changed that in Julia's patch too before merging it into my
tree. It is already in -tip. See
http://git.kernel.org/tip/84fe6c19e4a598e8071e3bd1b2c923454eae1268
Joerg
next prev parent reply other threads:[~2010-06-02 8:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 15:55 [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock Julia Lawall
2010-05-26 15:55 ` Julia Lawall
2010-05-27 11:06 ` Roedel, Joerg
2010-05-27 11:06 ` Roedel, Joerg
2010-05-27 11:11 ` Roedel, Joerg
2010-05-27 11:11 ` Roedel, Joerg
2010-05-27 11:17 ` Julia Lawall
2010-05-27 11:17 ` Julia Lawall
2010-05-27 11:42 ` Nicolas Palix
2010-05-27 11:42 ` Nicolas Palix
2010-05-28 7:11 ` Roedel, Joerg
2010-05-28 7:11 ` Roedel, Joerg
2010-05-28 16:45 ` H. Peter Anvin
2010-05-28 16:45 ` H. Peter Anvin
2010-06-01 9:58 ` Joerg Roedel
2010-06-01 9:58 ` Joerg Roedel
2010-06-01 21:15 ` Andrew Morton
2010-06-01 21:15 ` Andrew Morton
2010-06-01 21:47 ` Thomas Gleixner
2010-06-01 21:47 ` Thomas Gleixner
2010-06-02 5:29 ` Julia Lawall
2010-06-02 5:29 ` Julia Lawall
2010-06-02 8:38 ` Roedel, Joerg [this message]
2010-06-02 8:38 ` Roedel, Joerg
2010-06-02 8:42 ` Julia Lawall
2010-06-02 8:42 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602083837.GC21639@amd.com \
--to=joerg.roedel@amd.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.