All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Ian Kent <raven@themaw.net>
Cc: autofs@linux.kernel.org, Frederic Weisbecker <fweisbec@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kernel-janitors@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: [patch] autofs4: remove unneeded null check in try_to_fill_dentry()
Date: Tue, 1 Jun 2010 09:15:50 +0200	[thread overview]
Message-ID: <20100601071550.GI5483@bicker> (raw)

After 97e7449a7ad: "autofs4: fix indirect mount pending expire race" we
know longer assumed that "ino" can be null.  The other null checks got
removed but this was one as missed.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
index db4117e..5c0b93f 100644
--- a/fs/autofs4/root.c
+++ b/fs/autofs4/root.c
@@ -198,8 +198,7 @@ static int try_to_fill_dentry(struct dentry *dentry, int flags)
 	}
 
 	/* Initialize expiry counter after successful mount */
-	if (ino)
-		ino->last_used = jiffies;
+	ino->last_used = jiffies;
 
 	spin_lock(&sbi->fs_lock);
 	ino->flags &= ~AUTOFS_INF_PENDING;

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] autofs4: remove unneeded null check in try_to_fill_dentry()
Date: Tue, 01 Jun 2010 07:15:50 +0000	[thread overview]
Message-ID: <20100601071550.GI5483@bicker> (raw)

After 97e7449a7ad: "autofs4: fix indirect mount pending expire race" we
know longer assumed that "ino" can be null.  The other null checks got
removed but this was one as missed.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
index db4117e..5c0b93f 100644
--- a/fs/autofs4/root.c
+++ b/fs/autofs4/root.c
@@ -198,8 +198,7 @@ static int try_to_fill_dentry(struct dentry *dentry, int flags)
 	}
 
 	/* Initialize expiry counter after successful mount */
-	if (ino)
-		ino->last_used = jiffies;
+	ino->last_used = jiffies;
 
 	spin_lock(&sbi->fs_lock);
 	ino->flags &= ~AUTOFS_INF_PENDING;

             reply	other threads:[~2010-06-01  7:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01  7:15 Dan Carpenter [this message]
2010-06-01  7:15 ` [patch] autofs4: remove unneeded null check in try_to_fill_dentry() Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100601071550.GI5483@bicker \
    --to=error27@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=autofs@linux.kernel.org \
    --cc=fweisbec@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=raven@themaw.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.