* [patch] autofs4: remove unneeded null check in try_to_fill_dentry()
@ 2010-06-01 7:15 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-06-01 7:15 UTC (permalink / raw)
To: Ian Kent
Cc: autofs, Frederic Weisbecker, Andrew Morton, kernel-janitors,
Al Viro
After 97e7449a7ad: "autofs4: fix indirect mount pending expire race" we
know longer assumed that "ino" can be null. The other null checks got
removed but this was one as missed.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
index db4117e..5c0b93f 100644
--- a/fs/autofs4/root.c
+++ b/fs/autofs4/root.c
@@ -198,8 +198,7 @@ static int try_to_fill_dentry(struct dentry *dentry, int flags)
}
/* Initialize expiry counter after successful mount */
- if (ino)
- ino->last_used = jiffies;
+ ino->last_used = jiffies;
spin_lock(&sbi->fs_lock);
ino->flags &= ~AUTOFS_INF_PENDING;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] autofs4: remove unneeded null check in try_to_fill_dentry()
@ 2010-06-01 7:15 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-06-01 7:15 UTC (permalink / raw)
To: kernel-janitors
After 97e7449a7ad: "autofs4: fix indirect mount pending expire race" we
know longer assumed that "ino" can be null. The other null checks got
removed but this was one as missed.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
index db4117e..5c0b93f 100644
--- a/fs/autofs4/root.c
+++ b/fs/autofs4/root.c
@@ -198,8 +198,7 @@ static int try_to_fill_dentry(struct dentry *dentry, int flags)
}
/* Initialize expiry counter after successful mount */
- if (ino)
- ino->last_used = jiffies;
+ ino->last_used = jiffies;
spin_lock(&sbi->fs_lock);
ino->flags &= ~AUTOFS_INF_PENDING;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-01 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-01 7:15 [patch] autofs4: remove unneeded null check in try_to_fill_dentry() Dan Carpenter
2010-06-01 7:15 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.