Re: [PATCH] drm/radeon/kms: add support for internal thermal sensors

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Tue, Jun 01, 2010 at 04:31:41PM -0400, Alex Deucher wrote:
> rv6xx/rv7xx/evergreen families supported; older asics did
> not have an internal thermal sensor.  Exposed via sysfs
> gpu_temp attribute.

This really should be done via the standard hwmon naming - some of the 
sensor tools depend on it. If there's only one sensor per GPU 
"temp1_input" is correct, with a "name" attribute indicating which card 
provides it. Also, make sure that you're exporting in millidegrees 
rather than degrees.

> Note also, that most laptops use an oem specific ACPI solution for
> GPU thermal information rather than using the internal thermal
> sensor directly.

Is there any mechanism for determining which ACPI thermal zone is 
associated with the GPU, or is this something that's hardcoded into the 
drivers?

> +	/* where's the best place to put this? */
> +	sysfs_create_group(&rdev->dev->kobj, &evergreen_hwmon_attrgroup);

They should be under the hwmon device.

-- 
Matthew Garrett | mjg59@srcf.ucam.org