From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon/kms: add support for internal thermal sensors
Date: Tue, 1 Jun 2010 22:45:37 +0100 [thread overview]
Message-ID: <20100601214537.GA18864@srcf.ucam.org> (raw)
In-Reply-To: <AANLkTilUmLEDrhhccXoGQ7pfdybYsaX1ZHyoBsdgr4kg@mail.gmail.com>
On Tue, Jun 01, 2010 at 05:41:34PM -0400, Alex Deucher wrote:
> On Tue, Jun 1, 2010 at 4:42 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > sensor tools depend on it. If there's only one sensor per GPU
> > "temp1_input" is correct, with a "name" attribute indicating which card
> > provides it. Also, make sure that you're exporting in millidegrees
> > rather than degrees.
>
> OK. Celsius I assume?
Sorry, yes.
> >> + /* where's the best place to put this? */
> >> + sysfs_create_group(&rdev->dev->kobj, &evergreen_hwmon_attrgroup);
> >
> > They should be under the hwmon device.
>
> Should this be a new device? I wasn't able to find a good example of
> a hwmon driver that was part of another driver rather than a
> standalone device.
It's what you get back from hwmon_register_device.
http://lists.freedesktop.org/archives/nouveau/2009-November/004087.html
is how I did this for nouveau, although it's not merged.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-06-01 21:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 20:31 [PATCH] drm/radeon/kms: add support for internal thermal sensors Alex Deucher
2010-06-01 20:42 ` Matthew Garrett
2010-06-01 21:41 ` Alex Deucher
2010-06-01 21:45 ` Matthew Garrett [this message]
2010-06-01 22:52 ` [PATCH] drm/radeon/kms: add support for internal thermal sensors (v2) Alex Deucher
2010-06-02 11:55 ` Julien Cristau
2010-06-02 15:51 ` Alex Deucher
2010-06-02 16:59 ` [PATCH] drm/radeon/kms: add support for internal thermal sensors (v3) Alex Deucher
2010-06-02 21:46 ` Frieder Ferlemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601214537.GA18864@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.