All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
	Chris Mason <chris.mason@oracle.com>,
	Nick Piggin <npiggin@suse.de>, Rik van Riel <riel@redhat.com>
Subject: Re: [RFC PATCH 0/6] Do not call ->writepage[s] from direct reclaim and use a_ops->writepages() where possible
Date: Tue, 8 Jun 2010 05:08:11 -0400	[thread overview]
Message-ID: <20100608090811.GA5949@infradead.org> (raw)
In-Reply-To: <1275987745-21708-1-git-send-email-mel@csn.ul.ie>

On Tue, Jun 08, 2010 at 10:02:19AM +0100, Mel Gorman wrote:
> seeky patterns.  The second is that direct reclaim calling the filesystem
> splices two potentially deep call paths together and potentially overflows
> the stack on complex storage or filesystems. This series is an early draft
> at tackling both of these problems and is in three stages.

Btw, one more thing came up when I discussed the issue again with Dave
recently:

 - we also need to care about ->releasepage.  At least for XFS it
   can end up in the same deep allocator chain as ->writepage because
   it does all the extent state conversions, even if it doesn't
   start I/O.  I haven't managed yet to decode the ext4/btrfs codepaths
   for ->releasepage yet to figure out how they release a page that
   covers a delayed allocated or unwritten range.


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
	Chris Mason <chris.mason@oracle.com>,
	Nick Piggin <npiggin@suse.de>, Rik van Riel <riel@redhat.com>
Subject: Re: [RFC PATCH 0/6] Do not call ->writepage[s] from direct reclaim and use a_ops->writepages() where possible
Date: Tue, 8 Jun 2010 05:08:11 -0400	[thread overview]
Message-ID: <20100608090811.GA5949@infradead.org> (raw)
In-Reply-To: <1275987745-21708-1-git-send-email-mel@csn.ul.ie>

On Tue, Jun 08, 2010 at 10:02:19AM +0100, Mel Gorman wrote:
> seeky patterns.  The second is that direct reclaim calling the filesystem
> splices two potentially deep call paths together and potentially overflows
> the stack on complex storage or filesystems. This series is an early draft
> at tackling both of these problems and is in three stages.

Btw, one more thing came up when I discussed the issue again with Dave
recently:

 - we also need to care about ->releasepage.  At least for XFS it
   can end up in the same deep allocator chain as ->writepage because
   it does all the extent state conversions, even if it doesn't
   start I/O.  I haven't managed yet to decode the ext4/btrfs codepaths
   for ->releasepage yet to figure out how they release a page that
   covers a delayed allocated or unwritten range.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-06-08  9:08 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08  9:02 [RFC PATCH 0/6] Do not call ->writepage[s] from direct reclaim and use a_ops->writepages() where possible Mel Gorman
2010-06-08  9:02 ` Mel Gorman
2010-06-08  9:02 ` [PATCH 1/6] tracing, vmscan: Add trace events for kswapd wakeup, sleeping and direct reclaim Mel Gorman
2010-06-08  9:02   ` Mel Gorman
2010-06-08  9:02 ` [PATCH 2/6] tracing, vmscan: Add trace events for LRU page isolation Mel Gorman
2010-06-08  9:02   ` Mel Gorman
2010-06-08  9:02 ` [PATCH 3/6] tracing, vmscan: Add trace event when a page is written Mel Gorman
2010-06-08  9:02   ` Mel Gorman
2010-06-08  9:02 ` [PATCH 4/6] tracing, vmscan: Add a postprocessing script for reclaim-related ftrace events Mel Gorman
2010-06-08  9:02   ` Mel Gorman
2010-06-08  9:02 ` [PATCH 5/6] vmscan: Write out ranges of pages contiguous to the inode where possible Mel Gorman
2010-06-08  9:02   ` Mel Gorman
2010-06-11  6:10   ` Andrew Morton
2010-06-11  6:10     ` Andrew Morton
2010-06-11 12:49     ` Mel Gorman
2010-06-11 12:49       ` Mel Gorman
2010-06-11 19:07       ` Andrew Morton
2010-06-11 19:07         ` Andrew Morton
2010-06-11 20:44         ` Mel Gorman
2010-06-11 20:44           ` Mel Gorman
2010-06-11 21:33           ` Andrew Morton
2010-06-11 21:33             ` Andrew Morton
2010-06-12  0:17             ` Mel Gorman
2010-06-12  0:17               ` Mel Gorman
2010-06-11 16:27     ` Christoph Hellwig
2010-06-11 16:27       ` Christoph Hellwig
2010-06-08  9:02 ` [PATCH 6/6] vmscan: Do not writeback pages in direct reclaim Mel Gorman
2010-06-08  9:02   ` Mel Gorman
2010-06-11  6:17   ` Andrew Morton
2010-06-11  6:17     ` Andrew Morton
2010-06-11 12:54     ` Mel Gorman
2010-06-11 12:54       ` Mel Gorman
2010-06-11 16:25     ` Christoph Hellwig
2010-06-11 16:25       ` Christoph Hellwig
2010-06-11 17:43       ` Andrew Morton
2010-06-11 17:43         ` Andrew Morton
2010-06-11 17:49         ` Christoph Hellwig
2010-06-11 17:49           ` Christoph Hellwig
2010-06-11 18:13           ` Mel Gorman
2010-06-11 18:13             ` Mel Gorman
2010-06-08  9:08 ` Christoph Hellwig [this message]
2010-06-08  9:08   ` [RFC PATCH 0/6] Do not call ->writepage[s] from direct reclaim and use a_ops->writepages() where possible Christoph Hellwig
2010-06-08  9:28   ` Mel Gorman
2010-06-08  9:28     ` Mel Gorman
2010-06-11 16:29     ` Christoph Hellwig
2010-06-11 16:29       ` Christoph Hellwig
2010-06-11 18:15       ` Mel Gorman
2010-06-11 18:15         ` Mel Gorman
2010-06-11 19:12       ` Chris Mason
2010-06-11 19:12         ` Chris Mason
2010-06-09  2:52 ` KAMEZAWA Hiroyuki
2010-06-09  2:52   ` KAMEZAWA Hiroyuki
2010-06-09  9:52   ` Mel Gorman
2010-06-09  9:52     ` Mel Gorman
2010-06-10  0:38     ` KAMEZAWA Hiroyuki
2010-06-10  0:38       ` KAMEZAWA Hiroyuki
2010-06-10  1:10       ` Mel Gorman
2010-06-10  1:10         ` Mel Gorman
2010-06-10  1:29         ` KAMEZAWA Hiroyuki
2010-06-10  1:29           ` KAMEZAWA Hiroyuki
2010-06-11  5:57 ` Andrew Morton
2010-06-11  5:57   ` Andrew Morton
2010-06-11 12:33   ` Mel Gorman
2010-06-11 12:33     ` Mel Gorman
2010-06-11 16:30     ` Christoph Hellwig
2010-06-11 16:30       ` Christoph Hellwig
2010-06-11 18:17       ` Mel Gorman
2010-06-11 18:17         ` Mel Gorman
2010-06-15 14:00 ` Andrea Arcangeli
2010-06-15 14:00   ` Andrea Arcangeli
2010-06-15 14:11   ` Christoph Hellwig
2010-06-15 14:11     ` Christoph Hellwig
2010-06-15 14:22     ` Andrea Arcangeli
2010-06-15 14:22       ` Andrea Arcangeli
2010-06-15 14:43       ` Christoph Hellwig
2010-06-15 14:43         ` Christoph Hellwig
2010-06-15 15:08         ` Andrea Arcangeli
2010-06-15 15:08           ` Andrea Arcangeli
2010-06-15 15:25           ` Christoph Hellwig
2010-06-15 15:25             ` Christoph Hellwig
2010-06-15 15:45             ` Andrea Arcangeli
2010-06-15 15:45               ` Andrea Arcangeli
2010-06-15 16:26               ` Christoph Hellwig
2010-06-15 16:26                 ` Christoph Hellwig
2010-06-15 16:31                 ` Andrea Arcangeli
2010-06-15 16:31                   ` Andrea Arcangeli
2010-06-15 16:49                 ` Rik van Riel
2010-06-15 16:49                   ` Rik van Riel
2010-06-15 16:54                   ` Christoph Hellwig
2010-06-15 16:54                     ` Christoph Hellwig
2010-06-15 19:13                     ` Rik van Riel
2010-06-15 19:13                       ` Rik van Riel
2010-06-15 19:17                       ` Christoph Hellwig
2010-06-15 19:17                         ` Christoph Hellwig
2010-06-15 19:44                         ` Chris Mason
2010-06-15 19:44                           ` Chris Mason
2010-06-16  7:57                       ` Nick Piggin
2010-06-16  7:57                         ` Nick Piggin
2010-06-16 16:59                         ` Rik van Riel
2010-06-16 16:59                           ` Rik van Riel
2010-06-16 17:04                           ` Andrea Arcangeli
2010-06-16 17:04                             ` Andrea Arcangeli
2010-06-15 16:54                   ` Nick Piggin
2010-06-15 16:54                     ` Nick Piggin
2010-06-15 15:38           ` Mel Gorman
2010-06-15 15:38             ` Mel Gorman
2010-06-15 16:14             ` Andrea Arcangeli
2010-06-15 16:14               ` Andrea Arcangeli
2010-06-15 16:22               ` Christoph Hellwig
2010-06-15 16:22                 ` Christoph Hellwig
2010-06-15 16:30               ` Mel Gorman
2010-06-15 16:30                 ` Mel Gorman
2010-06-15 16:34                 ` Mel Gorman
2010-06-15 16:34                   ` Mel Gorman
2010-06-15 16:54                   ` Andrea Arcangeli
2010-06-15 16:54                     ` Andrea Arcangeli
2010-06-15 16:35                 ` Christoph Hellwig
2010-06-15 16:35                   ` Christoph Hellwig
2010-06-15 16:37                 ` Andrea Arcangeli
2010-06-15 16:37                   ` Andrea Arcangeli
2010-06-15 17:43                   ` Christoph Hellwig
2010-06-15 17:43                     ` Christoph Hellwig
2010-06-15 16:45               ` Christoph Hellwig
2010-06-15 16:45                 ` Christoph Hellwig
2010-06-15 14:51   ` Mel Gorman
2010-06-15 14:51     ` Mel Gorman
2010-06-15 14:55     ` Rik van Riel
2010-06-15 14:55       ` Rik van Riel
2010-06-15 15:08     ` Nick Piggin
2010-06-15 15:08       ` Nick Piggin
2010-06-15 15:10       ` Mel Gorman
2010-06-15 15:10         ` Mel Gorman
2010-06-15 16:28     ` Andrea Arcangeli
2010-06-15 16:28       ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100608090811.GA5949@infradead.org \
    --to=hch@infradead.org \
    --cc=chris.mason@oracle.com \
    --cc=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.