From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Zhang Yanmin <yanmin_zhang@linux.intel.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 0/5] perf events finer grained context instrumentation / context exclusion
Date: Thu, 10 Jun 2010 09:15:19 +0200 [thread overview]
Message-ID: <20100610071517.GD12752@nowhere> (raw)
In-Reply-To: <20100610062618.GA20062@elte.hu>
On Thu, Jun 10, 2010 at 08:26:18AM +0200, Ingo Molnar wrote:
>
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> > Here is the new version of per context exclusion, based on hooks on
> > irq_enter/irq_exit. I haven't observed slowdowns but I haven't actually
> > measured the impact.
>
> One thing that would be nice to see in this discussion is a comparison of
> before/after perf stat --repeat runs.
>
> Something like:
>
> perf stat --repeat ./hackbench 5
>
> Done with full stat, and then also done with hardirqs/softirqs excluded. (i.e.
> task context stats only)
Right, so I just tried each perf stat default events with :t and it hung up ;-)
(Not severely, I can kill perf stat with ^Z, but still there is something I need
to fix).
>
> I.e. does the feature really give us the expected statistical stability in
> results? Does it really exclude hardirq/softirq workloads, etc.?
But yeah, before posting these patches I gave that a try with the instruction
counter and it didn't change much against the usual results, it's about the same
variations.
I just know the exclusion works by using perf record -g / perf report, as the
callchains are truly reliable against the exclusion rules, and since
counting and samples are treated the same in this scheme (we just deactivate
/reactivate, there is no post blocking or fixup).
I just don't know where the entropy comes from. May be once I'll have the hang
fixed I'll be able to test with all the default stat events and see a better
overview of progress.
next prev parent reply other threads:[~2010-06-10 7:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 3:49 [PATCH 0/5] perf events finer grained context instrumentation / context exclusion Frederic Weisbecker
2010-06-10 3:49 ` [PATCH 1/5] perf: Provide a proper stop action for software events Frederic Weisbecker
2010-06-10 10:46 ` Peter Zijlstra
2010-06-10 11:10 ` Peter Zijlstra
2010-06-10 16:12 ` Frederic Weisbecker
2010-06-10 16:16 ` Peter Zijlstra
2010-06-10 16:29 ` Frederic Weisbecker
2010-06-10 16:38 ` Peter Zijlstra
2010-06-10 17:04 ` Frederic Weisbecker
2010-06-10 19:54 ` Frederic Weisbecker
2010-06-10 12:06 ` Ingo Molnar
2010-06-10 3:49 ` [PATCH 2/5] perf: Support disable() after stop() on " Frederic Weisbecker
2010-06-10 10:50 ` Peter Zijlstra
2010-06-10 16:31 ` Frederic Weisbecker
2010-06-10 3:49 ` [PATCH 3/5] perf: New PERF_EVENT_STATE_PAUSED event state Frederic Weisbecker
2010-06-10 10:55 ` Peter Zijlstra
2010-06-10 16:26 ` Frederic Weisbecker
2010-06-10 3:49 ` [PATCH 4/5] perf: Introduce task, softirq and hardirq contexts exclusion Frederic Weisbecker
2010-06-10 11:01 ` Peter Zijlstra
2010-06-10 16:24 ` Frederic Weisbecker
2010-06-10 3:49 ` [PATCH 5/5] perf: Support for task/softirq/hardirq exclusion on tools Frederic Weisbecker
2010-06-10 6:26 ` [PATCH 0/5] perf events finer grained context instrumentation / context exclusion Ingo Molnar
2010-06-10 7:15 ` Frederic Weisbecker [this message]
2010-06-10 7:31 ` Frederic Weisbecker
2010-06-10 10:16 ` Ingo Molnar
2010-06-10 17:03 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610071517.GD12752@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.